[INFO] updating cached repository christiansakai/tictactoe_multiplayer_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/christiansakai/tictactoe_multiplayer_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/christiansakai/tictactoe_multiplayer_rust" "work/ex/clippy-test-run/sources/stable/gh/christiansakai/tictactoe_multiplayer_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/christiansakai/tictactoe_multiplayer_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/christiansakai/tictactoe_multiplayer_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christiansakai/tictactoe_multiplayer_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christiansakai/tictactoe_multiplayer_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c60febfdac2f10feff9f09c98c2c7e49d023da7 [INFO] sha for GitHub repo christiansakai/tictactoe_multiplayer_rust: 5c60febfdac2f10feff9f09c98c2c7e49d023da7 [INFO] validating manifest of christiansakai/tictactoe_multiplayer_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of christiansakai/tictactoe_multiplayer_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing christiansakai/tictactoe_multiplayer_rust [INFO] finished frobbing christiansakai/tictactoe_multiplayer_rust [INFO] frobbed toml for christiansakai/tictactoe_multiplayer_rust written to work/ex/clippy-test-run/sources/stable/gh/christiansakai/tictactoe_multiplayer_rust/Cargo.toml [INFO] started frobbing christiansakai/tictactoe_multiplayer_rust [INFO] finished frobbing christiansakai/tictactoe_multiplayer_rust [INFO] frobbed toml for christiansakai/tictactoe_multiplayer_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christiansakai/tictactoe_multiplayer_rust/Cargo.toml [INFO] crate christiansakai/tictactoe_multiplayer_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting christiansakai/tictactoe_multiplayer_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christiansakai/tictactoe_multiplayer_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d83bf1306fed5f19575abdfcb2d2ad8db5d4c25a5fba5811fe8cde5849c2d34f [INFO] running `"docker" "start" "-a" "d83bf1306fed5f19575abdfcb2d2ad8db5d4c25a5fba5811fe8cde5849c2d34f"` [INFO] [stderr] Checking tictactoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:13:42 [INFO] [stderr] | [INFO] [stderr] 13 | Player::O => write!(f, "{}", "O"), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | Player::X => write!(f, "{}", "X"), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | Player::Clear => write!(f, "{}", " "), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:13:42 [INFO] [stderr] | [INFO] [stderr] 13 | Player::O => write!(f, "{}", "O"), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | Player::X => write!(f, "{}", "X"), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | Player::Clear => write!(f, "{}", " "), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/network/client.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | const ADDRESS: &'static str = "127.0.0.1:6000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/network/server.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | const ADDRESS: &'static str = "127.0.0.1:6000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/network/client.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | const ADDRESS: &'static str = "127.0.0.1:6000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/network/server.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | const ADDRESS: &'static str = "127.0.0.1:6000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::TicTacToe` [INFO] [stderr] --> src/game.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> TicTacToe { [INFO] [stderr] 28 | | let mut board: Vec> = Vec::new(); [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | for _r in 0..3 { [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for game::TicTacToe { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/game.rs:162:23 [INFO] [stderr] | [INFO] [stderr] 162 | let row = 0 + x; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/network/client.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .expect(&format!("Failed to connect to server {}", ADDRESS)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect to server {}", ADDRESS))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/network/server.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | .expect(&format!("Failed to clone client {}", address)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to clone client {}", address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::TicTacToe` [INFO] [stderr] --> src/game.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> TicTacToe { [INFO] [stderr] 28 | | let mut board: Vec> = Vec::new(); [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | for _r in 0..3 { [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for game::TicTacToe { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/game.rs:162:23 [INFO] [stderr] | [INFO] [stderr] 162 | let row = 0 + x; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _result =` [INFO] [stderr] --> src/game.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | let _result = game.fill(0, 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/network/client.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .expect(&format!("Failed to connect to server {}", ADDRESS)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect to server {}", ADDRESS))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/network/server.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | .expect(&format!("Failed to clone client {}", address)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to clone client {}", address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused imports: `client`, `server` [INFO] [stderr] --> src/main.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | use tictactoe::network::{server, client}; [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `client`, `server` [INFO] [stderr] --> src/main.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | use tictactoe::network::{server, client}; [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "d83bf1306fed5f19575abdfcb2d2ad8db5d4c25a5fba5811fe8cde5849c2d34f"` [INFO] running `"docker" "rm" "-f" "d83bf1306fed5f19575abdfcb2d2ad8db5d4c25a5fba5811fe8cde5849c2d34f"` [INFO] [stdout] d83bf1306fed5f19575abdfcb2d2ad8db5d4c25a5fba5811fe8cde5849c2d34f