[INFO] updating cached repository chrisshyi/kosarajuSCC [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrisshyi/kosarajuSCC [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrisshyi/kosarajuSCC" "work/ex/clippy-test-run/sources/stable/gh/chrisshyi/kosarajuSCC"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisshyi/kosarajuSCC'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrisshyi/kosarajuSCC" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/kosarajuSCC"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/kosarajuSCC'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd8d6e8222600650dfcde4949060a7d698a8a26c [INFO] sha for GitHub repo chrisshyi/kosarajuSCC: fd8d6e8222600650dfcde4949060a7d698a8a26c [INFO] validating manifest of chrisshyi/kosarajuSCC on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrisshyi/kosarajuSCC on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrisshyi/kosarajuSCC [INFO] finished frobbing chrisshyi/kosarajuSCC [INFO] frobbed toml for chrisshyi/kosarajuSCC written to work/ex/clippy-test-run/sources/stable/gh/chrisshyi/kosarajuSCC/Cargo.toml [INFO] started frobbing chrisshyi/kosarajuSCC [INFO] finished frobbing chrisshyi/kosarajuSCC [INFO] frobbed toml for chrisshyi/kosarajuSCC written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/kosarajuSCC/Cargo.toml [INFO] crate chrisshyi/kosarajuSCC has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrisshyi/kosarajuSCC against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/kosarajuSCC:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 715ed6a20f5483d6190d5d53c2d79a1df997ec727ae4f7b57af8bf7c7a26111a [INFO] running `"docker" "start" "-a" "715ed6a20f5483d6190d5d53c2d79a1df997ec727ae4f7b57af8bf7c7a26111a"` [INFO] [stderr] Checking kosarajuSCC v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | scc_map [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | let scc_map = dfs_outer(relabelled_graph, false, num_vertices); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | scc_map [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | let scc_map = dfs_outer(relabelled_graph, false, num_vertices); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tail_vertx` is never read [INFO] [stderr] --> src/lib.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `head_vertx` is never read [INFO] [stderr] --> src/lib.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tail_vertx` is never read [INFO] [stderr] --> src/lib.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `head_vertx` is never read [INFO] [stderr] --> src/lib.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `kosarajuSCC` should have a snake case name such as `kosaraju_scc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tail_vertx` is never read [INFO] [stderr] --> src/lib.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `head_vertx` is never read [INFO] [stderr] --> src/lib.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tail_vertx` is never read [INFO] [stderr] --> src/lib.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `head_vertx` is never read [INFO] [stderr] --> src/lib.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | let (mut tail_vertx, mut head_vertx) = (0, 0); // Compiler won't allow use of uninitialized variables [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:50:49 [INFO] [stderr] | [INFO] [stderr] 50 | let neighbors = graph.entry(head_vertx).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | for vertex in (1..num_vertices + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=num_vertices)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:147:55 [INFO] [stderr] | [INFO] [stderr] 147 | let neighbors = graph.entry(*relabelled_tail).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: crate `kosarajuSCC` should have a snake case name such as `kosaraju_scc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:50:49 [INFO] [stderr] | [INFO] [stderr] 50 | let neighbors = graph.entry(head_vertx).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | for vertex in (1..num_vertices + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=num_vertices)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:147:55 [INFO] [stderr] | [INFO] [stderr] 147 | let neighbors = graph.entry(*relabelled_tail).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | assert!(reverse_graph.get(&4).unwrap().contains(&2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_graph[&4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | assert!(reverse_graph.get(&2).unwrap().contains(&1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_graph[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | assert!(reverse_graph.get(&1).unwrap().contains(&3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_graph[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | assert!(reverse_graph.get(&3).unwrap().contains(&2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_graph[&3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | assert_eq!(relabelled_graph.get(&2).unwrap().len(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&relabelled_graph[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:199:20 [INFO] [stderr] | [INFO] [stderr] 199 | assert_eq!(relabelled_graph.get(&3).unwrap().len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&relabelled_graph[&3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(relabelled_graph.get(&4).unwrap().len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&relabelled_graph[&4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | assert_eq!(relabelled_graph.get(&5).unwrap().len(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&relabelled_graph[&5]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:202:20 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(relabelled_graph.get(&6).unwrap().len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&relabelled_graph[&6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(relabelled_graph.get(&1).unwrap().len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&relabelled_graph[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `kosarajuSCC` should have a snake case name such as `kosaraju_scc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `kosarajuSCC` should have a snake case name such as `kosaraju_scc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "715ed6a20f5483d6190d5d53c2d79a1df997ec727ae4f7b57af8bf7c7a26111a"` [INFO] running `"docker" "rm" "-f" "715ed6a20f5483d6190d5d53c2d79a1df997ec727ae4f7b57af8bf7c7a26111a"` [INFO] [stdout] 715ed6a20f5483d6190d5d53c2d79a1df997ec727ae4f7b57af8bf7c7a26111a