[INFO] updating cached repository chrisshyi/MinHeap
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/chrisshyi/MinHeap
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/chrisshyi/MinHeap" "work/ex/clippy-test-run/sources/stable/gh/chrisshyi/MinHeap"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisshyi/MinHeap'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/chrisshyi/MinHeap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/MinHeap"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/MinHeap'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3d740e76adb988c43a0c63dc862e8aa587aece0d
[INFO] sha for GitHub repo chrisshyi/MinHeap: 3d740e76adb988c43a0c63dc862e8aa587aece0d
[INFO] validating manifest of chrisshyi/MinHeap on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chrisshyi/MinHeap on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chrisshyi/MinHeap
[INFO] finished frobbing chrisshyi/MinHeap
[INFO] frobbed toml for chrisshyi/MinHeap written to work/ex/clippy-test-run/sources/stable/gh/chrisshyi/MinHeap/Cargo.toml
[INFO] started frobbing chrisshyi/MinHeap
[INFO] finished frobbing chrisshyi/MinHeap
[INFO] frobbed toml for chrisshyi/MinHeap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/MinHeap/Cargo.toml
[INFO] crate chrisshyi/MinHeap has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chrisshyi/MinHeap against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisshyi/MinHeap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e7ab53411e26a4364f616ed7dd651db4b96268da7031050aa4bdc57a764f79f6
[INFO] running `"docker" "start" "-a" "e7ab53411e26a4364f616ed7dd651db4b96268da7031050aa4bdc57a764f79f6"`
[INFO] [stderr]     Checking min_heap v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 69 | |             if node_to_sink > child1 {
[INFO] [stderr] 70 | |                 self.data.swap(index, child1_index);
[INFO] [stderr] 71 | |                 self.sink_down(child1_index);
[INFO] [stderr] 72 | |             }
[INFO] [stderr] 73 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |         } else if node_to_sink > child1 {
[INFO] [stderr] 69 |     self.data.swap(index, child1_index);
[INFO] [stderr] 70 |     self.sink_down(child1_index);
[INFO] [stderr] 71 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MinHeap<T>`
[INFO] [stderr]   --> src/lib.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> MinHeap<T> {
[INFO] [stderr] 17 | |         MinHeap {
[INFO] [stderr] 18 | |             data: Vec::new(),
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 69 | |             if node_to_sink > child1 {
[INFO] [stderr] 70 | |                 self.data.swap(index, child1_index);
[INFO] [stderr] 71 | |                 self.sink_down(child1_index);
[INFO] [stderr] 72 | |             }
[INFO] [stderr] 73 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |         } else if node_to_sink > child1 {
[INFO] [stderr] 69 |     self.data.swap(index, child1_index);
[INFO] [stderr] 70 |     self.sink_down(child1_index);
[INFO] [stderr] 71 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MinHeap<T>`
[INFO] [stderr]   --> src/lib.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> MinHeap<T> {
[INFO] [stderr] 17 | |         MinHeap {
[INFO] [stderr] 18 | |             data: Vec::new(),
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         if max_heap.len() > min_heap.len() {
[INFO] [stderr] 38 | |             if max_heap.len() - min_heap.len() > 1 {
[INFO] [stderr] 39 | |                 let rebalance_item = max_heap.pop().unwrap();
[INFO] [stderr] 40 | |                 min_heap.push(rebalance_item);
[INFO] [stderr] 41 | |             }
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if max_heap.len() > min_heap.len() && max_heap.len() - min_heap.len() > 1 {
[INFO] [stderr] 38 |     let rebalance_item = max_heap.pop().unwrap();
[INFO] [stderr] 39 |     min_heap.push(rebalance_item);
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         if min_heap.len() > max_heap.len() {
[INFO] [stderr] 44 | |             if min_heap.len() - max_heap.len() > 1 {
[INFO] [stderr] 45 | |                 let rebalance_item = min_heap.pop().unwrap();
[INFO] [stderr] 46 | |                 max_heap.push(rebalance_item);
[INFO] [stderr] 47 | |             }
[INFO] [stderr] 48 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if min_heap.len() > max_heap.len() && min_heap.len() - max_heap.len() > 1 {
[INFO] [stderr] 44 |     let rebalance_item = min_heap.pop().unwrap();
[INFO] [stderr] 45 |     max_heap.push(rebalance_item);
[INFO] [stderr] 46 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         if max_heap.len() > min_heap.len() {
[INFO] [stderr] 38 | |             if max_heap.len() - min_heap.len() > 1 {
[INFO] [stderr] 39 | |                 let rebalance_item = max_heap.pop().unwrap();
[INFO] [stderr] 40 | |                 min_heap.push(rebalance_item);
[INFO] [stderr] 41 | |             }
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if max_heap.len() > min_heap.len() && max_heap.len() - min_heap.len() > 1 {
[INFO] [stderr] 38 |     let rebalance_item = max_heap.pop().unwrap();
[INFO] [stderr] 39 |     min_heap.push(rebalance_item);
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         if min_heap.len() > max_heap.len() {
[INFO] [stderr] 44 | |             if min_heap.len() - max_heap.len() > 1 {
[INFO] [stderr] 45 | |                 let rebalance_item = min_heap.pop().unwrap();
[INFO] [stderr] 46 | |                 max_heap.push(rebalance_item);
[INFO] [stderr] 47 | |             }
[INFO] [stderr] 48 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if min_heap.len() > max_heap.len() && min_heap.len() - max_heap.len() > 1 {
[INFO] [stderr] 44 |     let rebalance_item = min_heap.pop().unwrap();
[INFO] [stderr] 45 |     max_heap.push(rebalance_item);
[INFO] [stderr] 46 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         let mut median: i32;
[INFO] [stderr] 50 | |         if min_heap.len() > max_heap.len() {
[INFO] [stderr] 51 | |             median = *min_heap.peek().unwrap();
[INFO] [stderr] 52 | |         } else {
[INFO] [stderr] 53 | |             median = *max_heap.peek().unwrap();
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> median = if min_heap.len() > max_heap.len() { *min_heap.peek().unwrap() } else { *max_heap.peek().unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         let mut median: i32;
[INFO] [stderr] 50 | |         if min_heap.len() > max_heap.len() {
[INFO] [stderr] 51 | |             median = *min_heap.peek().unwrap();
[INFO] [stderr] 52 | |         } else {
[INFO] [stderr] 53 | |             median = *max_heap.peek().unwrap();
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> median = if min_heap.len() > max_heap.len() { *min_heap.peek().unwrap() } else { *max_heap.peek().unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.10s
[INFO] running `"docker" "inspect" "e7ab53411e26a4364f616ed7dd651db4b96268da7031050aa4bdc57a764f79f6"`
[INFO] running `"docker" "rm" "-f" "e7ab53411e26a4364f616ed7dd651db4b96268da7031050aa4bdc57a764f79f6"`
[INFO] [stdout] e7ab53411e26a4364f616ed7dd651db4b96268da7031050aa4bdc57a764f79f6