[INFO] updating cached repository chrisf1337/magician [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrisf1337/magician [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrisf1337/magician" "work/ex/clippy-test-run/sources/stable/gh/chrisf1337/magician"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisf1337/magician'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrisf1337/magician" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisf1337/magician"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisf1337/magician'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 522459c534dcdf08ba33a708930cdebc5d4ce176 [INFO] sha for GitHub repo chrisf1337/magician: 522459c534dcdf08ba33a708930cdebc5d4ce176 [INFO] validating manifest of chrisf1337/magician on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrisf1337/magician on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrisf1337/magician [INFO] finished frobbing chrisf1337/magician [INFO] frobbed toml for chrisf1337/magician written to work/ex/clippy-test-run/sources/stable/gh/chrisf1337/magician/Cargo.toml [INFO] started frobbing chrisf1337/magician [INFO] finished frobbing chrisf1337/magician [INFO] frobbed toml for chrisf1337/magician written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisf1337/magician/Cargo.toml [INFO] crate chrisf1337/magician has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrisf1337/magician against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisf1337/magician:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42a7c905baa18041faba181a586ce6100e022d66d513a083d7816cd40962b9a5 [INFO] running `"docker" "start" "-a" "42a7c905baa18041faba181a586ce6100e022d66d513a083d7816cd40962b9a5"` [INFO] [stderr] Checking magician v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking maplit v1.0.1 [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/magicparser/selectorparser.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / if op.is_none() { [INFO] [stderr] 294 | | if case_insensitive { [INFO] [stderr] 295 | | return Err(SelectorParserError::Unexpected( [INFO] [stderr] 296 | | start_pos, [INFO] [stderr] ... | [INFO] [stderr] 299 | | } [INFO] [stderr] 300 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 293 | if op.is_none() && case_insensitive { [INFO] [stderr] 294 | return Err(SelectorParserError::Unexpected( [INFO] [stderr] 295 | start_pos, [INFO] [stderr] 296 | "cannot specify i/I for attribute selector without op and val".to_string(), [INFO] [stderr] 297 | )); [INFO] [stderr] 298 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `parser_err` is never read [INFO] [stderr] --> src/magicparser/selectorparser.rs:327:17 [INFO] [stderr] | [INFO] [stderr] 327 | let mut parser_err: Option = None; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/magicparser/selectorparser.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / if op.is_none() { [INFO] [stderr] 294 | | if case_insensitive { [INFO] [stderr] 295 | | return Err(SelectorParserError::Unexpected( [INFO] [stderr] 296 | | start_pos, [INFO] [stderr] ... | [INFO] [stderr] 299 | | } [INFO] [stderr] 300 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 293 | if op.is_none() && case_insensitive { [INFO] [stderr] 294 | return Err(SelectorParserError::Unexpected( [INFO] [stderr] 295 | start_pos, [INFO] [stderr] 296 | "cannot specify i/I for attribute selector without op and val".to_string(), [INFO] [stderr] 297 | )); [INFO] [stderr] 298 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matches_simple_selector` [INFO] [stderr] --> src/style/selectormatcher.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / fn matches_simple_selector( [INFO] [stderr] 6 | | node: &DomNodeRef, [INFO] [stderr] 7 | | SimpleSelector { [INFO] [stderr] 8 | | elem_type, [INFO] [stderr] ... | [INFO] [stderr] 28 | | true [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matches_attr_selector` [INFO] [stderr] --> src/style/selectormatcher.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / fn matches_attr_selector( [INFO] [stderr] 32 | | node: &DomNodeRef, [INFO] [stderr] 33 | | AttrSelector { [INFO] [stderr] 34 | | attr, [INFO] [stderr] ... | [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matches_pseudo_class_selector` [INFO] [stderr] --> src/style/selectormatcher.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | fn matches_pseudo_class_selector(dom_node: &DomNodeRef, selector: &PseudoClassSelector) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matching_child_combinator_nodes` [INFO] [stderr] --> src/style/selectormatcher.rs:191:1 [INFO] [stderr] | [INFO] [stderr] 191 | fn matching_child_combinator_nodes(dom_node: &DomNodeRef, selector: &Selector) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matching_gen_sib_combinator_nodes` [INFO] [stderr] --> src/style/selectormatcher.rs:209:1 [INFO] [stderr] | [INFO] [stderr] 209 | / fn matching_gen_sib_combinator_nodes( [INFO] [stderr] 210 | | dom_node: &DomNodeRef, [INFO] [stderr] 211 | | selector: &Selector, [INFO] [stderr] 212 | | ) -> Vec { [INFO] [stderr] ... | [INFO] [stderr] 227 | | } [INFO] [stderr] 228 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matches` [INFO] [stderr] --> src/style/selectormatcher.rs:230:1 [INFO] [stderr] | [INFO] [stderr] 230 | fn matches(dom_node: &DomNodeRef, selector: &Selector) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/magicparser/parser.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | parsers: &[fn(&mut Self) -> Result], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::type_complexity)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/magicparser/parser.rs:216:43 [INFO] [stderr] | [INFO] [stderr] 216 | fn try_parsers(&mut self, parsers: &[fn(&mut Self) -> Result]) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/magicparser/postparse.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn to_dnref(self) -> DomNodeRef { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/magicparser/postparse.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn add_child<'a>(&'a self, child: DomNodeRef) -> &'a Self { [INFO] [stderr] 90 | | let node = &self.ptr; [INFO] [stderr] 91 | | child.borrow_mut().parent = Some(Rc::downgrade(node)); [INFO] [stderr] 92 | | let mut node = node.borrow_mut(); [INFO] [stderr] 93 | | node.children.push(child); [INFO] [stderr] 94 | | self [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/magicparser/postparse.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | parent.borrow().children.iter().map(|x| x.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `parent.borrow().children.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::map_clone)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/magicparser/postparse.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | / match self { [INFO] [stderr] 298 | | &A(a) => a == i, [INFO] [stderr] 299 | | &AnOpB(a, Some(NthExprOp::Add), b) => (i - b) / a >= 0 && (i - b) % a == 0, [INFO] [stderr] 300 | | [INFO] [stderr] 301 | | &AnOpB(a, Some(NthExprOp::Sub), b) => (i + b) / a >= 0 && (i + b) % a == 0, [INFO] [stderr] 302 | | &AnOpB(a, None, _) => i / a >= 0 && i % a == 0, [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 297 | match *self { [INFO] [stderr] 298 | A(a) => a == i, [INFO] [stderr] 299 | AnOpB(a, Some(NthExprOp::Add), b) => (i - b) / a >= 0 && (i - b) % a == 0, [INFO] [stderr] 300 | [INFO] [stderr] 301 | AnOpB(a, Some(NthExprOp::Sub), b) => (i + b) / a >= 0 && (i + b) % a == 0, [INFO] [stderr] 302 | AnOpB(a, None, _) => i / a >= 0 && i % a == 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/magicparser/selectorparser.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | / match self.lexer.try_parse_chars_strict("n") { [INFO] [stderr] 387 | | Ok(_) => true, [INFO] [stderr] 388 | | Err(_) => false, [INFO] [stderr] 389 | | } [INFO] [stderr] | |_____________________^ help: try this: `self.lexer.try_parse_chars_strict("n").is_ok()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/magicparser/selectorparser.rs:391:21 [INFO] [stderr] | [INFO] [stderr] 391 | / match self.lexer.try_parse_chars("n") { [INFO] [stderr] 392 | | Ok(_) => true, [INFO] [stderr] 393 | | Err(_) => false, [INFO] [stderr] 394 | | } [INFO] [stderr] | |_____________________^ help: try this: `self.lexer.try_parse_chars("n").is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/style/selectormatcher.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | / attr_value [INFO] [stderr] 75 | | .split_whitespace() [INFO] [stderr] 76 | | .find(|&s| { [INFO] [stderr] 77 | | s.to_lowercase() == val.to_lowercase() [INFO] [stderr] ... | [INFO] [stderr] 80 | | }) [INFO] [stderr] 81 | | .is_some() [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::search_is_some)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/style/selectormatcher.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | / attr_value [INFO] [stderr] 84 | | .split_whitespace() [INFO] [stderr] 85 | | .find(|&s| s == val || s.starts_with(&format!("{}-", val))) [INFO] [stderr] 86 | | .is_some() [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&s| s == val || s.starts_with(&format!("{}-", val))).is_some()` with `any(|&s| s == val || s.starts_with(&format!("{}-", val)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/style/selectormatcher.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | None => match attrs.get(attr) { [INFO] [stderr] | _________________^ [INFO] [stderr] 113 | | Some(_) => true, [INFO] [stderr] 114 | | None => false, [INFO] [stderr] 115 | | }, [INFO] [stderr] | |_________^ help: try this: `attrs.get(attr).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/style/selectormatcher.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / match selector { [INFO] [stderr] 193 | | &Selector::Combinator(ref first, Combinator::Child, ref second) => { [INFO] [stderr] 194 | | if !matches(dom_node, first) { [INFO] [stderr] 195 | | return vec![]; [INFO] [stderr] ... | [INFO] [stderr] 203 | | _ => unreachable!(), [INFO] [stderr] 204 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 192 | match *selector { [INFO] [stderr] 193 | Selector::Combinator(ref first, Combinator::Child, ref second) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/style/selectormatcher.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | / (&dom_node.borrow().children) [INFO] [stderr] 198 | | .iter() [INFO] [stderr] 199 | | .filter(|child| matches(child, second)) [INFO] [stderr] 200 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 197 | (&dom_node.borrow().children) [INFO] [stderr] 198 | .iter() [INFO] [stderr] 199 | .filter(|child| matches(child, second)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/style/selectormatcher.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | / match selector { [INFO] [stderr] 214 | | &Selector::Combinator(ref first, Combinator::GeneralSibling, ref second) => { [INFO] [stderr] 215 | | if !matches(dom_node, first) { [INFO] [stderr] 216 | | return vec![]; [INFO] [stderr] ... | [INFO] [stderr] 226 | | _ => unreachable!(), [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 213 | match *selector { [INFO] [stderr] 214 | Selector::Combinator(ref first, Combinator::GeneralSibling, ref second) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/style/selectormatcher.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / (&siblings[child_index..]) [INFO] [stderr] 221 | | .iter() [INFO] [stderr] 222 | | .filter(|x| matches(x, second)) [INFO] [stderr] 223 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 220 | (&siblings[child_index..]) [INFO] [stderr] 221 | .iter() [INFO] [stderr] 222 | .filter(|x| matches(x, second)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/main.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let mut f = File::open(filename).expect(&format!("file {:?} not found", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("file {:?} not found", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/main.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | .expect(&format!("error reading file {:?}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error reading file {:?}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/main.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let mut f = File::open(filename).expect(&format!("file {:?} not found", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("file {:?} not found", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/main.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | .expect(&format!("error reading file {:?}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error reading file {:?}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: value assigned to `parser_err` is never read [INFO] [stderr] --> src/magicparser/selectorparser.rs:327:17 [INFO] [stderr] | [INFO] [stderr] 327 | let mut parser_err: Option = None; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/magicparser/parser.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | parsers: &[fn(&mut Self) -> Result], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::type_complexity)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/magicparser/parser.rs:216:43 [INFO] [stderr] | [INFO] [stderr] 216 | fn try_parsers(&mut self, parsers: &[fn(&mut Self) -> Result]) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/magicparser/postparse.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn to_dnref(self) -> DomNodeRef { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/magicparser/postparse.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn add_child<'a>(&'a self, child: DomNodeRef) -> &'a Self { [INFO] [stderr] 90 | | let node = &self.ptr; [INFO] [stderr] 91 | | child.borrow_mut().parent = Some(Rc::downgrade(node)); [INFO] [stderr] 92 | | let mut node = node.borrow_mut(); [INFO] [stderr] 93 | | node.children.push(child); [INFO] [stderr] 94 | | self [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/magicparser/postparse.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | parent.borrow().children.iter().map(|x| x.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `parent.borrow().children.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::map_clone)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/magicparser/postparse.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | / match self { [INFO] [stderr] 298 | | &A(a) => a == i, [INFO] [stderr] 299 | | &AnOpB(a, Some(NthExprOp::Add), b) => (i - b) / a >= 0 && (i - b) % a == 0, [INFO] [stderr] 300 | | [INFO] [stderr] 301 | | &AnOpB(a, Some(NthExprOp::Sub), b) => (i + b) / a >= 0 && (i + b) % a == 0, [INFO] [stderr] 302 | | &AnOpB(a, None, _) => i / a >= 0 && i % a == 0, [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 297 | match *self { [INFO] [stderr] 298 | A(a) => a == i, [INFO] [stderr] 299 | AnOpB(a, Some(NthExprOp::Add), b) => (i - b) / a >= 0 && (i - b) % a == 0, [INFO] [stderr] 300 | [INFO] [stderr] 301 | AnOpB(a, Some(NthExprOp::Sub), b) => (i + b) / a >= 0 && (i + b) % a == 0, [INFO] [stderr] 302 | AnOpB(a, None, _) => i / a >= 0 && i % a == 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/magicparser/selectorparser.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | / match self.lexer.try_parse_chars_strict("n") { [INFO] [stderr] 387 | | Ok(_) => true, [INFO] [stderr] 388 | | Err(_) => false, [INFO] [stderr] 389 | | } [INFO] [stderr] | |_____________________^ help: try this: `self.lexer.try_parse_chars_strict("n").is_ok()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/magicparser/selectorparser.rs:391:21 [INFO] [stderr] | [INFO] [stderr] 391 | / match self.lexer.try_parse_chars("n") { [INFO] [stderr] 392 | | Ok(_) => true, [INFO] [stderr] 393 | | Err(_) => false, [INFO] [stderr] 394 | | } [INFO] [stderr] | |_____________________^ help: try this: `self.lexer.try_parse_chars("n").is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/style/selectormatcher.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | / attr_value [INFO] [stderr] 75 | | .split_whitespace() [INFO] [stderr] 76 | | .find(|&s| { [INFO] [stderr] 77 | | s.to_lowercase() == val.to_lowercase() [INFO] [stderr] ... | [INFO] [stderr] 80 | | }) [INFO] [stderr] 81 | | .is_some() [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::search_is_some)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/style/selectormatcher.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | / attr_value [INFO] [stderr] 84 | | .split_whitespace() [INFO] [stderr] 85 | | .find(|&s| s == val || s.starts_with(&format!("{}-", val))) [INFO] [stderr] 86 | | .is_some() [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&s| s == val || s.starts_with(&format!("{}-", val))).is_some()` with `any(|&s| s == val || s.starts_with(&format!("{}-", val)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/style/selectormatcher.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | None => match attrs.get(attr) { [INFO] [stderr] | _________________^ [INFO] [stderr] 113 | | Some(_) => true, [INFO] [stderr] 114 | | None => false, [INFO] [stderr] 115 | | }, [INFO] [stderr] | |_________^ help: try this: `attrs.get(attr).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/style/selectormatcher.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / match selector { [INFO] [stderr] 193 | | &Selector::Combinator(ref first, Combinator::Child, ref second) => { [INFO] [stderr] 194 | | if !matches(dom_node, first) { [INFO] [stderr] 195 | | return vec![]; [INFO] [stderr] ... | [INFO] [stderr] 203 | | _ => unreachable!(), [INFO] [stderr] 204 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 192 | match *selector { [INFO] [stderr] 193 | Selector::Combinator(ref first, Combinator::Child, ref second) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/style/selectormatcher.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | / (&dom_node.borrow().children) [INFO] [stderr] 198 | | .iter() [INFO] [stderr] 199 | | .filter(|child| matches(child, second)) [INFO] [stderr] 200 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 197 | (&dom_node.borrow().children) [INFO] [stderr] 198 | .iter() [INFO] [stderr] 199 | .filter(|child| matches(child, second)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/style/selectormatcher.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | / match selector { [INFO] [stderr] 214 | | &Selector::Combinator(ref first, Combinator::GeneralSibling, ref second) => { [INFO] [stderr] 215 | | if !matches(dom_node, first) { [INFO] [stderr] 216 | | return vec![]; [INFO] [stderr] ... | [INFO] [stderr] 226 | | _ => unreachable!(), [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 213 | match *selector { [INFO] [stderr] 214 | Selector::Combinator(ref first, Combinator::GeneralSibling, ref second) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/style/selectormatcher.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / (&siblings[child_index..]) [INFO] [stderr] 221 | | .iter() [INFO] [stderr] 222 | | .filter(|x| matches(x, second)) [INFO] [stderr] 223 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 220 | (&siblings[child_index..]) [INFO] [stderr] 221 | .iter() [INFO] [stderr] 222 | .filter(|x| matches(x, second)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.97s [INFO] running `"docker" "inspect" "42a7c905baa18041faba181a586ce6100e022d66d513a083d7816cd40962b9a5"` [INFO] running `"docker" "rm" "-f" "42a7c905baa18041faba181a586ce6100e022d66d513a083d7816cd40962b9a5"` [INFO] [stdout] 42a7c905baa18041faba181a586ce6100e022d66d513a083d7816cd40962b9a5