[INFO] updating cached repository chridou/towers-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/chridou/towers-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/chridou/towers-rs" "work/ex/clippy-test-run/sources/stable/gh/chridou/towers-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chridou/towers-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/chridou/towers-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chridou/towers-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chridou/towers-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ff40f92499bad724e9a4025f4b996012120e323e
[INFO] sha for GitHub repo chridou/towers-rs: ff40f92499bad724e9a4025f4b996012120e323e
[INFO] validating manifest of chridou/towers-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chridou/towers-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chridou/towers-rs
[INFO] finished frobbing chridou/towers-rs
[INFO] frobbed toml for chridou/towers-rs written to work/ex/clippy-test-run/sources/stable/gh/chridou/towers-rs/Cargo.toml
[INFO] started frobbing chridou/towers-rs
[INFO] finished frobbing chridou/towers-rs
[INFO] frobbed toml for chridou/towers-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chridou/towers-rs/Cargo.toml
[INFO] crate chridou/towers-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chridou/towers-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chridou/towers-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] abf4faf42a8ffe7053552437f8f7d8dbdaa800938b59d88ebca7cc507b20c197
[INFO] running `"docker" "start" "-a" "abf4faf42a8ffe7053552437f8f7d8dbdaa800938b59d88ebca7cc507b20c197"`
[INFO] [stderr]     Checking clap v2.23.2
[INFO] [stderr]     Checking towers v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:141:29
[INFO] [stderr]     |
[INFO] [stderr] 141 |                             from: from,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:142:29
[INFO] [stderr]     |
[INFO] [stderr] 142 |                             to: to,
[INFO] [stderr]     |                             ^^^^^^ help: replace it with: `to`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:175:13
[INFO] [stderr]     |
[INFO] [stderr] 175 |             player: player,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `player`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:176:13
[INFO] [stderr]     |
[INFO] [stderr] 176 |             board: board,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `board`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:182:13
[INFO] [stderr]     |
[INFO] [stderr] 182 |             player: player,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `player`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:141:29
[INFO] [stderr]     |
[INFO] [stderr] 141 |                             from: from,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:142:29
[INFO] [stderr]     |
[INFO] [stderr] 142 |                             to: to,
[INFO] [stderr]     |                             ^^^^^^ help: replace it with: `to`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:175:13
[INFO] [stderr]     |
[INFO] [stderr] 175 |             player: player,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `player`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:176:13
[INFO] [stderr]     |
[INFO] [stderr] 176 |             board: board,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `board`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:182:13
[INFO] [stderr]     |
[INFO] [stderr] 182 |             player: player,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `player`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Peg`
[INFO] [stderr]   --> src/lib.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Peg {
[INFO] [stderr] 21 | |         Peg { disks: Vec::new() }
[INFO] [stderr] 22 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/lib.rs:34:56
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let may_add = self.disks.last().map(|top_disk| top_disk > &disk).unwrap_or(true);
[INFO] [stderr]    |                                                        ^^^^^^^^^^^-----
[INFO] [stderr]    |                                                                   |
[INFO] [stderr]    |                                                                   help: use the right value directly: `disk`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:137:59
[INFO] [stderr]     |
[INFO] [stderr] 137 |                     .and_then(|maybe_a_disk| maybe_a_disk.ok_or("no disc!".to_string()))
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no disc!".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:202:53
[INFO] [stderr]     |
[INFO] [stderr] 202 |             Err(err) => SessionEvent::PlayerCheated(format!("{}", err)),
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:206:5
[INFO] [stderr]     |
[INFO] [stderr] 206 | /     pub fn iter<'a>(&'a mut self) -> SessionIterator<P> {
[INFO] [stderr] 207 | |         SessionIterator {
[INFO] [stderr] 208 | |             is_finished: false,
[INFO] [stderr] 209 | |             session: self,
[INFO] [stderr] 210 | |         }
[INFO] [stderr] 211 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Peg`
[INFO] [stderr]   --> src/lib.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Peg {
[INFO] [stderr] 21 | |         Peg { disks: Vec::new() }
[INFO] [stderr] 22 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/lib.rs:34:56
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let may_add = self.disks.last().map(|top_disk| top_disk > &disk).unwrap_or(true);
[INFO] [stderr]    |                                                        ^^^^^^^^^^^-----
[INFO] [stderr]    |                                                                   |
[INFO] [stderr]    |                                                                   help: use the right value directly: `disk`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:137:59
[INFO] [stderr]     |
[INFO] [stderr] 137 |                     .and_then(|maybe_a_disk| maybe_a_disk.ok_or("no disc!".to_string()))
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no disc!".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:202:53
[INFO] [stderr]     |
[INFO] [stderr] 202 |             Err(err) => SessionEvent::PlayerCheated(format!("{}", err)),
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:206:5
[INFO] [stderr]     |
[INFO] [stderr] 206 | /     pub fn iter<'a>(&'a mut self) -> SessionIterator<P> {
[INFO] [stderr] 207 | |         SessionIterator {
[INFO] [stderr] 208 | |             is_finished: false,
[INFO] [stderr] 209 | |             session: self,
[INFO] [stderr] 210 | |         }
[INFO] [stderr] 211 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.35s
[INFO] running `"docker" "inspect" "abf4faf42a8ffe7053552437f8f7d8dbdaa800938b59d88ebca7cc507b20c197"`
[INFO] running `"docker" "rm" "-f" "abf4faf42a8ffe7053552437f8f7d8dbdaa800938b59d88ebca7cc507b20c197"`
[INFO] [stdout] abf4faf42a8ffe7053552437f8f7d8dbdaa800938b59d88ebca7cc507b20c197