[INFO] updating cached repository chr4/horsegen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chr4/horsegen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chr4/horsegen" "work/ex/clippy-test-run/sources/stable/gh/chr4/horsegen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chr4/horsegen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chr4/horsegen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chr4/horsegen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chr4/horsegen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 09eb799dc46a36f7205aa9dbf0b4987bf8e03b00 [INFO] sha for GitHub repo chr4/horsegen: 09eb799dc46a36f7205aa9dbf0b4987bf8e03b00 [INFO] validating manifest of chr4/horsegen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chr4/horsegen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chr4/horsegen [INFO] finished frobbing chr4/horsegen [INFO] frobbed toml for chr4/horsegen written to work/ex/clippy-test-run/sources/stable/gh/chr4/horsegen/Cargo.toml [INFO] started frobbing chr4/horsegen [INFO] finished frobbing chr4/horsegen [INFO] frobbed toml for chr4/horsegen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chr4/horsegen/Cargo.toml [INFO] crate chr4/horsegen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chr4/horsegen against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chr4/horsegen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9acb74188dc03152e0b14465583fe53078cc9293cdef56f548698755c6b5c9f4 [INFO] running `"docker" "start" "-a" "9acb74188dc03152e0b14465583fe53078cc9293cdef56f548698755c6b5c9f4"` [INFO] [stderr] Checking horsegen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/wordlist.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/wordlist.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / let mut wordlist_file: Vec = vec![]; [INFO] [stderr] 64 | | if args.is_present("wordlist") { [INFO] [stderr] 65 | | let wordlist_filename = args.value_of("wordlist").unwrap_or(""); [INFO] [stderr] 66 | | wordlist_file = match read_wordlist(wordlist_filename, max_word_length) { [INFO] [stderr] ... | [INFO] [stderr] 72 | | }; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 63 | let wordlist_file = if args.is_present("wordlist") { ..; match read_wordlist(wordlist_filename, max_word_length) { [INFO] [stderr] 64 | Ok(list) => list, [INFO] [stderr] 65 | Err(e) => { [INFO] [stderr] 66 | eprintln!("Error reading in wordlist: {}", e); [INFO] [stderr] 67 | process::exit(1); [INFO] [stderr] 68 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|l| !l.starts_with("#")) // Skip comments [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / let mut wordlist_file: Vec = vec![]; [INFO] [stderr] 64 | | if args.is_present("wordlist") { [INFO] [stderr] 65 | | let wordlist_filename = args.value_of("wordlist").unwrap_or(""); [INFO] [stderr] 66 | | wordlist_file = match read_wordlist(wordlist_filename, max_word_length) { [INFO] [stderr] ... | [INFO] [stderr] 72 | | }; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 63 | let wordlist_file = if args.is_present("wordlist") { ..; match read_wordlist(wordlist_filename, max_word_length) { [INFO] [stderr] 64 | Ok(list) => list, [INFO] [stderr] 65 | Err(e) => { [INFO] [stderr] 66 | eprintln!("Error reading in wordlist: {}", e); [INFO] [stderr] 67 | process::exit(1); [INFO] [stderr] 68 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|l| !l.starts_with("#")) // Skip comments [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.51s [INFO] running `"docker" "inspect" "9acb74188dc03152e0b14465583fe53078cc9293cdef56f548698755c6b5c9f4"` [INFO] running `"docker" "rm" "-f" "9acb74188dc03152e0b14465583fe53078cc9293cdef56f548698755c6b5c9f4"` [INFO] [stdout] 9acb74188dc03152e0b14465583fe53078cc9293cdef56f548698755c6b5c9f4