[INFO] updating cached repository cheezgi/stones [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cheezgi/stones [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cheezgi/stones" "work/ex/clippy-test-run/sources/stable/gh/cheezgi/stones"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cheezgi/stones'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cheezgi/stones" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/stones"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/stones'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c8376270ca400c786d708acbd0756341ab99b50e [INFO] sha for GitHub repo cheezgi/stones: c8376270ca400c786d708acbd0756341ab99b50e [INFO] validating manifest of cheezgi/stones on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cheezgi/stones on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cheezgi/stones [INFO] finished frobbing cheezgi/stones [INFO] frobbed toml for cheezgi/stones written to work/ex/clippy-test-run/sources/stable/gh/cheezgi/stones/Cargo.toml [INFO] started frobbing cheezgi/stones [INFO] finished frobbing cheezgi/stones [INFO] frobbed toml for cheezgi/stones written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/stones/Cargo.toml [INFO] crate cheezgi/stones has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cheezgi/stones against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/stones:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b89fd20f67508a9b20b784f39c84dc561588effa3d7bc9b3c61b97e60e8ee460 [INFO] running `"docker" "start" "-a" "b89fd20f67508a9b20b784f39c84dc561588effa3d7bc9b3c61b97e60e8ee460"` [INFO] [stderr] Checking stones v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | number: number [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | number: number [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 30 | | if self.is_num() { [INFO] [stderr] 31 | | self.get_num() == rhs.get_num() [INFO] [stderr] 32 | | } else if self.is_arr() { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | } else if self.is_num() { [INFO] [stderr] 30 | self.get_num() == rhs.get_num() [INFO] [stderr] 31 | } else if self.is_arr() { [INFO] [stderr] 32 | self.get_arr() == rhs.get_arr() [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | self.get_bool() == rhs.get_bool() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 46 | | if self.is_bool() { [INFO] [stderr] 47 | | None [INFO] [stderr] 48 | | } else if self.is_arr() { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | } else if self.is_bool() { [INFO] [stderr] 46 | None [INFO] [stderr] 47 | } else if self.is_arr() { [INFO] [stderr] 48 | self.get_arr().partial_cmp(&rhs.get_arr()) [INFO] [stderr] 49 | } else { [INFO] [stderr] 50 | Some(self.get_num().cmp(&rhs.get_num())) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 103 | | &Value::Num(n) => n, [INFO] [stderr] 104 | | _ => panic!("called get_num on non-num") [INFO] [stderr] 105 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 120 | | &Value::Bool(b) => b, [INFO] [stderr] 121 | | _ => panic!("called get_bool on non-bool") [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 30 | | if self.is_num() { [INFO] [stderr] 31 | | self.get_num() == rhs.get_num() [INFO] [stderr] 32 | | } else if self.is_arr() { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | } else if self.is_num() { [INFO] [stderr] 30 | self.get_num() == rhs.get_num() [INFO] [stderr] 31 | } else if self.is_arr() { [INFO] [stderr] 32 | self.get_arr() == rhs.get_arr() [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | self.get_bool() == rhs.get_bool() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 46 | | if self.is_bool() { [INFO] [stderr] 47 | | None [INFO] [stderr] 48 | | } else if self.is_arr() { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | } else if self.is_bool() { [INFO] [stderr] 46 | None [INFO] [stderr] 47 | } else if self.is_arr() { [INFO] [stderr] 48 | self.get_arr().partial_cmp(&rhs.get_arr()) [INFO] [stderr] 49 | } else { [INFO] [stderr] 50 | Some(self.get_num().cmp(&rhs.get_num())) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 103 | | &Value::Num(n) => n, [INFO] [stderr] 104 | | _ => panic!("called get_num on non-num") [INFO] [stderr] 105 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 120 | | &Value::Bool(b) => b, [INFO] [stderr] 121 | | _ => panic!("called get_bool on non-bool") [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/color.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn from_str(col: &str) -> Color { [INFO] [stderr] 16 | | match col { [INFO] [stderr] 17 | | "red" => Color::Red, [INFO] [stderr] 18 | | "orange" => Color::Orange, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/direction.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn from_str(dir: &str) -> Direction { [INFO] [stderr] 14 | | match dir { [INFO] [stderr] 15 | | "up" => Direction::Up, [INFO] [stderr] 16 | | "down" => Direction::Down, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/number.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn from_str(num: &str) -> Number { [INFO] [stderr] 12 | | match num { [INFO] [stderr] 13 | | "1" => Number::One, [INFO] [stderr] 14 | | "2" => Number::Two, [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/field.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Vec> { [INFO] [stderr] 7 | | vec![vec![Color::Blue, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Orange,Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis], [INFO] [stderr] 8 | | vec![Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis], [INFO] [stderr] 9 | | vec![Color::Invis, Color::Invis, Color::Red, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Green, Color::Invis, Color::Invis, Color::Invis], [INFO] [stderr] ... | [INFO] [stderr] 12 | | vec![Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis]] [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &Value::Num(_) => true, [INFO] [stderr] 83 | | _ => false [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | Value::Num(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self { [INFO] [stderr] 89 | | &Value::Arr(_) => true, [INFO] [stderr] 90 | | _ => false [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *self { [INFO] [stderr] 89 | Value::Arr(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match self { [INFO] [stderr] 96 | | &Value::Bool(_) => true, [INFO] [stderr] 97 | | _ => false [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | match *self { [INFO] [stderr] 96 | Value::Bool(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 103 | | &Value::Num(n) => n, [INFO] [stderr] 104 | | _ => panic!("called get_num on non-num") [INFO] [stderr] 105 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | let res = match *self { [INFO] [stderr] 103 | Value::Num(n) => n, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 112 | | &Value::Arr(ref a) => a, [INFO] [stderr] 113 | | _ => panic!("called get_arr on non-arr") [INFO] [stderr] 114 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | let res = match *self { [INFO] [stderr] 112 | Value::Arr(ref a) => a, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 120 | | &Value::Bool(b) => b, [INFO] [stderr] 121 | | _ => panic!("called get_bool on non-bool") [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | let res = match *self { [INFO] [stderr] 120 | Value::Bool(b) => b, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/color.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn from_str(col: &str) -> Color { [INFO] [stderr] 16 | | match col { [INFO] [stderr] 17 | | "red" => Color::Red, [INFO] [stderr] 18 | | "orange" => Color::Orange, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/direction.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn from_str(dir: &str) -> Direction { [INFO] [stderr] 14 | | match dir { [INFO] [stderr] 15 | | "up" => Direction::Up, [INFO] [stderr] 16 | | "down" => Direction::Down, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/number.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn from_str(num: &str) -> Number { [INFO] [stderr] 12 | | match num { [INFO] [stderr] 13 | | "1" => Number::One, [INFO] [stderr] 14 | | "2" => Number::Two, [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/field.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Vec> { [INFO] [stderr] 7 | | vec![vec![Color::Blue, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Orange,Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis], [INFO] [stderr] 8 | | vec![Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis], [INFO] [stderr] 9 | | vec![Color::Invis, Color::Invis, Color::Red, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Green, Color::Invis, Color::Invis, Color::Invis], [INFO] [stderr] ... | [INFO] [stderr] 12 | | vec![Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis, Color::Invis]] [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &Value::Num(_) => true, [INFO] [stderr] 83 | | _ => false [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | Value::Num(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self { [INFO] [stderr] 89 | | &Value::Arr(_) => true, [INFO] [stderr] 90 | | _ => false [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *self { [INFO] [stderr] 89 | Value::Arr(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match self { [INFO] [stderr] 96 | | &Value::Bool(_) => true, [INFO] [stderr] 97 | | _ => false [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | match *self { [INFO] [stderr] 96 | Value::Bool(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 103 | | &Value::Num(n) => n, [INFO] [stderr] 104 | | _ => panic!("called get_num on non-num") [INFO] [stderr] 105 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | let res = match *self { [INFO] [stderr] 103 | Value::Num(n) => n, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 112 | | &Value::Arr(ref a) => a, [INFO] [stderr] 113 | | _ => panic!("called get_arr on non-arr") [INFO] [stderr] 114 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | let res = match *self { [INFO] [stderr] 112 | Value::Arr(ref a) => a, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | let res = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 120 | | &Value::Bool(b) => b, [INFO] [stderr] 121 | | _ => panic!("called get_bool on non-bool") [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | let res = match *self { [INFO] [stderr] 120 | Value::Bool(b) => b, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:502:17 [INFO] [stderr] | [INFO] [stderr] 502 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:502:17 [INFO] [stderr] | [INFO] [stderr] 502 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | / if frames[current_frame] { [INFO] [stderr] 421 | | if move_field(stmt.color, stmt.direction, field, stack) { [INFO] [stderr] 422 | | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 423 | | frames.push(true); [INFO] [stderr] ... | [INFO] [stderr] 428 | | } [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 420 | if frames[current_frame] && move_field(stmt.color, stmt.direction, field, stack) { [INFO] [stderr] 421 | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 422 | frames.push(true); [INFO] [stderr] 423 | } else { [INFO] [stderr] 424 | frames.push(false); [INFO] [stderr] 425 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | / if move_field(stmt.color, stmt.direction, field, stack) { [INFO] [stderr] 436 | | if frames[current_frame] { [INFO] [stderr] 437 | | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 438 | | frames.push(true); [INFO] [stderr] ... | [INFO] [stderr] 446 | | } [INFO] [stderr] 447 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 435 | if move_field(stmt.color, stmt.direction, field, stack) && frames[current_frame] { [INFO] [stderr] 436 | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 437 | frames.push(true); [INFO] [stderr] 438 | whiles.push(k); [INFO] [stderr] 439 | } else { [INFO] [stderr] 440 | frames.push(false); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:562:28 [INFO] [stderr] | [INFO] [stderr] 562 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 563 | | if field[0][x] <= target { [INFO] [stderr] 564 | | if field[0][x] != Color::Invis { [INFO] [stderr] 565 | | let tm = field[0][x]; [INFO] [stderr] ... | [INFO] [stderr] 573 | | } [INFO] [stderr] 574 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 562 | } else if field[0][x] <= target { [INFO] [stderr] 563 | if field[0][x] != Color::Invis { [INFO] [stderr] 564 | let tm = field[0][x]; [INFO] [stderr] 565 | eval_prog(vec![Statement::new(tm, Direction::Down, Number::One)], field, stack); [INFO] [stderr] 566 | } [INFO] [stderr] 567 | field[y][x] = Color::Invis; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:588:28 [INFO] [stderr] | [INFO] [stderr] 588 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 589 | | if field[y][field_width] <= target { [INFO] [stderr] 590 | | if field[y][field_width] != Color::Invis { [INFO] [stderr] 591 | | let tm = field[y][field_width]; [INFO] [stderr] ... | [INFO] [stderr] 599 | | } [INFO] [stderr] 600 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 588 | } else if field[y][field_width] <= target { [INFO] [stderr] 589 | if field[y][field_width] != Color::Invis { [INFO] [stderr] 590 | let tm = field[y][field_width]; [INFO] [stderr] 591 | eval_prog(vec![Statement::new(tm, Direction::Left, Number::One)], field, stack); [INFO] [stderr] 592 | } [INFO] [stderr] 593 | field[y][x] = Color::Invis; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:614:28 [INFO] [stderr] | [INFO] [stderr] 614 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 615 | | if field[y][0] <= target { [INFO] [stderr] 616 | | if field[y][0] != Color::Invis { [INFO] [stderr] 617 | | let tm = field[y][0]; [INFO] [stderr] ... | [INFO] [stderr] 625 | | } [INFO] [stderr] 626 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 614 | } else if field[y][0] <= target { [INFO] [stderr] 615 | if field[y][0] != Color::Invis { [INFO] [stderr] 616 | let tm = field[y][0]; [INFO] [stderr] 617 | eval_prog(vec![Statement::new(tm, Direction::Left, Number::One)], field, stack); [INFO] [stderr] 618 | } [INFO] [stderr] 619 | field[y][x] = Color::Invis; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/stones.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | assert!(Color::Red == Color::Red); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | / if frames[current_frame] { [INFO] [stderr] 421 | | if move_field(stmt.color, stmt.direction, field, stack) { [INFO] [stderr] 422 | | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 423 | | frames.push(true); [INFO] [stderr] ... | [INFO] [stderr] 428 | | } [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 420 | if frames[current_frame] && move_field(stmt.color, stmt.direction, field, stack) { [INFO] [stderr] 421 | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 422 | frames.push(true); [INFO] [stderr] 423 | } else { [INFO] [stderr] 424 | frames.push(false); [INFO] [stderr] 425 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | / if move_field(stmt.color, stmt.direction, field, stack) { [INFO] [stderr] 436 | | if frames[current_frame] { [INFO] [stderr] 437 | | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 438 | | frames.push(true); [INFO] [stderr] ... | [INFO] [stderr] 446 | | } [INFO] [stderr] 447 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 435 | if move_field(stmt.color, stmt.direction, field, stack) && frames[current_frame] { [INFO] [stderr] 436 | if stack.pop().expect("Stack underflow").is_truthy() { [INFO] [stderr] 437 | frames.push(true); [INFO] [stderr] 438 | whiles.push(k); [INFO] [stderr] 439 | } else { [INFO] [stderr] 440 | frames.push(false); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:562:28 [INFO] [stderr] | [INFO] [stderr] 562 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 563 | | if field[0][x] <= target { [INFO] [stderr] 564 | | if field[0][x] != Color::Invis { [INFO] [stderr] 565 | | let tm = field[0][x]; [INFO] [stderr] ... | [INFO] [stderr] 573 | | } [INFO] [stderr] 574 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 562 | } else if field[0][x] <= target { [INFO] [stderr] 563 | if field[0][x] != Color::Invis { [INFO] [stderr] 564 | let tm = field[0][x]; [INFO] [stderr] 565 | eval_prog(vec![Statement::new(tm, Direction::Down, Number::One)], field, stack); [INFO] [stderr] 566 | } [INFO] [stderr] 567 | field[y][x] = Color::Invis; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:588:28 [INFO] [stderr] | [INFO] [stderr] 588 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 589 | | if field[y][field_width] <= target { [INFO] [stderr] 590 | | if field[y][field_width] != Color::Invis { [INFO] [stderr] 591 | | let tm = field[y][field_width]; [INFO] [stderr] ... | [INFO] [stderr] 599 | | } [INFO] [stderr] 600 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 588 | } else if field[y][field_width] <= target { [INFO] [stderr] 589 | if field[y][field_width] != Color::Invis { [INFO] [stderr] 590 | let tm = field[y][field_width]; [INFO] [stderr] 591 | eval_prog(vec![Statement::new(tm, Direction::Left, Number::One)], field, stack); [INFO] [stderr] 592 | } [INFO] [stderr] 593 | field[y][x] = Color::Invis; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:614:28 [INFO] [stderr] | [INFO] [stderr] 614 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 615 | | if field[y][0] <= target { [INFO] [stderr] 616 | | if field[y][0] != Color::Invis { [INFO] [stderr] 617 | | let tm = field[y][0]; [INFO] [stderr] ... | [INFO] [stderr] 625 | | } [INFO] [stderr] 626 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 614 | } else if field[y][0] <= target { [INFO] [stderr] 615 | if field[y][0] != Color::Invis { [INFO] [stderr] 616 | let tm = field[y][0]; [INFO] [stderr] 617 | eval_prog(vec![Statement::new(tm, Direction::Left, Number::One)], field, stack); [INFO] [stderr] 618 | } [INFO] [stderr] 619 | field[y][x] = Color::Invis; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `stones`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 134 [INFO] [stderr] --> src/main.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | / fn eval_prog(prog: Vec, field: &mut Vec>, stack: &mut Vec) { // {{{ [INFO] [stderr] 88 | | let mut rl = Editor::<()>::new(); [INFO] [stderr] 89 | | [INFO] [stderr] 90 | | let mut frames = vec![true]; [INFO] [stderr] ... | [INFO] [stderr] 506 | | } [INFO] [stderr] 507 | | } // }}} [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:249:32 [INFO] [stderr] | [INFO] [stderr] 249 | if !(lhs < rhs) { // hold up [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:270:32 [INFO] [stderr] | [INFO] [stderr] 270 | if !(lhs > rhs) { // what the hell? [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:348:38 [INFO] [stderr] | [INFO] [stderr] 348 | for _ in 0..d.get_num() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=d.get_num()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:398:49 [INFO] [stderr] | [INFO] [stderr] 398 | .map(|x| Value::Num(x as i64)) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 134 [INFO] [stderr] --> src/main.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | / fn eval_prog(prog: Vec, field: &mut Vec>, stack: &mut Vec) { // {{{ [INFO] [stderr] 88 | | let mut rl = Editor::<()>::new(); [INFO] [stderr] 89 | | [INFO] [stderr] 90 | | let mut frames = vec![true]; [INFO] [stderr] ... | [INFO] [stderr] 506 | | } [INFO] [stderr] 507 | | } // }}} [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:249:32 [INFO] [stderr] | [INFO] [stderr] 249 | if !(lhs < rhs) { // hold up [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:270:32 [INFO] [stderr] | [INFO] [stderr] 270 | if !(lhs > rhs) { // what the hell? [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:348:38 [INFO] [stderr] | [INFO] [stderr] 348 | for _ in 0..d.get_num() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=d.get_num()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:398:49 [INFO] [stderr] | [INFO] [stderr] 398 | .map(|x| Value::Num(x as i64)) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "b89fd20f67508a9b20b784f39c84dc561588effa3d7bc9b3c61b97e60e8ee460"` [INFO] running `"docker" "rm" "-f" "b89fd20f67508a9b20b784f39c84dc561588effa3d7bc9b3c61b97e60e8ee460"` [INFO] [stdout] b89fd20f67508a9b20b784f39c84dc561588effa3d7bc9b3c61b97e60e8ee460