[INFO] updating cached repository cheezgi/knipp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cheezgi/knipp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cheezgi/knipp" "work/ex/clippy-test-run/sources/stable/gh/cheezgi/knipp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cheezgi/knipp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cheezgi/knipp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/knipp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/knipp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8df6595bdbd86af6b1e011a42132af41a303c1e0 [INFO] sha for GitHub repo cheezgi/knipp: 8df6595bdbd86af6b1e011a42132af41a303c1e0 [INFO] validating manifest of cheezgi/knipp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cheezgi/knipp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cheezgi/knipp [INFO] finished frobbing cheezgi/knipp [INFO] frobbed toml for cheezgi/knipp written to work/ex/clippy-test-run/sources/stable/gh/cheezgi/knipp/Cargo.toml [INFO] started frobbing cheezgi/knipp [INFO] finished frobbing cheezgi/knipp [INFO] frobbed toml for cheezgi/knipp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/knipp/Cargo.toml [INFO] crate cheezgi/knipp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cheezgi/knipp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cheezgi/knipp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 549357fab01abeae2ed3adafa7e8d7883a1362a5342e7d5ba7e84bee9c1ca26e [INFO] running `"docker" "start" "-a" "549357fab01abeae2ed3adafa7e8d7883a1362a5342e7d5ba7e84bee9c1ca26e"` [INFO] [stderr] Checking knipp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 74 | | if let Some(len) = len { [INFO] [stderr] 75 | | vec![knipp::gen::sequence(len)] [INFO] [stderr] 76 | | } else { [INFO] [stderr] 77 | | knipp::default_formats() [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | } else if let Some(len) = len { [INFO] [stderr] 74 | vec![knipp::gen::sequence(len)] [INFO] [stderr] 75 | } else { [INFO] [stderr] 76 | knipp::default_formats() [INFO] [stderr] 77 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 74 | | if let Some(len) = len { [INFO] [stderr] 75 | | vec![knipp::gen::sequence(len)] [INFO] [stderr] 76 | | } else { [INFO] [stderr] 77 | | knipp::default_formats() [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | } else if let Some(len) = len { [INFO] [stderr] 74 | vec![knipp::gen::sequence(len)] [INFO] [stderr] 75 | } else { [INFO] [stderr] 76 | knipp::default_formats() [INFO] [stderr] 77 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | .split(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | .split(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.69s [INFO] running `"docker" "inspect" "549357fab01abeae2ed3adafa7e8d7883a1362a5342e7d5ba7e84bee9c1ca26e"` [INFO] running `"docker" "rm" "-f" "549357fab01abeae2ed3adafa7e8d7883a1362a5342e7d5ba7e84bee9c1ca26e"` [INFO] [stdout] 549357fab01abeae2ed3adafa7e8d7883a1362a5342e7d5ba7e84bee9c1ca26e