[INFO] updating cached repository charleskorn/adder-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/charleskorn/adder-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/charleskorn/adder-rust" "work/ex/clippy-test-run/sources/stable/gh/charleskorn/adder-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/charleskorn/adder-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/charleskorn/adder-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/charleskorn/adder-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/charleskorn/adder-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 550419d98fcf1126b7f31cd8f9887fccdc6eb8e5 [INFO] sha for GitHub repo charleskorn/adder-rust: 550419d98fcf1126b7f31cd8f9887fccdc6eb8e5 [INFO] validating manifest of charleskorn/adder-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of charleskorn/adder-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing charleskorn/adder-rust [INFO] finished frobbing charleskorn/adder-rust [INFO] frobbed toml for charleskorn/adder-rust written to work/ex/clippy-test-run/sources/stable/gh/charleskorn/adder-rust/Cargo.toml [INFO] started frobbing charleskorn/adder-rust [INFO] finished frobbing charleskorn/adder-rust [INFO] frobbed toml for charleskorn/adder-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/charleskorn/adder-rust/Cargo.toml [INFO] crate charleskorn/adder-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting charleskorn/adder-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/charleskorn/adder-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a19ed9d6044cea3da9e8fefa2ce71c3cb0ec4420eeec0278c9e60206839436fe [INFO] running `"docker" "start" "-a" "a19ed9d6044cea3da9e8fefa2ce71c3cb0ec4420eeec0278c9e60206839436fe"` [INFO] [stderr] Checking adder-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/adder.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return add(a ^ b, (a & b) << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `add(a ^ b, (a & b) << 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ui.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return adder::add(first, second).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `adder::add(first, second).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/adder.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return add(a ^ b, (a & b) << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `add(a ^ b, (a & b) << 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ui.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return adder::add(first, second).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `adder::add(first, second).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/ui.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | run(args.into_iter().map(|s| s.to_string()).collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "a19ed9d6044cea3da9e8fefa2ce71c3cb0ec4420eeec0278c9e60206839436fe"` [INFO] running `"docker" "rm" "-f" "a19ed9d6044cea3da9e8fefa2ce71c3cb0ec4420eeec0278c9e60206839436fe"` [INFO] [stdout] a19ed9d6044cea3da9e8fefa2ce71c3cb0ec4420eeec0278c9e60206839436fe