[INFO] updating cached repository cetra3/mdcollate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cetra3/mdcollate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/mdcollate" "work/ex/clippy-test-run/sources/stable/gh/cetra3/mdcollate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cetra3/mdcollate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/mdcollate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/mdcollate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/mdcollate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61cbec6c787aca0bff3ad6ac08e6e33b5858d19f [INFO] sha for GitHub repo cetra3/mdcollate: 61cbec6c787aca0bff3ad6ac08e6e33b5858d19f [INFO] validating manifest of cetra3/mdcollate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cetra3/mdcollate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cetra3/mdcollate [INFO] finished frobbing cetra3/mdcollate [INFO] frobbed toml for cetra3/mdcollate written to work/ex/clippy-test-run/sources/stable/gh/cetra3/mdcollate/Cargo.toml [INFO] started frobbing cetra3/mdcollate [INFO] finished frobbing cetra3/mdcollate [INFO] frobbed toml for cetra3/mdcollate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/mdcollate/Cargo.toml [INFO] crate cetra3/mdcollate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cetra3/mdcollate against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/mdcollate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec108050f1882fb2f91126303059244c8a35c8f45879b025ea42176fbe10f9ad [INFO] running `"docker" "start" "-a" "ec108050f1882fb2f91126303059244c8a35c8f45879b025ea42176fbe10f9ad"` [INFO] [stderr] Checking libc v0.2.4 [INFO] [stderr] Checking regex-syntax v0.2.2 [INFO] [stderr] Checking memchr v0.1.7 [INFO] [stderr] Checking aho-corasick v0.4.0 [INFO] [stderr] Checking regex v0.1.46 [INFO] [stderr] Checking mdcollate v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return File::open(resolve_path(search_path)?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `File::open(resolve_path(search_path)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | return Ok(trimmed_path.to_path_buf()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(trimmed_path.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | return resolve_path(&(format!("{}.md", search_path))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resolve_path(&(format!("{}.md", search_path)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return File::open(resolve_path(search_path)?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `File::open(resolve_path(search_path)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | return Ok(trimmed_path.to_path_buf()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(trimmed_path.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | return resolve_path(&(format!("{}.md", search_path))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resolve_path(&(format!("{}.md", search_path)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | fn print_col(seed_file: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | while files.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match resolve_file(file_name.as_ref()) { [INFO] [stderr] 36 | | Ok(file) => { [INFO] [stderr] 37 | | match read_file(file) { [INFO] [stderr] 38 | | Ok(mut file_contents) => { [INFO] [stderr] ... | [INFO] [stderr] 86 | | Err(_) => () [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Ok(file) = resolve_file(file_name.as_ref()) { [INFO] [stderr] 36 | match read_file(file) { [INFO] [stderr] 37 | Ok(mut file_contents) => { [INFO] [stderr] 38 | //We have to clone the file contents as we mutate it later [INFO] [stderr] 39 | for cap in re.captures_iter(&file_contents.clone()) { [INFO] [stderr] 40 | let href = cap.name("href").unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / match read_file(file) { [INFO] [stderr] 38 | | Ok(mut file_contents) => { [INFO] [stderr] 39 | | //We have to clone the file contents as we mutate it later [INFO] [stderr] 40 | | for cap in re.captures_iter(&file_contents.clone()) { [INFO] [stderr] ... | [INFO] [stderr] 82 | | Err(_) => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Ok(mut file_contents) = read_file(file) { [INFO] [stderr] 38 | //We have to clone the file contents as we mutate it later [INFO] [stderr] 39 | for cap in re.captures_iter(&file_contents.clone()) { [INFO] [stderr] 40 | let href = cap.name("href").unwrap(); [INFO] [stderr] 41 | let name = cap.name("name").unwrap(); [INFO] [stderr] 42 | let total_match = cap.at(0).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:52:29 [INFO] [stderr] | [INFO] [stderr] 52 | / match image { [INFO] [stderr] 53 | | true => { [INFO] [stderr] 54 | | if let Ok(image_file) = resolve_path(&new_link) { [INFO] [stderr] 55 | | file_contents = file_contents.replace(total_match, &(format!("![{}]({})", name, image_file.display()))); [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 52 | if image { [INFO] [stderr] 53 | if let Ok(image_file) = resolve_path(&new_link) { [INFO] [stderr] 54 | file_contents = file_contents.replace(total_match, &(format!("![{}]({})", name, image_file.display()))); [INFO] [stderr] 55 | } [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | / match resolve_path(&new_link) { [INFO] [stderr] 62 | | Ok(file) => { [INFO] [stderr] 63 | | new_link = String::from(file.to_string_lossy()); [INFO] [stderr] 64 | | file_contents = file_contents.replace(total_match, &(format!("[{}](#{})", name, new_link.replace("/","_")))) [INFO] [stderr] 65 | | }, [INFO] [stderr] 66 | | Err(_) => () [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Ok(file) = resolve_path(&new_link) { [INFO] [stderr] 62 | new_link = String::from(file.to_string_lossy()); [INFO] [stderr] 63 | file_contents = file_contents.replace(total_match, &(format!("[{}](#{})", name, new_link.replace("/","_")))) [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match link.starts_with("./") { [INFO] [stderr] 116 | | true => filtered_link.push_str(&link[2..]), [INFO] [stderr] 117 | | false => filtered_link.push_str(&link) [INFO] [stderr] 118 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if link.starts_with("./") { filtered_link.push_str(&link[2..]) } else { filtered_link.push_str(&link) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / match path.exists(){ [INFO] [stderr] 132 | | true => { [INFO] [stderr] 133 | | let cur_dir = env::current_dir()?; [INFO] [stderr] 134 | | let canon_path = path.canonicalize()?; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 131 | if path.exists() { [INFO] [stderr] 132 | let cur_dir = env::current_dir()?; [INFO] [stderr] 133 | let canon_path = path.canonicalize()?; [INFO] [stderr] 134 | let trimmed_path = canon_path.strip_prefix(&cur_dir).unwrap(); [INFO] [stderr] 135 | return Ok(trimmed_path.to_path_buf()); [INFO] [stderr] 136 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | / match search_path.ends_with(".md") { [INFO] [stderr] 145 | | true => Err(Error::new(ErrorKind::NotFound, [INFO] [stderr] 146 | | "the file cannot be found")), [INFO] [stderr] 147 | | false => { [INFO] [stderr] 148 | | return resolve_path(&(format!("{}.md", search_path))); [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 144 | if search_path.ends_with(".md") { Err(Error::new(ErrorKind::NotFound, [INFO] [stderr] 145 | "the file cannot be found")) } else { [INFO] [stderr] 146 | return resolve_path(&(format!("{}.md", search_path))); [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | fn print_col(seed_file: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | while files.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match resolve_file(file_name.as_ref()) { [INFO] [stderr] 36 | | Ok(file) => { [INFO] [stderr] 37 | | match read_file(file) { [INFO] [stderr] 38 | | Ok(mut file_contents) => { [INFO] [stderr] ... | [INFO] [stderr] 86 | | Err(_) => () [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Ok(file) = resolve_file(file_name.as_ref()) { [INFO] [stderr] 36 | match read_file(file) { [INFO] [stderr] 37 | Ok(mut file_contents) => { [INFO] [stderr] 38 | //We have to clone the file contents as we mutate it later [INFO] [stderr] 39 | for cap in re.captures_iter(&file_contents.clone()) { [INFO] [stderr] 40 | let href = cap.name("href").unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / match read_file(file) { [INFO] [stderr] 38 | | Ok(mut file_contents) => { [INFO] [stderr] 39 | | //We have to clone the file contents as we mutate it later [INFO] [stderr] 40 | | for cap in re.captures_iter(&file_contents.clone()) { [INFO] [stderr] ... | [INFO] [stderr] 82 | | Err(_) => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Ok(mut file_contents) = read_file(file) { [INFO] [stderr] 38 | //We have to clone the file contents as we mutate it later [INFO] [stderr] 39 | for cap in re.captures_iter(&file_contents.clone()) { [INFO] [stderr] 40 | let href = cap.name("href").unwrap(); [INFO] [stderr] 41 | let name = cap.name("name").unwrap(); [INFO] [stderr] 42 | let total_match = cap.at(0).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:52:29 [INFO] [stderr] | [INFO] [stderr] 52 | / match image { [INFO] [stderr] 53 | | true => { [INFO] [stderr] 54 | | if let Ok(image_file) = resolve_path(&new_link) { [INFO] [stderr] 55 | | file_contents = file_contents.replace(total_match, &(format!("![{}]({})", name, image_file.display()))); [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 52 | if image { [INFO] [stderr] 53 | if let Ok(image_file) = resolve_path(&new_link) { [INFO] [stderr] 54 | file_contents = file_contents.replace(total_match, &(format!("![{}]({})", name, image_file.display()))); [INFO] [stderr] 55 | } [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | / match resolve_path(&new_link) { [INFO] [stderr] 62 | | Ok(file) => { [INFO] [stderr] 63 | | new_link = String::from(file.to_string_lossy()); [INFO] [stderr] 64 | | file_contents = file_contents.replace(total_match, &(format!("[{}](#{})", name, new_link.replace("/","_")))) [INFO] [stderr] 65 | | }, [INFO] [stderr] 66 | | Err(_) => () [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Ok(file) = resolve_path(&new_link) { [INFO] [stderr] 62 | new_link = String::from(file.to_string_lossy()); [INFO] [stderr] 63 | file_contents = file_contents.replace(total_match, &(format!("[{}](#{})", name, new_link.replace("/","_")))) [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match link.starts_with("./") { [INFO] [stderr] 116 | | true => filtered_link.push_str(&link[2..]), [INFO] [stderr] 117 | | false => filtered_link.push_str(&link) [INFO] [stderr] 118 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if link.starts_with("./") { filtered_link.push_str(&link[2..]) } else { filtered_link.push_str(&link) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / match path.exists(){ [INFO] [stderr] 132 | | true => { [INFO] [stderr] 133 | | let cur_dir = env::current_dir()?; [INFO] [stderr] 134 | | let canon_path = path.canonicalize()?; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 131 | if path.exists() { [INFO] [stderr] 132 | let cur_dir = env::current_dir()?; [INFO] [stderr] 133 | let canon_path = path.canonicalize()?; [INFO] [stderr] 134 | let trimmed_path = canon_path.strip_prefix(&cur_dir).unwrap(); [INFO] [stderr] 135 | return Ok(trimmed_path.to_path_buf()); [INFO] [stderr] 136 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | / match search_path.ends_with(".md") { [INFO] [stderr] 145 | | true => Err(Error::new(ErrorKind::NotFound, [INFO] [stderr] 146 | | "the file cannot be found")), [INFO] [stderr] 147 | | false => { [INFO] [stderr] 148 | | return resolve_path(&(format!("{}.md", search_path))); [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 144 | if search_path.ends_with(".md") { Err(Error::new(ErrorKind::NotFound, [INFO] [stderr] 145 | "the file cannot be found")) } else { [INFO] [stderr] 146 | return resolve_path(&(format!("{}.md", search_path))); [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.31s [INFO] running `"docker" "inspect" "ec108050f1882fb2f91126303059244c8a35c8f45879b025ea42176fbe10f9ad"` [INFO] running `"docker" "rm" "-f" "ec108050f1882fb2f91126303059244c8a35c8f45879b025ea42176fbe10f9ad"` [INFO] [stdout] ec108050f1882fb2f91126303059244c8a35c8f45879b025ea42176fbe10f9ad