[INFO] updating cached repository cetra3/apache_log [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cetra3/apache_log [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/apache_log" "work/ex/clippy-test-run/sources/stable/gh/cetra3/apache_log"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cetra3/apache_log'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/apache_log" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/apache_log"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/apache_log'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 75495658e4797afc4e2ae42192d5f587b0ced6e5 [INFO] sha for GitHub repo cetra3/apache_log: 75495658e4797afc4e2ae42192d5f587b0ced6e5 [INFO] validating manifest of cetra3/apache_log on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cetra3/apache_log on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cetra3/apache_log [INFO] finished frobbing cetra3/apache_log [INFO] frobbed toml for cetra3/apache_log written to work/ex/clippy-test-run/sources/stable/gh/cetra3/apache_log/Cargo.toml [INFO] started frobbing cetra3/apache_log [INFO] finished frobbing cetra3/apache_log [INFO] frobbed toml for cetra3/apache_log written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/apache_log/Cargo.toml [INFO] crate cetra3/apache_log has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cetra3/apache_log against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/apache_log:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ca2e41a5e43e4cf5cd48dcc6d5a894321e12a6c3d8a5c3e144f2225128ed771 [INFO] running `"docker" "start" "-a" "0ca2e41a5e43e4cf5cd48dcc6d5a894321e12a6c3d8a5c3e144f2225128ed771"` [INFO] [stderr] Checking siphasher v0.2.1 [INFO] [stderr] Checking md5 v0.3.3 [INFO] [stderr] Checking bufstream v0.1.2 [INFO] [stderr] Checking pom v1.0.1 [INFO] [stderr] Checking r2d2 v0.7.1 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking futures-cpupool v0.1.3 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking phf_shared v0.7.21 [INFO] [stderr] Checking postgres-protocol v0.2.1 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking phf v0.7.21 [INFO] [stderr] Checking postgres-shared v0.2.0 [INFO] [stderr] Checking postgres v0.14.0 [INFO] [stderr] Checking r2d2_postgres v0.12.0 [INFO] [stderr] Checking apache_log v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | data_type: data_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | ip_address: ip_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | identd: identd, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `identd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | referrer: referrer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `referrer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | data_type: data_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | ip_address: ip_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | identd: identd, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `identd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | referrer: referrer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `referrer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | if logs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!logs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | query.push_str(&(1..columns.len() + 1).map(|num| format!("${}", num)).collect::>().join(",")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=columns.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | if logs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!logs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | query.push_str(&(1..columns.len() + 1).map(|num| format!("${}", num)).collect::>().join(",")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=columns.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.13s [INFO] running `"docker" "inspect" "0ca2e41a5e43e4cf5cd48dcc6d5a894321e12a6c3d8a5c3e144f2225128ed771"` [INFO] running `"docker" "rm" "-f" "0ca2e41a5e43e4cf5cd48dcc6d5a894321e12a6c3d8a5c3e144f2225128ed771"` [INFO] [stdout] 0ca2e41a5e43e4cf5cd48dcc6d5a894321e12a6c3d8a5c3e144f2225128ed771