[INFO] updating cached repository cessen/anki_sim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cessen/anki_sim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cessen/anki_sim" "work/ex/clippy-test-run/sources/stable/gh/cessen/anki_sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cessen/anki_sim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cessen/anki_sim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cessen/anki_sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cessen/anki_sim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 002499dfad0115a2930ac789341187651e4a30f4 [INFO] sha for GitHub repo cessen/anki_sim: 002499dfad0115a2930ac789341187651e4a30f4 [INFO] validating manifest of cessen/anki_sim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cessen/anki_sim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cessen/anki_sim [INFO] finished frobbing cessen/anki_sim [INFO] frobbed toml for cessen/anki_sim written to work/ex/clippy-test-run/sources/stable/gh/cessen/anki_sim/Cargo.toml [INFO] started frobbing cessen/anki_sim [INFO] finished frobbing cessen/anki_sim [INFO] frobbed toml for cessen/anki_sim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cessen/anki_sim/Cargo.toml [INFO] crate cessen/anki_sim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cessen/anki_sim against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cessen/anki_sim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 906860392ab12837d8035a4faaead443b7e5c92d3fef29a3756a14dcab8f1fef [INFO] running `"docker" "start" "-a" "906860392ab12837d8035a4faaead443b7e5c92d3fef29a3756a14dcab8f1fef"` [INFO] [stderr] Checking png_encode_mini v0.1.2 [INFO] [stderr] Checking anki_sim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | (0.000001, 1.0), [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | (0.000001, 1.0), [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim.rs:125:39 [INFO] [stderr] | [INFO] [stderr] 125 | let sampler = Normal::new(self.retention_ratio as f64, self.difficulty_variance as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.retention_ratio)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim.rs:125:68 [INFO] [stderr] | [INFO] [stderr] 125 | let sampler = Normal::new(self.retention_ratio as f64, self.difficulty_variance as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.difficulty_variance)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | (self.deck.len() as f64 * retained as f64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(retained)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | self.time_per_review_card as f64 * self.deck[i].card_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_per_review_card)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:131:65 [INFO] [stderr] | [INFO] [stderr] 131 | let good_card_count = self.deck[i].card_count * self.retention_ratio as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.retention_ratio)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | self.time_per_lapsed_card as f64 * lapse_card_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_per_lapsed_card)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:183:39 [INFO] [stderr] | [INFO] [stderr] 183 | self.time_spent_on_new += self.time_per_new_card as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_per_new_card)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:199:56 [INFO] [stderr] | [INFO] [stderr] 199 | (self.cards_added - self.remove_lapse_count) * retained as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(retained)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / fn generate_chart( [INFO] [stderr] 27 | | path: &str, [INFO] [stderr] 28 | | samples: u32, [INFO] [stderr] 29 | | normalize_slices: bool, [INFO] [stderr] ... | [INFO] [stderr] 186 | | ).unwrap(); [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:101:30 [INFO] [stderr] | [INFO] [stderr] 101 | for i in start..(end + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim.rs:125:39 [INFO] [stderr] | [INFO] [stderr] 125 | let sampler = Normal::new(self.retention_ratio as f64, self.difficulty_variance as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.retention_ratio)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim.rs:125:68 [INFO] [stderr] | [INFO] [stderr] 125 | let sampler = Normal::new(self.retention_ratio as f64, self.difficulty_variance as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.difficulty_variance)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | (self.deck.len() as f64 * retained as f64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(retained)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | self.time_per_review_card as f64 * self.deck[i].card_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_per_review_card)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:131:65 [INFO] [stderr] | [INFO] [stderr] 131 | let good_card_count = self.deck[i].card_count * self.retention_ratio as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.retention_ratio)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | self.time_per_lapsed_card as f64 * lapse_card_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_per_lapsed_card)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:183:39 [INFO] [stderr] | [INFO] [stderr] 183 | self.time_spent_on_new += self.time_per_new_card as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_per_new_card)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/anki_sim_ana.rs:199:56 [INFO] [stderr] | [INFO] [stderr] 199 | (self.cards_added - self.remove_lapse_count) * retained as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(retained)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / fn generate_chart( [INFO] [stderr] 27 | | path: &str, [INFO] [stderr] 28 | | samples: u32, [INFO] [stderr] 29 | | normalize_slices: bool, [INFO] [stderr] ... | [INFO] [stderr] 186 | | ).unwrap(); [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:101:30 [INFO] [stderr] | [INFO] [stderr] 101 | for i in start..(end + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.62s [INFO] running `"docker" "inspect" "906860392ab12837d8035a4faaead443b7e5c92d3fef29a3756a14dcab8f1fef"` [INFO] running `"docker" "rm" "-f" "906860392ab12837d8035a4faaead443b7e5c92d3fef29a3756a14dcab8f1fef"` [INFO] [stdout] 906860392ab12837d8035a4faaead443b7e5c92d3fef29a3756a14dcab8f1fef