[INFO] updating cached repository cesare/rust-euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cesare/rust-euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust-euler" "work/ex/clippy-test-run/sources/stable/gh/cesare/rust-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cesare/rust-euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust-euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d02961d4e944a54351220a3452b9fa6291dfb43 [INFO] sha for GitHub repo cesare/rust-euler: 0d02961d4e944a54351220a3452b9fa6291dfb43 [INFO] validating manifest of cesare/rust-euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cesare/rust-euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cesare/rust-euler [INFO] finished frobbing cesare/rust-euler [INFO] frobbed toml for cesare/rust-euler written to work/ex/clippy-test-run/sources/stable/gh/cesare/rust-euler/Cargo.toml [INFO] started frobbing cesare/rust-euler [INFO] finished frobbing cesare/rust-euler [INFO] frobbed toml for cesare/rust-euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-euler/Cargo.toml [INFO] crate cesare/rust-euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cesare/rust-euler against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08da51523bf19408fc8839727e23c84797c6ec6bfc8b48904c774b155a3982d7 [INFO] running `"docker" "start" "-a" "08da51523bf19408fc8839727e23c84797c6ec6bfc8b48904c774b155a3982d7"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | diff: diff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | diff: diff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | diff: diff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | diff: diff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem_003_largest_prime_factor.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | let mut the_number = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_008_largest_product.rs:27:54 [INFO] [stderr] | [INFO] [stderr] 27 | s.chars().map(|c| c.to_digit(10).unwrap() as u64).fold(1, |a, n| a * n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/problem_008_largest_product.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | s.chars().map(|c| c.to_digit(10).unwrap() as u64).fold(1, |a, n| a * n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_008_largest_product.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | for i in 0..s.len() - len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=s.len() - len` [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem_003_largest_prime_factor.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | let mut the_number = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Fib` [INFO] [stderr] --> src/problem_002.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Fib { [INFO] [stderr] 9 | | Fib { [INFO] [stderr] 10 | | i: 0, [INFO] [stderr] 11 | | previous: 0, [INFO] [stderr] 12 | | current: 1, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EvenFib` [INFO] [stderr] --> src/problem_002.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> EvenFib { [INFO] [stderr] 38 | | EvenFib { [INFO] [stderr] 39 | | i: 0, [INFO] [stderr] 40 | | previous: 2, [INFO] [stderr] 41 | | current: 0, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/prime.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/prime.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/prime.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | (from..to).map(|n| Candidate::new(n)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Candidate::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | let &p = self.prime.known_primes.get(self.current_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.prime.known_primes[self.current_idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_010_summation_of_primes.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | let result = ps.take_while(|&p| p < 2_000_000u64).fold(0, |a, n| a + n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/prime.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | (from..to).map(|n| Candidate::new(n)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Candidate::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | let &p = self.prime.known_primes.get(self.current_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.prime.known_primes[self.current_idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_010_summation_of_primes.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | let result = ps.take_while(|&p| p < 2_000_000u64).fold(0, |a, n| a + n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/prime.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | (from..to).map(|n| Candidate::new(n)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Candidate::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | let &p = self.prime.known_primes.get(self.current_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.prime.known_primes[self.current_idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_004_largest_palindrome_product.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | let bs = (100..a + 1).rev(); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(100..=a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/problem_003_largest_prime_factor.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | the_number = the_number / f; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `the_number /= f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/prime.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | (from..to).map(|n| Candidate::new(n)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Candidate::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | let &p = self.prime.known_primes.get(self.current_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.prime.known_primes[self.current_idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/problem_003_largest_prime_factor.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | the_number = the_number / f; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `the_number /= f` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | diff: diff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | diff: diff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prime.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/problem_005_smallest_multiple.rs:42:42 [INFO] [stderr] | [INFO] [stderr] 42 | let product = results.iter().fold(1, (|a, b| a * b)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/problem_005_smallest_multiple.rs:42:42 [INFO] [stderr] | [INFO] [stderr] 42 | let product = results.iter().fold(1, (|a, b| a * b)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_006_sum_square_difference.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | 1u32..max + 1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1u32..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_006_sum_square_difference.rs:10:58 [INFO] [stderr] | [INFO] [stderr] 10 | let sum_of_square = sequence_upto(max).map(|n| n * n).fold(0, |a, n| a + n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_006_sum_square_difference.rs:11:43 [INFO] [stderr] | [INFO] [stderr] 11 | let square_of_sum = sequence_upto(max).fold(0, |a, n| a + n).pow(2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_005_smallest_multiple.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let range = 2..to + 1; [INFO] [stderr] | ^^^^^^^^^ help: use: `2..=to` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_005_smallest_multiple.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | let product = results.iter().fold(1, (|a, b| a * b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/prime.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_005_smallest_multiple.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let range = 2..to + 1; [INFO] [stderr] | ^^^^^^^^^ help: use: `2..=to` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/prime.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | (from..to).map(|n| Candidate::new(n)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Candidate::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_005_smallest_multiple.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | let product = results.iter().fold(1, (|a, b| a * b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_006_sum_square_difference.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | 1u32..max + 1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1u32..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | let &p = self.prime.known_primes.get(self.current_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.prime.known_primes[self.current_idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_006_sum_square_difference.rs:10:58 [INFO] [stderr] | [INFO] [stderr] 10 | let sum_of_square = sequence_upto(max).map(|n| n * n).fold(0, |a, n| a + n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_006_sum_square_difference.rs:11:43 [INFO] [stderr] | [INFO] [stderr] 11 | let square_of_sum = sequence_upto(max).fold(0, |a, n| a + n).pow(2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Fib` [INFO] [stderr] --> src/problem_002.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Fib { [INFO] [stderr] 9 | | Fib { [INFO] [stderr] 10 | | i: 0, [INFO] [stderr] 11 | | previous: 0, [INFO] [stderr] 12 | | current: 1, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EvenFib` [INFO] [stderr] --> src/problem_002.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> EvenFib { [INFO] [stderr] 38 | | EvenFib { [INFO] [stderr] 39 | | i: 0, [INFO] [stderr] 40 | | previous: 2, [INFO] [stderr] 41 | | current: 0, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/prime.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/prime.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | (from..to).map(|n| Candidate::new(n)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Candidate::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | let &p = self.prime.known_primes.get(self.current_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.prime.known_primes[self.current_idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problem_008_largest_product.rs:27:54 [INFO] [stderr] | [INFO] [stderr] 27 | s.chars().map(|c| c.to_digit(10).unwrap() as u64).fold(1, |a, n| a * n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/problem_008_largest_product.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | s.chars().map(|c| c.to_digit(10).unwrap() as u64).fold(1, |a, n| a * n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_008_largest_product.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | for i in 0..s.len() - len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=s.len() - len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem_004_largest_palindrome_product.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | let bs = (100..a + 1).rev(); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(100..=a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.38s [INFO] running `"docker" "inspect" "08da51523bf19408fc8839727e23c84797c6ec6bfc8b48904c774b155a3982d7"` [INFO] running `"docker" "rm" "-f" "08da51523bf19408fc8839727e23c84797c6ec6bfc8b48904c774b155a3982d7"` [INFO] [stdout] 08da51523bf19408fc8839727e23c84797c6ec6bfc8b48904c774b155a3982d7