[INFO] updating cached repository centip3de/MP3-Parser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/centip3de/MP3-Parser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/centip3de/MP3-Parser" "work/ex/clippy-test-run/sources/stable/gh/centip3de/MP3-Parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/centip3de/MP3-Parser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/centip3de/MP3-Parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/centip3de/MP3-Parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/centip3de/MP3-Parser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 71d8017fa595aee44448d1d1c8cf38761f809ea4
[INFO] sha for GitHub repo centip3de/MP3-Parser: 71d8017fa595aee44448d1d1c8cf38761f809ea4
[INFO] validating manifest of centip3de/MP3-Parser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of centip3de/MP3-Parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing centip3de/MP3-Parser
[INFO] finished frobbing centip3de/MP3-Parser
[INFO] frobbed toml for centip3de/MP3-Parser written to work/ex/clippy-test-run/sources/stable/gh/centip3de/MP3-Parser/Cargo.toml
[INFO] started frobbing centip3de/MP3-Parser
[INFO] finished frobbing centip3de/MP3-Parser
[INFO] frobbed toml for centip3de/MP3-Parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/centip3de/MP3-Parser/Cargo.toml
[INFO] crate centip3de/MP3-Parser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting centip3de/MP3-Parser against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/centip3de/MP3-Parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 63dd317c5c0dee5a597a078368c89795675b060bd2e1ddfbb12e92dd3c456b28
[INFO] running `"docker" "start" "-a" "63dd317c5c0dee5a597a078368c89795675b060bd2e1ddfbb12e92dd3c456b28"`
[INFO] [stderr]     Checking mp3_parser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:47:37
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn output_header(header: MP3Header) -> ()
[INFO] [stderr]    |                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 |         if byte == 0b11111111 {
[INFO] [stderr]    |                    ^^^^^^^^^^ help: consider: `0b1111_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:47:37
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn output_header(header: MP3Header) -> ()
[INFO] [stderr]    |                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 |         if byte == 0b11111111 {
[INFO] [stderr]    |                    ^^^^^^^^^^ help: consider: `0b1111_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:93:31
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 frame_sync |= byte as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^ help: try: `u32::from(byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:94:17
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 frame_sync = frame_sync << 3;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_sync <<= 3`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:99:31
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 frame_sync |= byte as u32 >> 5;
[INFO] [stderr]    |                               ^^^^^^^^^^^ help: try: `u32::from(byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:104:41
[INFO] [stderr]     |
[INFO] [stderr] 104 |                 header.protection_bit = if byte & 0b1 == 0b1 { false } else { true };
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(byte & 0b1 == 0b1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:108:38
[INFO] [stderr]     |
[INFO] [stderr] 108 |                 header.private_bit = if byte & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `byte & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:109:38
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 header.padding_bit = if (byte >> 1) & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(byte >> 1) & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:116:35
[INFO] [stderr]     |
[INFO] [stderr] 116 |                 header.original = if (byte >> 2) & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(byte >> 2) & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:117:36
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 header.copyright = if (byte >> 3) & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(byte >> 3) & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:93:31
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 frame_sync |= byte as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^ help: try: `u32::from(byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:94:17
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 frame_sync = frame_sync << 3;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_sync <<= 3`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:99:31
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 frame_sync |= byte as u32 >> 5;
[INFO] [stderr]    |                               ^^^^^^^^^^^ help: try: `u32::from(byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:104:41
[INFO] [stderr]     |
[INFO] [stderr] 104 |                 header.protection_bit = if byte & 0b1 == 0b1 { false } else { true };
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(byte & 0b1 == 0b1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:108:38
[INFO] [stderr]     |
[INFO] [stderr] 108 |                 header.private_bit = if byte & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `byte & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:109:38
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 header.padding_bit = if (byte >> 1) & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(byte >> 1) & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:116:35
[INFO] [stderr]     |
[INFO] [stderr] 116 |                 header.original = if (byte >> 2) & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(byte >> 2) & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:117:36
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 header.copyright = if (byte >> 3) & 0b1 == 0b1 { true } else { false };
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(byte >> 3) & 0b1 == 0b1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.73s
[INFO] running `"docker" "inspect" "63dd317c5c0dee5a597a078368c89795675b060bd2e1ddfbb12e92dd3c456b28"`
[INFO] running `"docker" "rm" "-f" "63dd317c5c0dee5a597a078368c89795675b060bd2e1ddfbb12e92dd3c456b28"`
[INFO] [stdout] 63dd317c5c0dee5a597a078368c89795675b060bd2e1ddfbb12e92dd3c456b28