[INFO] updating cached repository cbywater/rust-directory-exercise [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cbywater/rust-directory-exercise [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cbywater/rust-directory-exercise" "work/ex/clippy-test-run/sources/stable/gh/cbywater/rust-directory-exercise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cbywater/rust-directory-exercise'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cbywater/rust-directory-exercise" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cbywater/rust-directory-exercise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cbywater/rust-directory-exercise'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a7fc551128c6b3d7d3dfe6643fa97f7db0b9e9e [INFO] sha for GitHub repo cbywater/rust-directory-exercise: 7a7fc551128c6b3d7d3dfe6643fa97f7db0b9e9e [INFO] validating manifest of cbywater/rust-directory-exercise on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cbywater/rust-directory-exercise on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cbywater/rust-directory-exercise [INFO] finished frobbing cbywater/rust-directory-exercise [INFO] frobbed toml for cbywater/rust-directory-exercise written to work/ex/clippy-test-run/sources/stable/gh/cbywater/rust-directory-exercise/Cargo.toml [INFO] started frobbing cbywater/rust-directory-exercise [INFO] finished frobbing cbywater/rust-directory-exercise [INFO] frobbed toml for cbywater/rust-directory-exercise written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cbywater/rust-directory-exercise/Cargo.toml [INFO] crate cbywater/rust-directory-exercise has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cbywater/rust-directory-exercise against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cbywater/rust-directory-exercise:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 81168955b0febdd99c841754d8320bc56c290664728e1905d1165cec6135bdbf [INFO] running `"docker" "start" "-a" "81168955b0febdd99c841754d8320bc56c290664728e1905d1165cec6135bdbf"` [INFO] [stderr] Checking company_directory v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/commands/add_user.rs:5:63 [INFO] [stderr] | [INFO] [stderr] 5 | let dept_record = directory.departments.entry(department).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/mod.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Command::AddUser(ref user, ref dept) => add_user(user.clone(), dept.clone(), &mut directory), [INFO] [stderr] 27 | | &Command::ListDepartment(ref dept) => list_department(dept.clone(), &mut directory), [INFO] [stderr] 28 | | &Command::Exit => exit(), [INFO] [stderr] 29 | | &Command::Help => help(), [INFO] [stderr] 30 | | &Command::Error(ref message) => error(message.clone()), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Command::AddUser(ref user, ref dept) => add_user(user.clone(), dept.clone(), &mut directory), [INFO] [stderr] 27 | Command::ListDepartment(ref dept) => list_department(dept.clone(), &mut directory), [INFO] [stderr] 28 | Command::Exit => exit(), [INFO] [stderr] 29 | Command::Help => help(), [INFO] [stderr] 30 | Command::Error(ref message) => error(message.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/commands/add_user.rs:5:63 [INFO] [stderr] | [INFO] [stderr] 5 | let dept_record = directory.departments.entry(department).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/mod.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Command::AddUser(ref user, ref dept) => add_user(user.clone(), dept.clone(), &mut directory), [INFO] [stderr] 27 | | &Command::ListDepartment(ref dept) => list_department(dept.clone(), &mut directory), [INFO] [stderr] 28 | | &Command::Exit => exit(), [INFO] [stderr] 29 | | &Command::Help => help(), [INFO] [stderr] 30 | | &Command::Error(ref message) => error(message.clone()), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Command::AddUser(ref user, ref dept) => add_user(user.clone(), dept.clone(), &mut directory), [INFO] [stderr] 27 | Command::ListDepartment(ref dept) => list_department(dept.clone(), &mut directory), [INFO] [stderr] 28 | Command::Exit => exit(), [INFO] [stderr] 29 | Command::Help => help(), [INFO] [stderr] 30 | Command::Error(ref message) => error(message.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "81168955b0febdd99c841754d8320bc56c290664728e1905d1165cec6135bdbf"` [INFO] running `"docker" "rm" "-f" "81168955b0febdd99c841754d8320bc56c290664728e1905d1165cec6135bdbf"` [INFO] [stdout] 81168955b0febdd99c841754d8320bc56c290664728e1905d1165cec6135bdbf