[INFO] updating cached repository carloscasalar/net-pathfinder
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/carloscasalar/net-pathfinder
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/carloscasalar/net-pathfinder" "work/ex/clippy-test-run/sources/stable/gh/carloscasalar/net-pathfinder"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/carloscasalar/net-pathfinder'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/carloscasalar/net-pathfinder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carloscasalar/net-pathfinder"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carloscasalar/net-pathfinder'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1e7121a66541abf8a62a206f58d338a4fe924fd1
[INFO] sha for GitHub repo carloscasalar/net-pathfinder: 1e7121a66541abf8a62a206f58d338a4fe924fd1
[INFO] validating manifest of carloscasalar/net-pathfinder on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of carloscasalar/net-pathfinder on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing carloscasalar/net-pathfinder
[INFO] finished frobbing carloscasalar/net-pathfinder
[INFO] frobbed toml for carloscasalar/net-pathfinder written to work/ex/clippy-test-run/sources/stable/gh/carloscasalar/net-pathfinder/Cargo.toml
[INFO] started frobbing carloscasalar/net-pathfinder
[INFO] finished frobbing carloscasalar/net-pathfinder
[INFO] frobbed toml for carloscasalar/net-pathfinder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carloscasalar/net-pathfinder/Cargo.toml
[INFO] crate carloscasalar/net-pathfinder has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting carloscasalar/net-pathfinder against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carloscasalar/net-pathfinder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cea1d3c7eeb67bd7efcf58459557d04ca6350957b549bedbdde83bc9100f981c
[INFO] running `"docker" "start" "-a" "cea1d3c7eeb67bd7efcf58459557d04ca6350957b549bedbdde83bc9100f981c"`
[INFO] [stderr]     Checking net-pathfinder v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]  --> src/node.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         &self.id() == &other_point.id()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]   |
[INFO] [stderr] 9 |         self.id() == other_point.id()
[INFO] [stderr]   |         ^^^^^^^^^    ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `node::NodeBuilder<T>`
[INFO] [stderr]   --> src/node.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 | /     pub fn new() -> NodeBuilder<T> {
[INFO] [stderr] 78 | |         let point = None;
[INFO] [stderr] 79 | |         let connections = None;
[INFO] [stderr] 80 | |         NodeBuilder { point, connected_points: connections }
[INFO] [stderr] 81 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 71 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/node.rs:104:58
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn connected_points(&mut self, connected_points: &Vec<T>) -> &mut Self {
[INFO] [stderr]     |                                                          ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `path::PathBuilder<T>`
[INFO] [stderr]   --> src/path.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn new() -> PathBuilder<T> {
[INFO] [stderr] 49 | |         let points = None;
[INFO] [stderr] 50 | |         PathBuilder { points }
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 43 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/net.rs:41:95
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn all_paths_to_destination_following_path_and_continuing_with_points(&self, destination: &&T, previous_path: &Path<T>, followable_points: Vec<&T>) -> Vec<Path<T>> {
[INFO] [stderr]    |                                                                                               ^^^ help: consider passing by value instead: `&T`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]  --> src/node.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         &self.id() == &other_point.id()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]   |
[INFO] [stderr] 9 |         self.id() == other_point.id()
[INFO] [stderr]   |         ^^^^^^^^^    ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `node::NodeBuilder<T>`
[INFO] [stderr]   --> src/node.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 | /     pub fn new() -> NodeBuilder<T> {
[INFO] [stderr] 78 | |         let point = None;
[INFO] [stderr] 79 | |         let connections = None;
[INFO] [stderr] 80 | |         NodeBuilder { point, connected_points: connections }
[INFO] [stderr] 81 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 71 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/node.rs:104:58
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn connected_points(&mut self, connected_points: &Vec<T>) -> &mut Self {
[INFO] [stderr]     |                                                          ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `path::PathBuilder<T>`
[INFO] [stderr]   --> src/path.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn new() -> PathBuilder<T> {
[INFO] [stderr] 49 | |         let points = None;
[INFO] [stderr] 50 | |         PathBuilder { points }
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 43 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/net.rs:41:95
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn all_paths_to_destination_following_path_and_continuing_with_points(&self, destination: &&T, previous_path: &Path<T>, followable_points: Vec<&T>) -> Vec<Path<T>> {
[INFO] [stderr]    |                                                                                               ^^^ help: consider passing by value instead: `&T`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/net.rs:230:14
[INFO] [stderr]     |
[INFO] [stderr] 230 |             .expect(&format!("should not throw exception finding path a to c in net {:?}", a_b_c_net).into_boxed_str());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = &format!("should not throw exception finding path a to c in net {:?}", a_b_c_net).into_boxed_str(); panic!(msg) }))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/net.rs:257:14
[INFO] [stderr]     |
[INFO] [stderr] 257 |             .expect(&format!("should not throw exception finding path a to c in net {:?}", triangle_net).into_boxed_str());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = &format!("should not throw exception finding path a to c in net {:?}", triangle_net).into_boxed_str(); panic!(msg) }))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/net.rs:286:14
[INFO] [stderr]     |
[INFO] [stderr] 286 |             .expect(&format!("should not throw exception finding path a to c in net {:?}", triangle_net).into_boxed_str());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = &format!("should not throw exception finding path a to c in net {:?}", triangle_net).into_boxed_str(); panic!(msg) }))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/net.rs:309:29
[INFO] [stderr]     |
[INFO] [stderr] 309 |         SimplePoint { name: name.clone() }
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: try removing the `clone` call: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.79s
[INFO] running `"docker" "inspect" "cea1d3c7eeb67bd7efcf58459557d04ca6350957b549bedbdde83bc9100f981c"`
[INFO] running `"docker" "rm" "-f" "cea1d3c7eeb67bd7efcf58459557d04ca6350957b549bedbdde83bc9100f981c"`
[INFO] [stdout] cea1d3c7eeb67bd7efcf58459557d04ca6350957b549bedbdde83bc9100f981c