[INFO] updating cached repository care0717/rugcc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/care0717/rugcc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/care0717/rugcc" "work/ex/clippy-test-run/sources/stable/gh/care0717/rugcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/care0717/rugcc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/care0717/rugcc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/care0717/rugcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/care0717/rugcc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b065d56cf8e3fd2507b9f70bf73634d715671cc9 [INFO] sha for GitHub repo care0717/rugcc: b065d56cf8e3fd2507b9f70bf73634d715671cc9 [INFO] validating manifest of care0717/rugcc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of care0717/rugcc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing care0717/rugcc [INFO] finished frobbing care0717/rugcc [INFO] frobbed toml for care0717/rugcc written to work/ex/clippy-test-run/sources/stable/gh/care0717/rugcc/Cargo.toml [INFO] started frobbing care0717/rugcc [INFO] finished frobbing care0717/rugcc [INFO] frobbed toml for care0717/rugcc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/care0717/rugcc/Cargo.toml [INFO] crate care0717/rugcc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting care0717/rugcc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/care0717/rugcc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c750c4a62dad4c39cab5fa1af6f9a8daaeb8abaf996d68908f6654a96472c45 [INFO] running `"docker" "start" "-a" "4c750c4a62dad4c39cab5fa1af6f9a8daaeb8abaf996d68908f6654a96472c45"` [INFO] [stderr] Checking rugcc v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return Type {ty: TY::CHAR, ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type {ty: TY::CHAR, ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | TY::INT => return 4, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | TY::ARY => return self.ary_of.clone().unwrap().size_of() * self.len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ary_of.clone().unwrap().size_of() * self.len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | TY::PTR => return 8, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | TY::CHAR => return 1, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return Type{ty: TY::ARY, ary_of: Some(Box::new(self.clone())), len, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type{ty: TY::ARY, ary_of: Some(Box::new(self.clone())), len, ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | return Type{ty: TY::PTR, ptr_of: Some(Box::new(self.clone())), ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type{ty: TY::PTR, ptr_of: Some(Box::new(self.clone())), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | ND::OPE(c) => return c, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:131:21 [INFO] [stderr] | [INFO] [stderr] 131 | return 'a' [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | return Node{op: ND::ADDR, ty: ty.ptr_of(), expr: Some(Box::new(self.clone())), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{op: ND::ADDR, ty: ty.ptr_of(), expr: Some(Box::new(self.clone())), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return Type {ty: TY::CHAR, ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type {ty: TY::CHAR, ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | TY::INT => return 4, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | TY::ARY => return self.ary_of.clone().unwrap().size_of() * self.len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ary_of.clone().unwrap().size_of() * self.len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | TY::PTR => return 8, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | TY::CHAR => return 1, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return Type{ty: TY::ARY, ary_of: Some(Box::new(self.clone())), len, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type{ty: TY::ARY, ary_of: Some(Box::new(self.clone())), len, ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | return Type{ty: TY::PTR, ptr_of: Some(Box::new(self.clone())), ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type{ty: TY::PTR, ptr_of: Some(Box::new(self.clone())), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | ND::OPE(c) => return c, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:131:21 [INFO] [stderr] | [INFO] [stderr] 131 | return 'a' [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | return Node{op: ND::ADDR, ty: ty.ptr_of(), expr: Some(Box::new(self.clone())), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{op: ND::ADDR, ty: ty.ptr_of(), expr: Some(Box::new(self.clone())), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | let length = temp.len(); [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:303:25 [INFO] [stderr] | [INFO] [stderr] 303 | let length = temp.len(); [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | let length = temp.len(); [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:303:25 [INFO] [stderr] | [INFO] [stderr] 303 | let length = temp.len(); [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] [INFO] [stderr] warning: variant `END_LINE` should have a camel case name such as `EndLine` [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | END_LINE, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `COMP_STMT` should have a camel case name such as `CompStmt` [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | COMP_STMT, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `EXPR_STMT` should have a camel case name such as `ExprStmt` [INFO] [stderr] --> src/lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | EXPR_STMT, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `SUB_IMM` should have a camel case name such as `SubImm` [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | SUB_IMM, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LABEL_ADDR` should have a camel case name such as `LabelAddr` [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | LABEL_ADDR, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `STORE8_ARG` should have a camel case name such as `Store8Arg` [INFO] [stderr] --> src/lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | STORE8_ARG, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `STORE32_ARG` should have a camel case name such as `Store32Arg` [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | STORE32_ARG, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `STORE64_ARG` should have a camel case name such as `Store64Arg` [INFO] [stderr] --> src/lib.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | STORE64_ARG, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `IRINFO`. [INFO] [stderr] --> src/lib.rs:197:22 [INFO] [stderr] | [INFO] [stderr] 197 | for i in 0..IRINFO.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 197 | for in &IRINFO { [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:214:45 [INFO] [stderr] | [INFO] [stderr] 214 | IRInfoType::NOARG => return format!("{}", info.name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `info.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant `LABEL_ADDR` should have a camel case name such as `LabelAddr` [INFO] [stderr] --> src/lib.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | LABEL_ADDR, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `REG_REG` should have a camel case name such as `RegReg` [INFO] [stderr] --> src/lib.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | REG_REG, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `END_LINE` should have a camel case name such as `EndLine` [INFO] [stderr] warning: variant `REG_IMN` should have a camel case name such as `RegImn` [INFO] [stderr] --> src/lib.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | REG_IMN, [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] 18 | END_LINE, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `REG_LABEL` should have a camel case name such as `RegLabel` [INFO] [stderr] | [INFO] [stderr] --> src/lib.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | REG_LABEL, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variant `IMM_IMM` should have a camel case name such as `ImmImm` [INFO] [stderr] --> src/lib.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | IMM_IMM, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:273:25 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn dump_ir(fns: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Function]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:281:30 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn dump_nodes(nodes: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variant `COMP_STMT` should have a camel case name such as `CompStmt` [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | COMP_STMT, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `EXPR_STMT` should have a camel case name such as `ExprStmt` [INFO] [stderr] --> src/lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | EXPR_STMT, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `SUB_IMM` should have a camel case name such as `SubImm` [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | SUB_IMM, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LABEL_ADDR` should have a camel case name such as `LabelAddr` [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | LABEL_ADDR, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `STORE8_ARG` should have a camel case name such as `Store8Arg` [INFO] [stderr] --> src/lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | STORE8_ARG, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `STORE32_ARG` should have a camel case name such as `Store32Arg` [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | STORE32_ARG, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `STORE64_ARG` should have a camel case name such as `Store64Arg` [INFO] [stderr] --> src/lib.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | STORE64_ARG, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `IRINFO`. [INFO] [stderr] --> src/lib.rs:197:22 [INFO] [stderr] | [INFO] [stderr] 197 | for i in 0..IRINFO.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 197 | for in &IRINFO { [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:214:45 [INFO] [stderr] | [INFO] [stderr] 214 | IRInfoType::NOARG => return format!("{}", info.name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `info.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant `LABEL_ADDR` should have a camel case name such as `LabelAddr` [INFO] [stderr] --> src/lib.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | LABEL_ADDR, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `REG_REG` should have a camel case name such as `RegReg` [INFO] [stderr] --> src/lib.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | REG_REG, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `REG_IMN` should have a camel case name such as `RegImn` [INFO] [stderr] --> src/lib.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | REG_IMN, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `REG_LABEL` should have a camel case name such as `RegLabel` [INFO] [stderr] --> src/lib.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | REG_LABEL, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `IMM_IMM` should have a camel case name such as `ImmImm` [INFO] [stderr] --> src/lib.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | IMM_IMM, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:273:25 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn dump_ir(fns: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Function]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:281:30 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn dump_nodes(nodes: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/token.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | print!("cannot tokenize: {}\n", c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/token.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | print!("cannot tokenize: {}\n", c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/token.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | print!("cannot tokenize: {}\n", c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/token.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | print!("cannot tokenize: {}\n", c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | return Node{ op, lhs: Some(Box::new(lhs)), rhs: Some(Box::new(rhs)), ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{ op, lhs: Some(Box::new(lhs)), rhs: Some(Box::new(rhs)), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return Node{op, expr: Some(Box::new(expr)), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{op, expr: Some(Box::new(expr)), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return tokens[tokens.len()-1].ty==TK::INT || tokens[tokens.len()-1].ty==TK::CHAR [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens[tokens.len()-1].ty==TK::INT || tokens[tokens.len()-1].ty==TK::CHAR` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return Node{ op: ND::NUM, val: token.val, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{ op: ND::NUM, val: token.val, ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | return Node{ op: ND::STR, str: token.str.clone(), ty: Type::new_char().ary_of(token.str.len()), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{ op: ND::STR, str: token.str.clone(), ty: Type::new_char().ary_of(token.str.len()), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return lhs [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return new_expr(ND::DEREF, mul(tokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_expr(ND::DEREF, mul(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return new_expr(ND::ADDR, mul(tokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_expr(ND::ADDR, mul(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return new_expr(ND::SIZEOF, unary(tokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_expr(ND::SIZEOF, unary(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return postfix(tokens) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `postfix(tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | return new_binop(ND::OPE('='), lhs, logor(tokens)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_binop(ND::OPE('='), lhs, logor(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | return ty [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | return ty [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | return expr_stmt(tokens) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr_stmt(tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | return Node{ op, lhs: Some(Box::new(lhs)), rhs: Some(Box::new(rhs)), ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{ op, lhs: Some(Box::new(lhs)), rhs: Some(Box::new(rhs)), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return Node{op, expr: Some(Box::new(expr)), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{op, expr: Some(Box::new(expr)), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return tokens[tokens.len()-1].ty==TK::INT || tokens[tokens.len()-1].ty==TK::CHAR [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens[tokens.len()-1].ty==TK::INT || tokens[tokens.len()-1].ty==TK::CHAR` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return Node{ op: ND::NUM, val: token.val, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{ op: ND::NUM, val: token.val, ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | return Node{ op: ND::STR, str: token.str.clone(), ty: Type::new_char().ary_of(token.str.len()), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{ op: ND::STR, str: token.str.clone(), ty: Type::new_char().ary_of(token.str.len()), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return lhs [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return new_expr(ND::DEREF, mul(tokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_expr(ND::DEREF, mul(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return new_expr(ND::ADDR, mul(tokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_expr(ND::ADDR, mul(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return new_expr(ND::SIZEOF, unary(tokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_expr(ND::SIZEOF, unary(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return postfix(tokens) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `postfix(tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | return new_binop(ND::OPE('='), lhs, logor(tokens)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_binop(ND::OPE('='), lhs, logor(tokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return lhs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | return ty [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | return ty [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | return expr_stmt(tokens) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr_stmt(tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | return nodes [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return tokens [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return IrGenerator{code: Vec::new(), regno: 1, label: 0} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IrGenerator{code: Vec::new(), regno: 1, label: 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | ND::DEREF => return self.gen_expr(*node.expr.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_expr(*node.expr.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return r1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | return r1 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | return r1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | ND::ADDR => return self.gen_lval(*node.expr.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_lval(*node.expr.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | return lhs [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | return self.gen_binop(IRType::LT, *node.lhs.unwrap(), *node.rhs.unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_binop(IRType::LT, *node.lhs.unwrap(), *node.rhs.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | return lhs [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | ND::OPE('*') => return self.gen_binop(IRType::MUL, *node.lhs.unwrap(), *node.rhs.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_binop(IRType::MUL, *node.lhs.unwrap(), *node.rhs.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | ND::OPE('/') => return self.gen_binop(IRType::DIV, *node.lhs.unwrap(), *node.rhs.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_binop(IRType::DIV, *node.lhs.unwrap(), *node.rhs.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | return nodes [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return tokens [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return IrGenerator{code: Vec::new(), regno: 1, label: 0} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IrGenerator{code: Vec::new(), regno: 1, label: 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | ND::DEREF => return self.gen_expr(*node.expr.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_expr(*node.expr.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return r1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | return r1 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | return r1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | ND::ADDR => return self.gen_lval(*node.expr.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_lval(*node.expr.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | return lhs [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | return self.gen_binop(IRType::LT, *node.lhs.unwrap(), *node.rhs.unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_binop(IRType::LT, *node.lhs.unwrap(), *node.rhs.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | return lhs [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | ND::OPE('*') => return self.gen_binop(IRType::MUL, *node.lhs.unwrap(), *node.rhs.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_binop(IRType::MUL, *node.lhs.unwrap(), *node.rhs.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | ND::OPE('/') => return self.gen_binop(IRType::DIV, *node.lhs.unwrap(), *node.rhs.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.gen_binop(IRType::DIV, *node.lhs.unwrap(), *node.rhs.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return funcs [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `funcs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return (q, p) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(q, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | ND::NUM => return node, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return self.walk(Node{op: ND::GVAR, ty: node.ty, val: node.val, ..Default::default()}, decay) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.walk(Node{op: ND::GVAR, ty: node.ty, val: node.val, ..Default::default()}, decay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ir.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return funcs [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `funcs` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return (q, p) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(q, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | ND::NUM => return node, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return self.walk(Node{op: ND::GVAR, ty: node.ty, val: node.val, ..Default::default()}, decay) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.walk(Node{op: ND::GVAR, ty: node.ty, val: node.val, ..Default::default()}, decay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | return Node{op: ND::NUM, ty:Type{..Default::default()}, val: expr.ty.size_of().to_string(), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{op: ND::NUM, ty:Type{..Default::default()}, val: expr.ty.size_of().to_string(), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return res [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | return Node{op: ND::NUM, ty:Type{..Default::default()}, val: expr.ty.size_of().to_string(), ..Default::default()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{op: ND::NUM, ty:Type{..Default::default()}, val: expr.ty.size_of().to_string(), ..Default::default()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sema.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return res [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/node.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | fn is_typename(tokens: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/token.rs:51:96 [INFO] [stderr] | [INFO] [stderr] 51 | tokens.push(Token{ty: TK::STR, val: c.to_string(), str: string.iter().collect(), ..Default::default()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/ir.rs:110:89 [INFO] [stderr] | [INFO] [stderr] 110 | let ir = IR { op: IRType::CALL, lhs: r, rhs: 0, name: node.val, args, ..Default::default() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/ir.rs:252:117 [INFO] [stderr] | [INFO] [stderr] 252 | funcs.push(Function{name, irs: self.code.clone(), stack_size: node.stack_size, strings: node.strings, ..Default::default()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sema.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | let var: Var = self.vars.get(&node.val).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.vars[&node.val]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `used` [INFO] [stderr] --> src/regalloc.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | for i in 0..REGS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 12 | for (i, ) in used.iter_mut().enumerate().take(REGS.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `irs`. [INFO] [stderr] --> src/regalloc.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | for i in 0..irs.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 24 | for in &mut irs { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `label` is used as a loop counter. Consider using `for (label, item) in fns.enumerate()` or similar iterators [INFO] [stderr] --> src/codegen.rs:136:14 [INFO] [stderr] | [INFO] [stderr] 136 | for f in fns{ [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/node.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | fn is_typename(tokens: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/token.rs:51:96 [INFO] [stderr] | [INFO] [stderr] 51 | tokens.push(Token{ty: TK::STR, val: c.to_string(), str: string.iter().collect(), ..Default::default()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/ir.rs:110:89 [INFO] [stderr] | [INFO] [stderr] 110 | let ir = IR { op: IRType::CALL, lhs: r, rhs: 0, name: node.val, args, ..Default::default() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/ir.rs:252:117 [INFO] [stderr] | [INFO] [stderr] 252 | funcs.push(Function{name, irs: self.code.clone(), stack_size: node.stack_size, strings: node.strings, ..Default::default()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sema.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | let var: Var = self.vars.get(&node.val).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.vars[&node.val]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `used` [INFO] [stderr] --> src/regalloc.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | for i in 0..REGS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 12 | for (i, ) in used.iter_mut().enumerate().take(REGS.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `irs`. [INFO] [stderr] --> src/regalloc.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | for i in 0..irs.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 24 | for in &mut irs { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `label` is used as a loop counter. Consider using `for (label, item) in fns.enumerate()` or similar iterators [INFO] [stderr] --> src/codegen.rs:136:14 [INFO] [stderr] | [INFO] [stderr] 136 | for f in fns{ [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "4c750c4a62dad4c39cab5fa1af6f9a8daaeb8abaf996d68908f6654a96472c45"` [INFO] running `"docker" "rm" "-f" "4c750c4a62dad4c39cab5fa1af6f9a8daaeb8abaf996d68908f6654a96472c45"` [INFO] [stdout] 4c750c4a62dad4c39cab5fa1af6f9a8daaeb8abaf996d68908f6654a96472c45