[INFO] updating cached repository cameronp/aoc17 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cameronp/aoc17 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cameronp/aoc17" "work/ex/clippy-test-run/sources/stable/gh/cameronp/aoc17"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cameronp/aoc17'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cameronp/aoc17" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cameronp/aoc17"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cameronp/aoc17'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4752cb9c16c516527f8a301e326de9afbef3afc4 [INFO] sha for GitHub repo cameronp/aoc17: 4752cb9c16c516527f8a301e326de9afbef3afc4 [INFO] validating manifest of cameronp/aoc17 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cameronp/aoc17 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cameronp/aoc17 [INFO] finished frobbing cameronp/aoc17 [INFO] frobbed toml for cameronp/aoc17 written to work/ex/clippy-test-run/sources/stable/gh/cameronp/aoc17/Cargo.toml [INFO] started frobbing cameronp/aoc17 [INFO] finished frobbing cameronp/aoc17 [INFO] frobbed toml for cameronp/aoc17 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cameronp/aoc17/Cargo.toml [INFO] crate cameronp/aoc17 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cameronp/aoc17 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cameronp/aoc17:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 267dbb04e4dada0a01abf4606920326f685d081675d8b2694ab755ae4b246177 [INFO] running `"docker" "start" "-a" "267dbb04e4dada0a01abf4606920326f685d081675d8b2694ab755ae4b246177"` [INFO] [stderr] Checking aoc17 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day2/mod.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | values [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day2/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / rows [INFO] [stderr] 59 | | .iter() [INFO] [stderr] 60 | | .map(|row| parse_row(row) ) [INFO] [stderr] 61 | | .collect(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day3/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | new_loc [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day3/mod.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let new_loc = match step { [INFO] [stderr] | ___________________^ [INFO] [stderr] 63 | | Step::East => (x + 1, y), [INFO] [stderr] 64 | | Step::North => (x, y - 1), [INFO] [stderr] 65 | | Step::West => (x - 1, y), [INFO] [stderr] 66 | | Step::South => (x, y + 1), [INFO] [stderr] 67 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day2/mod.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | values [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day2/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / rows [INFO] [stderr] 59 | | .iter() [INFO] [stderr] 60 | | .map(|row| parse_row(row) ) [INFO] [stderr] 61 | | .collect(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day3/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | new_loc [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day3/mod.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let new_loc = match step { [INFO] [stderr] | ___________________^ [INFO] [stderr] 63 | | Step::East => (x + 1, y), [INFO] [stderr] 64 | | Step::North => (x, y - 1), [INFO] [stderr] 65 | | Step::West => (x - 1, y), [INFO] [stderr] 66 | | Step::South => (x, y + 1), [INFO] [stderr] 67 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day1/mod.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | .fold(0, |acc: u32, x| acc + (x as u32) ) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | fn checksum2(rows: &Vec>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | fn checksum(rows: &Vec>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | fn min_max( row: &Vec ) -> (&usize, &usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day1/mod.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | .fold(0, |acc: u32, x| acc + (x as u32) ) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] --> src/day2/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | fn parse(s: &String) -> Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | .split("\t") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | fn checksum2(rows: &Vec>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | fn checksum(rows: &Vec>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | fn min_max( row: &Vec ) -> (&usize, &usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/day3/mod.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | duplicate(step.clone(), count) [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day2/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | fn parse(s: &String) -> Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | .split("\t") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day3/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in (1..n+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/day3/mod.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | duplicate(step.clone(), count) [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day3/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in (1..n+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "267dbb04e4dada0a01abf4606920326f685d081675d8b2694ab755ae4b246177"` [INFO] running `"docker" "rm" "-f" "267dbb04e4dada0a01abf4606920326f685d081675d8b2694ab755ae4b246177"` [INFO] [stdout] 267dbb04e4dada0a01abf4606920326f685d081675d8b2694ab755ae4b246177