[INFO] updating cached repository bvx89/a11 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bvx89/a11 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bvx89/a11" "work/ex/clippy-test-run/sources/stable/gh/bvx89/a11"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bvx89/a11'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bvx89/a11" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvx89/a11"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvx89/a11'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3fcc3b01763443b448209c89444268e82ad9df74 [INFO] sha for GitHub repo bvx89/a11: 3fcc3b01763443b448209c89444268e82ad9df74 [INFO] validating manifest of bvx89/a11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bvx89/a11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bvx89/a11 [INFO] finished frobbing bvx89/a11 [INFO] frobbed toml for bvx89/a11 written to work/ex/clippy-test-run/sources/stable/gh/bvx89/a11/Cargo.toml [INFO] started frobbing bvx89/a11 [INFO] finished frobbing bvx89/a11 [INFO] frobbed toml for bvx89/a11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvx89/a11/Cargo.toml [INFO] crate bvx89/a11 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bvx89/a11 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvx89/a11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf26726fce9e0258a612d1b9209262ab9c29a93cc90a587f8a1d71c61b1d9f16 [INFO] running `"docker" "start" "-a" "bf26726fce9e0258a612d1b9209262ab9c29a93cc90a587f8a1d71c61b1d9f16"` [INFO] [stderr] Checking a11 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return steps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `steps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / if x == x_final { [INFO] [stderr] 17 | | if y == y_final { [INFO] [stderr] 18 | | break; [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | if x == x_final && y == y_final { [INFO] [stderr] 17 | break; [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return steps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `steps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / if x == x_final { [INFO] [stderr] 17 | | if y == y_final { [INFO] [stderr] 18 | | break; [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | if x == x_final && y == y_final { [INFO] [stderr] 17 | break; [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(x - x_final).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | if y == y_final { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(y - y_final).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | if y == y_final { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | } else if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(x - x_final).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | } else if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `a11`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(x - x_final).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | if y == y_final { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(y - y_final).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | if y == y_final { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | } else if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(x - x_final).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | } else if x == x_final { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `a11`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bf26726fce9e0258a612d1b9209262ab9c29a93cc90a587f8a1d71c61b1d9f16"` [INFO] running `"docker" "rm" "-f" "bf26726fce9e0258a612d1b9209262ab9c29a93cc90a587f8a1d71c61b1d9f16"` [INFO] [stdout] bf26726fce9e0258a612d1b9209262ab9c29a93cc90a587f8a1d71c61b1d9f16