[INFO] updating cached repository burtgulash/slouptrie [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/burtgulash/slouptrie [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/burtgulash/slouptrie" "work/ex/clippy-test-run/sources/stable/gh/burtgulash/slouptrie"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/burtgulash/slouptrie'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/burtgulash/slouptrie" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burtgulash/slouptrie"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burtgulash/slouptrie'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ee46789d08c1a6de6df7dc8c54462c5f94495e52 [INFO] sha for GitHub repo burtgulash/slouptrie: ee46789d08c1a6de6df7dc8c54462c5f94495e52 [INFO] validating manifest of burtgulash/slouptrie on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of burtgulash/slouptrie on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing burtgulash/slouptrie [INFO] finished frobbing burtgulash/slouptrie [INFO] frobbed toml for burtgulash/slouptrie written to work/ex/clippy-test-run/sources/stable/gh/burtgulash/slouptrie/Cargo.toml [INFO] started frobbing burtgulash/slouptrie [INFO] finished frobbing burtgulash/slouptrie [INFO] frobbed toml for burtgulash/slouptrie written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burtgulash/slouptrie/Cargo.toml [INFO] crate burtgulash/slouptrie has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting burtgulash/slouptrie against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burtgulash/slouptrie:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4d199d6f01cbed97613311c3f2bae443af2ddfdcdeee96c8ae91749857a1af7 [INFO] running `"docker" "start" "-a" "f4d199d6f01cbed97613311c3f2bae443af2ddfdcdeee96c8ae91749857a1af7"` [INFO] [stderr] Checking slouptrie v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | prefix_size: prefix_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | is_terminal: is_terminal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_terminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | prefix_size: prefix_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | is_terminal: is_terminal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_terminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d_matrix` [INFO] [stderr] --> src/main.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | for i in 0 .. l + 1 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 173 | for (i, ) in d_matrix.iter_mut().enumerate().take(l + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | for i in 0 .. l + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/main.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / fn _fuzzy(&self, matches: &mut Vec<(String, usize)>, [INFO] [stderr] 191 | | word: Vec, k: usize, search_prefix: bool, [INFO] [stderr] 192 | | mut word_sofar: Vec, node: usize, [INFO] [stderr] 193 | | s: usize, mat: &mut [usize], lvl: usize) [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | assert!(matched.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j * s` [INFO] [stderr] --> src/main.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | mat[j * s + 0] = j; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d_matrix` [INFO] [stderr] --> src/main.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | for i in 0 .. l + 1 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 173 | for (i, ) in d_matrix.iter_mut().enumerate().take(l + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | for i in 0 .. l + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/main.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / fn _fuzzy(&self, matches: &mut Vec<(String, usize)>, [INFO] [stderr] 191 | | word: Vec, k: usize, search_prefix: bool, [INFO] [stderr] 192 | | mut word_sofar: Vec, node: usize, [INFO] [stderr] 193 | | s: usize, mat: &mut [usize], lvl: usize) [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | assert!(matched.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j * s` [INFO] [stderr] --> src/main.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | mat[j * s + 0] = j; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "f4d199d6f01cbed97613311c3f2bae443af2ddfdcdeee96c8ae91749857a1af7"` [INFO] running `"docker" "rm" "-f" "f4d199d6f01cbed97613311c3f2bae443af2ddfdcdeee96c8ae91749857a1af7"` [INFO] [stdout] f4d199d6f01cbed97613311c3f2bae443af2ddfdcdeee96c8ae91749857a1af7