[INFO] updating cached repository buaya91/rust-eulers [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/buaya91/rust-eulers [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/buaya91/rust-eulers" "work/ex/clippy-test-run/sources/stable/gh/buaya91/rust-eulers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/buaya91/rust-eulers'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/buaya91/rust-eulers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/buaya91/rust-eulers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/buaya91/rust-eulers'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 477ba85cad6a85dae43ede51755c7518b30f6fe8 [INFO] sha for GitHub repo buaya91/rust-eulers: 477ba85cad6a85dae43ede51755c7518b30f6fe8 [INFO] validating manifest of buaya91/rust-eulers on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of buaya91/rust-eulers on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing buaya91/rust-eulers [INFO] finished frobbing buaya91/rust-eulers [INFO] frobbed toml for buaya91/rust-eulers written to work/ex/clippy-test-run/sources/stable/gh/buaya91/rust-eulers/Cargo.toml [INFO] started frobbing buaya91/rust-eulers [INFO] finished frobbing buaya91/rust-eulers [INFO] frobbed toml for buaya91/rust-eulers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/buaya91/rust-eulers/Cargo.toml [INFO] crate buaya91/rust-eulers has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting buaya91/rust-eulers against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/buaya91/rust-eulers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d92ccf1d5e9c299abf62fdb1be95a6ea9d564b0efd26226303b613ba8449a68 [INFO] running `"docker" "start" "-a" "0d92ccf1d5e9c299abf62fdb1be95a6ea9d564b0efd26226303b613ba8449a68"` [INFO] [stderr] Checking rust-eulers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/solutions.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod solutions { [INFO] [stderr] 2 | | pub fn problem1() -> i32 { [INFO] [stderr] 3 | | let mut x = 0; [INFO] [stderr] 4 | | for n in 1..1000 { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | return fibonacci(b, a + b, max, new_acc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fibonacci(b, a + b, max, new_acc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | return acc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions.rs:30:35 [INFO] [stderr] | [INFO] [stderr] 30 | let ans = fibonacci(1, 2, 4000000, 2); [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return ans [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return set; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/solutions.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod solutions { [INFO] [stderr] 2 | | pub fn problem1() -> i32 { [INFO] [stderr] 3 | | let mut x = 0; [INFO] [stderr] 4 | | for n in 1..1000 { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | return fibonacci(b, a + b, max, new_acc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fibonacci(b, a + b, max, new_acc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | return acc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions.rs:30:35 [INFO] [stderr] | [INFO] [stderr] 30 | let ans = fibonacci(1, 2, 4000000, 2); [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return ans [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solutions.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return set; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `odd` [INFO] [stderr] --> src/solutions.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | odd => acc, [INFO] [stderr] | ^^^ help: consider using `_odd` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `problem101` [INFO] [stderr] --> src/solutions.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn problem101() -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/solutions.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | of5 if of5 % 5 == 0 => x = x + of5, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x += of5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/solutions.rs:7:40 [INFO] [stderr] | [INFO] [stderr] 7 | of3 if of3 % 3 == 0 => x = x + of3, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x += of3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/solutions.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `odd` [INFO] [stderr] --> src/solutions.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | odd => acc, [INFO] [stderr] | ^^^ help: consider using `_odd` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `problem101` [INFO] [stderr] --> src/solutions.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn problem101() -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/solutions.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | of5 if of5 % 5 == 0 => x = x + of5, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x += of5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/solutions.rs:7:40 [INFO] [stderr] | [INFO] [stderr] 7 | of3 if of3 % 3 == 0 => x = x + of3, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x += of3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/solutions.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "0d92ccf1d5e9c299abf62fdb1be95a6ea9d564b0efd26226303b613ba8449a68"` [INFO] running `"docker" "rm" "-f" "0d92ccf1d5e9c299abf62fdb1be95a6ea9d564b0efd26226303b613ba8449a68"` [INFO] [stdout] 0d92ccf1d5e9c299abf62fdb1be95a6ea9d564b0efd26226303b613ba8449a68