[INFO] updating cached repository bshankar/qss [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bshankar/qss [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bshankar/qss" "work/ex/clippy-test-run/sources/stable/gh/bshankar/qss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bshankar/qss'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bshankar/qss" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bshankar/qss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bshankar/qss'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6db3cde39dedcd8002e934664bbfce15cc20fcea [INFO] sha for GitHub repo bshankar/qss: 6db3cde39dedcd8002e934664bbfce15cc20fcea [INFO] validating manifest of bshankar/qss on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bshankar/qss on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bshankar/qss [INFO] finished frobbing bshankar/qss [INFO] frobbed toml for bshankar/qss written to work/ex/clippy-test-run/sources/stable/gh/bshankar/qss/Cargo.toml [INFO] started frobbing bshankar/qss [INFO] finished frobbing bshankar/qss [INFO] frobbed toml for bshankar/qss written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bshankar/qss/Cargo.toml [INFO] crate bshankar/qss has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bshankar/qss against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bshankar/qss:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afc9a6f9c94cc9c282c91a1bd8eef829a0ad05d84ad4c375390922b440b21b8e [INFO] running `"docker" "start" "-a" "afc9a6f9c94cc9c282c91a1bd8eef829a0ad05d84ad4c375390922b440b21b8e"` [INFO] [stderr] Checking qss v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/solve.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | fn prepare(s: &String, b: &mut Board) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/solve.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn solve(s: &String, b: &mut Board) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/solve.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | fn prepare(s: &String, b: &mut Board) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/solve.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn solve(s: &String, b: &mut Board) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "afc9a6f9c94cc9c282c91a1bd8eef829a0ad05d84ad4c375390922b440b21b8e"` [INFO] running `"docker" "rm" "-f" "afc9a6f9c94cc9c282c91a1bd8eef829a0ad05d84ad4c375390922b440b21b8e"` [INFO] [stdout] afc9a6f9c94cc9c282c91a1bd8eef829a0ad05d84ad4c375390922b440b21b8e