[INFO] updating cached repository bschwind/udp-stress-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bschwind/udp-stress-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bschwind/udp-stress-test" "work/ex/clippy-test-run/sources/stable/gh/bschwind/udp-stress-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bschwind/udp-stress-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bschwind/udp-stress-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bschwind/udp-stress-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bschwind/udp-stress-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae582a9eb84e7c8ddbdce41d0f638ca9d149e007 [INFO] sha for GitHub repo bschwind/udp-stress-test: ae582a9eb84e7c8ddbdce41d0f638ca9d149e007 [INFO] validating manifest of bschwind/udp-stress-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bschwind/udp-stress-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bschwind/udp-stress-test [INFO] finished frobbing bschwind/udp-stress-test [INFO] frobbed toml for bschwind/udp-stress-test written to work/ex/clippy-test-run/sources/stable/gh/bschwind/udp-stress-test/Cargo.toml [INFO] started frobbing bschwind/udp-stress-test [INFO] finished frobbing bschwind/udp-stress-test [INFO] frobbed toml for bschwind/udp-stress-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bschwind/udp-stress-test/Cargo.toml [INFO] crate bschwind/udp-stress-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bschwind/udp-stress-test against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bschwind/udp-stress-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c643d0842ada3500078786d5a75c1dabbef9cb8499100e49fdb48629894e5006 [INFO] running `"docker" "start" "-a" "c643d0842ada3500078786d5a75c1dabbef9cb8499100e49fdb48629894e5006"` [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking tokio-timer v0.1.1 [INFO] [stderr] Checking tokio-core v0.1.7 [INFO] [stderr] Checking clap v2.24.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking udp-fun v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/main.rs:113:50 [INFO] [stderr] | [INFO] [stderr] 113 | fn run_server(bind_addr: &str, server_port: u16, buf: Vec, num_clients: usize) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/main.rs:113:50 [INFO] [stderr] | [INFO] [stderr] 113 | fn run_server(bind_addr: &str, server_port: u16, buf: Vec, num_clients: usize) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:138:55 [INFO] [stderr] | [INFO] [stderr] 138 | fn run_client(server_ip: &str, server_port: u16, buf: &Vec, index: u16, randomize_starts: bool, run_duration: Duration, tick_rate_hz: u32, timer: Timer, handle: Handle, result_tx: oneshot::Sender<(u16, u64, u64)>) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 138 | fn run_client(server_ip: &str, server_port: u16, buf: &[u8], index: u16, randomize_starts: bool, run_duration: Duration, tick_rate_hz: u32, timer: Timer, handle: Handle, result_tx: oneshot::Sender<(u16, u64, u64)>) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `buf.clone()` to [INFO] [stderr] | [INFO] [stderr] 144 | let mut client_buf = buf.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/main.rs:138:1 [INFO] [stderr] | [INFO] [stderr] 138 | / fn run_client(server_ip: &str, server_port: u16, buf: &Vec, index: u16, randomize_starts: bool, run_duration: Duration, tick_rate_hz: u32, timer: Timer, handle: Handle, result_tx: oneshot::Sender<(u16, u64, u64)>) { [INFO] [stderr] 139 | | let addr = SocketAddr::new(IpAddr::from_str("0.0.0.0").unwrap(), 0); [INFO] [stderr] 140 | | let server_addr = SocketAddr::new(IpAddr::from_str(server_ip).unwrap(), server_port); [INFO] [stderr] 141 | | [INFO] [stderr] ... | [INFO] [stderr] 214 | | handle.spawn(final_future); [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:60 [INFO] [stderr] | [INFO] [stderr] 150 | let send_interval_duration = Duration::from_millis(1000 / tick_rate_hz as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tick_rate_hz)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:268:54 [INFO] [stderr] | [INFO] [stderr] 268 | let server_host = value_t!(matches, "host", String).unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "127.0.0.1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:270:57 [INFO] [stderr] | [INFO] [stderr] 270 | let bind_addr = value_t!(matches, "bind_addr", String).unwrap_or("0.0.0.0".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0.0.0.0".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:138:55 [INFO] [stderr] | [INFO] [stderr] 138 | fn run_client(server_ip: &str, server_port: u16, buf: &Vec, index: u16, randomize_starts: bool, run_duration: Duration, tick_rate_hz: u32, timer: Timer, handle: Handle, result_tx: oneshot::Sender<(u16, u64, u64)>) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 138 | fn run_client(server_ip: &str, server_port: u16, buf: &[u8], index: u16, randomize_starts: bool, run_duration: Duration, tick_rate_hz: u32, timer: Timer, handle: Handle, result_tx: oneshot::Sender<(u16, u64, u64)>) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `buf.clone()` to [INFO] [stderr] | [INFO] [stderr] 144 | let mut client_buf = buf.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/main.rs:138:1 [INFO] [stderr] | [INFO] [stderr] 138 | / fn run_client(server_ip: &str, server_port: u16, buf: &Vec, index: u16, randomize_starts: bool, run_duration: Duration, tick_rate_hz: u32, timer: Timer, handle: Handle, result_tx: oneshot::Sender<(u16, u64, u64)>) { [INFO] [stderr] 139 | | let addr = SocketAddr::new(IpAddr::from_str("0.0.0.0").unwrap(), 0); [INFO] [stderr] 140 | | let server_addr = SocketAddr::new(IpAddr::from_str(server_ip).unwrap(), server_port); [INFO] [stderr] 141 | | [INFO] [stderr] ... | [INFO] [stderr] 214 | | handle.spawn(final_future); [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:60 [INFO] [stderr] | [INFO] [stderr] 150 | let send_interval_duration = Duration::from_millis(1000 / tick_rate_hz as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tick_rate_hz)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:268:54 [INFO] [stderr] | [INFO] [stderr] 268 | let server_host = value_t!(matches, "host", String).unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "127.0.0.1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:270:57 [INFO] [stderr] | [INFO] [stderr] 270 | let bind_addr = value_t!(matches, "bind_addr", String).unwrap_or("0.0.0.0".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0.0.0.0".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.53s [INFO] running `"docker" "inspect" "c643d0842ada3500078786d5a75c1dabbef9cb8499100e49fdb48629894e5006"` [INFO] running `"docker" "rm" "-f" "c643d0842ada3500078786d5a75c1dabbef9cb8499100e49fdb48629894e5006"` [INFO] [stdout] c643d0842ada3500078786d5a75c1dabbef9cb8499100e49fdb48629894e5006