[INFO] updating cached repository brunoczim/rust-bfc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/brunoczim/rust-bfc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/brunoczim/rust-bfc" "work/ex/clippy-test-run/sources/stable/gh/brunoczim/rust-bfc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brunoczim/rust-bfc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/brunoczim/rust-bfc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brunoczim/rust-bfc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brunoczim/rust-bfc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8e17462b04c43dad2fbfa250b4acb0f98e389c08
[INFO] sha for GitHub repo brunoczim/rust-bfc: 8e17462b04c43dad2fbfa250b4acb0f98e389c08
[INFO] validating manifest of brunoczim/rust-bfc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of brunoczim/rust-bfc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing brunoczim/rust-bfc
[INFO] finished frobbing brunoczim/rust-bfc
[INFO] frobbed toml for brunoczim/rust-bfc written to work/ex/clippy-test-run/sources/stable/gh/brunoczim/rust-bfc/Cargo.toml
[INFO] started frobbing brunoczim/rust-bfc
[INFO] finished frobbing brunoczim/rust-bfc
[INFO] frobbed toml for brunoczim/rust-bfc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brunoczim/rust-bfc/Cargo.toml
[INFO] crate brunoczim/rust-bfc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting brunoczim/rust-bfc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brunoczim/rust-bfc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 19b82a392e8c6dc2b3646279c76e2eeeaa60bfd6a69fd9253f4c43a695e87fc9
[INFO] running `"docker" "start" "-a" "19b82a392e8c6dc2b3646279c76e2eeeaa60bfd6a69fd9253f4c43a695e87fc9"`
[INFO] [stderr]     Checking bfc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/back_end/x86.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         return label;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/back_end/x86.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         return label;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/front_end/bstream.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 | /     pub fn next(&mut self) -> bool {
[INFO] [stderr] 71 | |         match self.current() {
[INFO] [stderr] 72 | |             Some(ch) => {
[INFO] [stderr] 73 | |                 if ch == b'\n' {
[INFO] [stderr] ...  |
[INFO] [stderr] 83 | |         }
[INFO] [stderr] 84 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/front_end/bstream.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 | /     pub fn next(&mut self) -> bool {
[INFO] [stderr] 71 | |         match self.current() {
[INFO] [stderr] 72 | |             Some(ch) => {
[INFO] [stderr] 73 | |                 if ch == b'\n' {
[INFO] [stderr] ...  |
[INFO] [stderr] 83 | |         }
[INFO] [stderr] 84 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/front_end/mod.rs:141:8
[INFO] [stderr]     |
[INFO] [stderr] 141 |     if errs.len() > 0 {Err(errs)} else {Ok(loops.reclaim_val().ops)}
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/back_end/x86.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         &self,
[INFO] [stderr]    |         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/front_end/mod.rs:141:8
[INFO] [stderr]     |
[INFO] [stderr] 141 |     if errs.len() > 0 {Err(errs)} else {Ok(loops.reclaim_val().ops)}
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/back_end/x86.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         &self,
[INFO] [stderr]    |         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/utils/hlist.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         match &self.next {
[INFO] [stderr] 43 | |             &Some(ref x) => Some(x.deref()),
[INFO] [stderr] 44 | |             _ => None,
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 42 |         match self.next {
[INFO] [stderr] 43 |             Some(ref x) => Some(x.deref()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/utils/hlist.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match &mut self.next {
[INFO] [stderr] 50 | |             &mut Some(ref mut x) => Some(x.deref_mut()),
[INFO] [stderr] 51 | |             _ => None,
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *(&mut self.next) {
[INFO] [stderr] 50 |             Some(ref mut x) => Some(x.deref_mut()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:28:30
[INFO] [stderr]    |
[INFO] [stderr] 28 |                   Some(arg) => match &march {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 29 | |                     &None => march = Some(match arg.as_ref() {
[INFO] [stderr] 30 | |                         "x86" => X86Mode::X86,
[INFO] [stderr] 31 | |                         "x86-64" | "x86_64" | "amd64" | "x64" => X86Mode::Amd64,
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |                     },
[INFO] [stderr] 43 | |                 },
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 Some(arg) => match march {
[INFO] [stderr] 29 |                     None => march = Some(match arg.as_ref() {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:51:28
[INFO] [stderr]    |
[INFO] [stderr] 51 |                   Some(o) => match &mout {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 52 | |                     &None => mout = Some(o),
[INFO] [stderr] 53 | |                     _ => {
[INFO] [stderr] 54 | |                         println!("Output file already passed.");
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |                     },
[INFO] [stderr] 58 | |                 },
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 Some(o) => match mout {
[INFO] [stderr] 52 |                     None => mout = Some(o),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:66:30
[INFO] [stderr]    |
[INFO] [stderr] 66 |                   Some(arg) => match &mformat {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 67 | |                     &None => mformat = Some(match arg.as_ref() {
[INFO] [stderr] 68 | |                         "elf" => Format::Elf,
[INFO] [stderr] 69 | |                         "asm" => Format::Asm,
[INFO] [stderr] ...  |
[INFO] [stderr] 80 | |                     },
[INFO] [stderr] 81 | |                 },
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 Some(arg) => match mformat {
[INFO] [stderr] 67 |                     None => mformat = Some(match arg.as_ref() {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:88:18
[INFO] [stderr]    |
[INFO] [stderr] 88 |               _ => match &mfile {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 89 | |                 &None => mfile = Some(arg),
[INFO] [stderr] 90 | |                 _ => {
[INFO] [stderr] 91 | |                     println!("Input file already passed.");
[INFO] [stderr] ...  |
[INFO] [stderr] 94 | |                 },
[INFO] [stderr] 95 | |             },
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |             _ => match mfile {
[INFO] [stderr] 89 |                 None => mfile = Some(arg),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/utils/hlist.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         match &self.next {
[INFO] [stderr] 43 | |             &Some(ref x) => Some(x.deref()),
[INFO] [stderr] 44 | |             _ => None,
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 42 |         match self.next {
[INFO] [stderr] 43 |             Some(ref x) => Some(x.deref()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/utils/hlist.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match &mut self.next {
[INFO] [stderr] 50 | |             &mut Some(ref mut x) => Some(x.deref_mut()),
[INFO] [stderr] 51 | |             _ => None,
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *(&mut self.next) {
[INFO] [stderr] 50 |             Some(ref mut x) => Some(x.deref_mut()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:28:30
[INFO] [stderr]    |
[INFO] [stderr] 28 |                   Some(arg) => match &march {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 29 | |                     &None => march = Some(match arg.as_ref() {
[INFO] [stderr] 30 | |                         "x86" => X86Mode::X86,
[INFO] [stderr] 31 | |                         "x86-64" | "x86_64" | "amd64" | "x64" => X86Mode::Amd64,
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |                     },
[INFO] [stderr] 43 | |                 },
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 Some(arg) => match march {
[INFO] [stderr] 29 |                     None => march = Some(match arg.as_ref() {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:51:28
[INFO] [stderr]    |
[INFO] [stderr] 51 |                   Some(o) => match &mout {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 52 | |                     &None => mout = Some(o),
[INFO] [stderr] 53 | |                     _ => {
[INFO] [stderr] 54 | |                         println!("Output file already passed.");
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |                     },
[INFO] [stderr] 58 | |                 },
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 Some(o) => match mout {
[INFO] [stderr] 52 |                     None => mout = Some(o),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:66:30
[INFO] [stderr]    |
[INFO] [stderr] 66 |                   Some(arg) => match &mformat {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 67 | |                     &None => mformat = Some(match arg.as_ref() {
[INFO] [stderr] 68 | |                         "elf" => Format::Elf,
[INFO] [stderr] 69 | |                         "asm" => Format::Asm,
[INFO] [stderr] ...  |
[INFO] [stderr] 80 | |                     },
[INFO] [stderr] 81 | |                 },
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 Some(arg) => match mformat {
[INFO] [stderr] 67 |                     None => mformat = Some(match arg.as_ref() {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:88:18
[INFO] [stderr]    |
[INFO] [stderr] 88 |               _ => match &mfile {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 89 | |                 &None => mfile = Some(arg),
[INFO] [stderr] 90 | |                 _ => {
[INFO] [stderr] 91 | |                     println!("Input file already passed.");
[INFO] [stderr] ...  |
[INFO] [stderr] 94 | |                 },
[INFO] [stderr] 95 | |             },
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |             _ => match mfile {
[INFO] [stderr] 89 |                 None => mfile = Some(arg),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.95s
[INFO] running `"docker" "inspect" "19b82a392e8c6dc2b3646279c76e2eeeaa60bfd6a69fd9253f4c43a695e87fc9"`
[INFO] running `"docker" "rm" "-f" "19b82a392e8c6dc2b3646279c76e2eeeaa60bfd6a69fd9253f4c43a695e87fc9"`
[INFO] [stdout] 19b82a392e8c6dc2b3646279c76e2eeeaa60bfd6a69fd9253f4c43a695e87fc9