[INFO] updating cached repository brianp/muxednew [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brianp/muxednew [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brianp/muxednew" "work/ex/clippy-test-run/sources/stable/gh/brianp/muxednew"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brianp/muxednew'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brianp/muxednew" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxednew"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxednew'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e70cff33b32fcf6a4b49c56646d2e69df4a77ada [INFO] sha for GitHub repo brianp/muxednew: e70cff33b32fcf6a4b49c56646d2e69df4a77ada [INFO] validating manifest of brianp/muxednew on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brianp/muxednew on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brianp/muxednew [INFO] finished frobbing brianp/muxednew [INFO] frobbed toml for brianp/muxednew written to work/ex/clippy-test-run/sources/stable/gh/brianp/muxednew/Cargo.toml [INFO] started frobbing brianp/muxednew [INFO] finished frobbing brianp/muxednew [INFO] frobbed toml for brianp/muxednew written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxednew/Cargo.toml [INFO] crate brianp/muxednew has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brianp/muxednew against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxednew:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d657a11911147d35efccf97bdf538469dfc7da26cc6ed1cbadaf761d8af11684 [INFO] running `"docker" "start" "-a" "d657a11911147d35efccf97bdf538469dfc7da26cc6ed1cbadaf761d8af11684"` [INFO] [stderr] Checking clap v2.5.2 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking muxednew v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> tests/new.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> tests/new.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/new.rs:13:63 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn muxednew(project: &String, project_root: &PathBuf) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/new.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | fn cleanup(config_path: &PathBuf) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | #[cfg(not(test))] use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:102:11 [INFO] [stderr] | [INFO] [stderr] 102 | match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:89:29 [INFO] [stderr] | [INFO] [stderr] 89 | fn write_template(template: &String, path: &PathBuf) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> tests/new.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn muxednew(project: &String, project_root: &PathBuf) -> () { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> tests/new.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | fn setup(project_name: &String) -> (PathBuf, PathBuf) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:89:29 [INFO] [stderr] | [INFO] [stderr] 89 | fn write_template(template: &String, path: &PathBuf) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.64s [INFO] running `"docker" "inspect" "d657a11911147d35efccf97bdf538469dfc7da26cc6ed1cbadaf761d8af11684"` [INFO] running `"docker" "rm" "-f" "d657a11911147d35efccf97bdf538469dfc7da26cc6ed1cbadaf761d8af11684"` [INFO] [stdout] d657a11911147d35efccf97bdf538469dfc7da26cc6ed1cbadaf761d8af11684