[INFO] updating cached repository brianp/muxed [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brianp/muxed [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brianp/muxed" "work/ex/clippy-test-run/sources/stable/gh/brianp/muxed"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brianp/muxed'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brianp/muxed" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxed"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxed'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07b9618f99b8121dac4c563948d90a9e40741546 [INFO] sha for GitHub repo brianp/muxed: 07b9618f99b8121dac4c563948d90a9e40741546 [INFO] validating manifest of brianp/muxed on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brianp/muxed on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brianp/muxed [INFO] finished frobbing brianp/muxed [INFO] frobbed toml for brianp/muxed written to work/ex/clippy-test-run/sources/stable/gh/brianp/muxed/Cargo.toml [INFO] started frobbing brianp/muxed [INFO] finished frobbing brianp/muxed [INFO] frobbed toml for brianp/muxed written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxed/Cargo.toml [INFO] crate brianp/muxed has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brianp/muxed against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianp/muxed:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4dbcbafbc0807c12a5a99a385c3f7d6741d1179b10e32d0e02dad7331050e5b6 [INFO] running `"docker" "start" "-a" "4dbcbafbc0807c12a5a99a385c3f7d6741d1179b10e32d0e02dad7331050e5b6"` [INFO] [stderr] Checking docopt v0.7.0 [INFO] [stderr] Checking muxed v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project/parser.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | layout: layout [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project/parser.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | layout: layout [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/helpers/mod.rs:135:11 [INFO] [stderr] | [INFO] [stderr] 135 | windows: windows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `windows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn attach(session_name: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:81:59 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn new_session(session_name: &str, window_name: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn split_window(target: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:116:58 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn new_window(session_name: &str, window_name: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn layout(target: &str, layout: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn send_keys(target: &str, exec: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:167:36 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn select_window(target: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:181:34 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn select_pane(target: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/project/processor.rs:25:35 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn main(commands: &[Command]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/project/processor.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | fn system_calls(cmd_string: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/project/mod.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg(not(test))] use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/project/mod.rs:62:11 [INFO] [stderr] | [INFO] [stderr] 62 | match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn attach(session_name: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:81:59 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn new_session(session_name: &str, window_name: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn split_window(target: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:116:58 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn new_window(session_name: &str, window_name: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn layout(target: &str, layout: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn send_keys(target: &str, exec: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:167:36 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn select_window(target: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tmux/mod.rs:181:34 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn select_pane(target: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/project/processor.rs:25:35 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn main(commands: &[Command]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/project/processor.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | fn system_calls(cmd_string: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/helpers/mod.rs:27:55 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn open_muxed(project: &str, project_root: &Path) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/helpers/mod.rs:42:35 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn kill_session(target: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/helpers/mod.rs:51:44 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn send_keys(target: &str, exec: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/helpers/mod.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn wait_on(file: &PathBuf) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/open.rs:45:59 [INFO] [stderr] | [INFO] [stderr] 45 | fn cleanup(project_name: &str, config_path: &PathBuf) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> tests/open.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> tests/open.rs:179:39 [INFO] [stderr] | [INFO] [stderr] 179 | assert_eq!(pane_current_path, home_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> tests/open.rs:191:39 [INFO] [stderr] | [INFO] [stderr] 191 | assert_eq!(pane_current_path, home_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/project/parser.rs:184:48 [INFO] [stderr] | [INFO] [stderr] 184 | let layout = window["layout"].as_str().expect(err.as_str()).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = err.as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match x.as_ref(){ [INFO] [stderr] 96 | | "new" => run_subcommand("muxednew", input), [INFO] [stderr] 97 | | _ => {} [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ help: try this: `if let "new" = x.as_ref() { run_subcommand("muxednew", input) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/project/parser.rs:184:48 [INFO] [stderr] | [INFO] [stderr] 184 | let layout = window["layout"].as_str().expect(err.as_str()).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = err.as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:217:150 [INFO] [stderr] | [INFO] [stderr] 217 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 218 | | &Command::Session(_) => true, [INFO] [stderr] 219 | | _ => false [INFO] [stderr] 220 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 217 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 218 | Command::Session(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:231:150 [INFO] [stderr] | [INFO] [stderr] 231 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 232 | | &Command::Window(_) => true, [INFO] [stderr] 233 | | _ => false [INFO] [stderr] 234 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 232 | Command::Window(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:245:150 [INFO] [stderr] | [INFO] [stderr] 245 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 246 | | &Command::Attach(_) => true, [INFO] [stderr] 247 | | _ => false [INFO] [stderr] 248 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 245 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 246 | Command::Attach(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:259:150 [INFO] [stderr] | [INFO] [stderr] 259 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 260 | | &Command::Window(_) => true, [INFO] [stderr] 261 | | _ => false [INFO] [stderr] 262 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 260 | Command::Window(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:275:150 [INFO] [stderr] | [INFO] [stderr] 275 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 276 | | &Command::Window(_) => true, [INFO] [stderr] 277 | | _ => false [INFO] [stderr] 278 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 275 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 276 | Command::Window(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:301:150 [INFO] [stderr] | [INFO] [stderr] 301 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 302 | | &Command::SendKeys(_) => true, [INFO] [stderr] 303 | | _ => false [INFO] [stderr] 304 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 301 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 302 | Command::SendKeys(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:344:150 [INFO] [stderr] | [INFO] [stderr] 344 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 345 | | &Command::SendKeys(_) => true, [INFO] [stderr] 346 | | _ => false [INFO] [stderr] 347 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 344 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 345 | Command::SendKeys(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:362:150 [INFO] [stderr] | [INFO] [stderr] 362 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 363 | | &Command::Split(_) => true, [INFO] [stderr] 364 | | _ => false [INFO] [stderr] 365 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 362 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 363 | Command::Split(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:380:150 [INFO] [stderr] | [INFO] [stderr] 380 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 381 | | &Command::Layout(_) => true, [INFO] [stderr] 382 | | _ => false [INFO] [stderr] 383 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 380 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 381 | Command::Layout(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:398:150 [INFO] [stderr] | [INFO] [stderr] 398 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 399 | | &Command::Session(_) => true, [INFO] [stderr] 400 | | _ => false [INFO] [stderr] 401 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 398 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 399 | Command::Session(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:415:150 [INFO] [stderr] | [INFO] [stderr] 415 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 416 | | &Command::Layout(_) => true, [INFO] [stderr] 417 | | _ => false [INFO] [stderr] 418 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 415 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 416 | Command::Layout(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:436:150 [INFO] [stderr] | [INFO] [stderr] 436 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 437 | | &Command::SendKeys(_) => true, [INFO] [stderr] 438 | | _ => false [INFO] [stderr] 439 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 436 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 437 | Command::SendKeys(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:454:150 [INFO] [stderr] | [INFO] [stderr] 454 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 455 | | &Command::SendKeys(_) => true, [INFO] [stderr] 456 | | _ => false [INFO] [stderr] 457 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 454 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 455 | Command::SendKeys(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:471:150 [INFO] [stderr] | [INFO] [stderr] 471 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 472 | | &Command::SendKeys(_) => true, [INFO] [stderr] 473 | | _ => false [INFO] [stderr] 474 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 471 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 472 | Command::SendKeys(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:487:150 [INFO] [stderr] | [INFO] [stderr] 487 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 488 | | &Command::SendKeys(_) => true, [INFO] [stderr] 489 | | _ => false [INFO] [stderr] 490 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 487 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 488 | Command::SendKeys(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:504:143 [INFO] [stderr] | [INFO] [stderr] 504 | let remains: Command = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().find(|x| match x { [INFO] [stderr] | _______________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 505 | | &Command::SendKeys(_) => true, [INFO] [stderr] 506 | | _ => false [INFO] [stderr] 507 | | }).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 504 | let remains: Command = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().find(|x| match *x { [INFO] [stderr] 505 | Command::SendKeys(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:523:150 [INFO] [stderr] | [INFO] [stderr] 523 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 524 | | &Command::SelectWindow(_) => true, [INFO] [stderr] 525 | | _ => false [INFO] [stderr] 526 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 523 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 524 | Command::SelectWindow(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project/parser.rs:537:150 [INFO] [stderr] | [INFO] [stderr] 537 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match x { [INFO] [stderr] | ______________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 538 | | &Command::SelectPane(_) => true, [INFO] [stderr] 539 | | _ => false [INFO] [stderr] 540 | | }).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 537 | let remains: Vec = call(&yaml, &"muxed".to_string(), false, &Config{base_index: 0, pane_base_index: 0}).unwrap().into_iter().filter(|x| match *x { [INFO] [stderr] 538 | Command::SelectPane(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match x.as_ref(){ [INFO] [stderr] 96 | | "new" => run_subcommand("muxednew", input), [INFO] [stderr] 97 | | _ => {} [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ help: try this: `if let "new" = x.as_ref() { run_subcommand("muxednew", input) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.39s [INFO] running `"docker" "inspect" "4dbcbafbc0807c12a5a99a385c3f7d6741d1179b10e32d0e02dad7331050e5b6"` [INFO] running `"docker" "rm" "-f" "4dbcbafbc0807c12a5a99a385c3f7d6741d1179b10e32d0e02dad7331050e5b6"` [INFO] [stdout] 4dbcbafbc0807c12a5a99a385c3f7d6741d1179b10e32d0e02dad7331050e5b6