[INFO] updating cached repository brianjimenez/rust-pdb
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/brianjimenez/rust-pdb
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/brianjimenez/rust-pdb" "work/ex/clippy-test-run/sources/stable/gh/brianjimenez/rust-pdb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brianjimenez/rust-pdb'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/brianjimenez/rust-pdb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianjimenez/rust-pdb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianjimenez/rust-pdb'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6b63c64b8471752652243894fe89e18a3af0795a
[INFO] sha for GitHub repo brianjimenez/rust-pdb: 6b63c64b8471752652243894fe89e18a3af0795a
[INFO] validating manifest of brianjimenez/rust-pdb on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of brianjimenez/rust-pdb on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing brianjimenez/rust-pdb
[INFO] finished frobbing brianjimenez/rust-pdb
[INFO] frobbed toml for brianjimenez/rust-pdb written to work/ex/clippy-test-run/sources/stable/gh/brianjimenez/rust-pdb/Cargo.toml
[INFO] started frobbing brianjimenez/rust-pdb
[INFO] finished frobbing brianjimenez/rust-pdb
[INFO] frobbed toml for brianjimenez/rust-pdb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianjimenez/rust-pdb/Cargo.toml
[INFO] crate brianjimenez/rust-pdb has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting brianjimenez/rust-pdb against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brianjimenez/rust-pdb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e861bb1a5645d45965bc7fffe0ff2dea55d4d8b45fcd8393743077ee8bec6513
[INFO] running `"docker" "start" "-a" "e861bb1a5645d45965bc7fffe0ff2dea55d4d8b45fcd8393743077ee8bec6513"`
[INFO] [stderr]     Checking pdb v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     number
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |       let number = match number {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 23 | |         Ok(number) => number,
[INFO] [stderr] 24 | |         Err(e) => {
[INFO] [stderr] 25 | |             println!("Can not parse ({})", e);
[INFO] [stderr] 26 | |             0
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     number
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |       let number = match number {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 35 | |         Ok(number) => number,
[INFO] [stderr] 36 | |         Err(e) => {
[INFO] [stderr] 37 | |             println!("Can not parse ({})", e);
[INFO] [stderr] 38 | |             0.0
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:107:28
[INFO] [stderr]     |
[INFO] [stderr] 107 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 108 | |                         if let Some(chain) = current_model.chains.get_mut(&chain_id) {
[INFO] [stderr] 109 | |                             chain.residues.push(current_residue);
[INFO] [stderr] 110 | |                         }
[INFO] [stderr] 111 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 107 |                     } else if let Some(chain) = current_model.chains.get_mut(&chain_id) {
[INFO] [stderr] 108 |     chain.residues.push(current_residue);
[INFO] [stderr] 109 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     number
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |       let number = match number {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 23 | |         Ok(number) => number,
[INFO] [stderr] 24 | |         Err(e) => {
[INFO] [stderr] 25 | |             println!("Can not parse ({})", e);
[INFO] [stderr] 26 | |             0
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     number
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |       let number = match number {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 35 | |         Ok(number) => number,
[INFO] [stderr] 36 | |         Err(e) => {
[INFO] [stderr] 37 | |             println!("Can not parse ({})", e);
[INFO] [stderr] 38 | |             0.0
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:107:28
[INFO] [stderr]     |
[INFO] [stderr] 107 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 108 | |                         if let Some(chain) = current_model.chains.get_mut(&chain_id) {
[INFO] [stderr] 109 | |                             chain.residues.push(current_residue);
[INFO] [stderr] 110 | |                         }
[INFO] [stderr] 111 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 107 |                     } else if let Some(chain) = current_model.chains.get_mut(&chain_id) {
[INFO] [stderr] 108 |     chain.residues.push(current_residue);
[INFO] [stderr] 109 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/atom.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new(name: String, number: u32, x: f32, y: f32, z: f32, 
[INFO] [stderr] 17 | |         occupancy: f32, bfactor: f32, hetatom: bool) -> Atom {
[INFO] [stderr] 18 | |         Atom {
[INFO] [stderr] 19 | |             name,
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/atom.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         assert_eq!(a1 - a2, 2.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/atom.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         assert_eq!(a1 - a2, 2.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/atom.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new(name: String, number: u32, x: f32, y: f32, z: f32, 
[INFO] [stderr] 17 | |         occupancy: f32, bfactor: f32, hetatom: bool) -> Atom {
[INFO] [stderr] 18 | |         Atom {
[INFO] [stderr] 19 | |             name,
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:20:23
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn parse_u32(number : &String) -> u32 {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:32:23
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn parse_f32(number : &String) -> f32 {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:45:28
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn parse(filename: &String) -> Structure {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:20:23
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn parse_u32(number : &String) -> u32 {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:95:74
[INFO] [stderr]    |
[INFO] [stderr] 95 |                     current_residue = Residue::new(residue_name.clone(), residue_number.clone(), Vec::new());
[INFO] [stderr]    |                                                                          ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `residue_number`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:32:23
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn parse_f32(number : &String) -> f32 {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:45:28
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn parse(filename: &String) -> Structure {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:95:74
[INFO] [stderr]    |
[INFO] [stderr] 95 |                     current_residue = Residue::new(residue_name.clone(), residue_number.clone(), Vec::new());
[INFO] [stderr]    |                                                                          ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `residue_number`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `pdb`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "e861bb1a5645d45965bc7fffe0ff2dea55d4d8b45fcd8393743077ee8bec6513"`
[INFO] running `"docker" "rm" "-f" "e861bb1a5645d45965bc7fffe0ff2dea55d4d8b45fcd8393743077ee8bec6513"`
[INFO] [stdout] e861bb1a5645d45965bc7fffe0ff2dea55d4d8b45fcd8393743077ee8bec6513