[INFO] updating cached repository brettmcintosh/spellcheck
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/brettmcintosh/spellcheck
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/brettmcintosh/spellcheck" "work/ex/clippy-test-run/sources/stable/gh/brettmcintosh/spellcheck"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brettmcintosh/spellcheck'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/brettmcintosh/spellcheck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettmcintosh/spellcheck"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettmcintosh/spellcheck'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d3ca69bbe441a84e1b5bd828bed9afd658a4e4ff
[INFO] sha for GitHub repo brettmcintosh/spellcheck: d3ca69bbe441a84e1b5bd828bed9afd658a4e4ff
[INFO] validating manifest of brettmcintosh/spellcheck on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of brettmcintosh/spellcheck on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing brettmcintosh/spellcheck
[INFO] finished frobbing brettmcintosh/spellcheck
[INFO] frobbed toml for brettmcintosh/spellcheck written to work/ex/clippy-test-run/sources/stable/gh/brettmcintosh/spellcheck/Cargo.toml
[INFO] started frobbing brettmcintosh/spellcheck
[INFO] finished frobbing brettmcintosh/spellcheck
[INFO] frobbed toml for brettmcintosh/spellcheck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettmcintosh/spellcheck/Cargo.toml
[INFO] crate brettmcintosh/spellcheck has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting brettmcintosh/spellcheck against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettmcintosh/spellcheck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a81b03d47bc59b83cfcf78289721ed8042fe7c1440886fb3c25fd1d0cc90aa5c
[INFO] running `"docker" "start" "-a" "a81b03d47bc59b83cfcf78289721ed8042fe7c1440886fb3c25fd1d0cc90aa5c"`
[INFO] [stderr]     Checking trie v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/data_structures.rs:18:34
[INFO] [stderr]    |
[INFO] [stderr] 18 |         self.children.entry(chr).or_insert(TrieNode::new())
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(TrieNode::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/data_structures.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 | /         match self.get_prefix_node(&prefix) {
[INFO] [stderr] 45 | |             Some(v) => {
[INFO] [stderr] 46 | |                 if v.is_word {
[INFO] [stderr] 47 | |                     words.push(prefix.clone());
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |             None => ()
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 44 |         if let Some(v) = self.get_prefix_node(&prefix) {
[INFO] [stderr] 45 |     if v.is_word {
[INFO] [stderr] 46 |         words.push(prefix.clone());
[INFO] [stderr] 47 |     }
[INFO] [stderr] 48 |     let mut more_words: Vec<String> = v.children.keys()
[INFO] [stderr] 49 |         .map(|char| {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `spellchecker::SpellChecker`
[INFO] [stderr]   --> src/spellchecker.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> SpellChecker {
[INFO] [stderr] 13 | |         let file = File::open(DICT_FILE).expect("Could not read dictionary file");
[INFO] [stderr] 14 | |         SpellChecker { word_set: Trie::from(file) }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | impl Default for spellchecker::SpellChecker {
[INFO] [stderr] 12 |     fn default() -> Self {
[INFO] [stderr] 13 |         Self::new()
[INFO] [stderr] 14 |     }
[INFO] [stderr] 15 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/spellchecker.rs:17:20
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn is_word(&mut self, word: &str) -> bool {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/spellchecker.rs:42:41
[INFO] [stderr]    |
[INFO] [stderr] 42 |         let mut all_recs: Vec<String> = (1..word.len()+1)
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^ help: use: `(1..=word.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/data_structures.rs:18:34
[INFO] [stderr]    |
[INFO] [stderr] 18 |         self.children.entry(chr).or_insert(TrieNode::new())
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(TrieNode::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/data_structures.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 | /         match self.get_prefix_node(&prefix) {
[INFO] [stderr] 45 | |             Some(v) => {
[INFO] [stderr] 46 | |                 if v.is_word {
[INFO] [stderr] 47 | |                     words.push(prefix.clone());
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |             None => ()
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 44 |         if let Some(v) = self.get_prefix_node(&prefix) {
[INFO] [stderr] 45 |     if v.is_word {
[INFO] [stderr] 46 |         words.push(prefix.clone());
[INFO] [stderr] 47 |     }
[INFO] [stderr] 48 |     let mut more_words: Vec<String> = v.children.keys()
[INFO] [stderr] 49 |         .map(|char| {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `spellchecker::SpellChecker`
[INFO] [stderr]   --> src/spellchecker.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> SpellChecker {
[INFO] [stderr] 13 | |         let file = File::open(DICT_FILE).expect("Could not read dictionary file");
[INFO] [stderr] 14 | |         SpellChecker { word_set: Trie::from(file) }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | impl Default for spellchecker::SpellChecker {
[INFO] [stderr] 12 |     fn default() -> Self {
[INFO] [stderr] 13 |         Self::new()
[INFO] [stderr] 14 |     }
[INFO] [stderr] 15 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/spellchecker.rs:17:20
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn is_word(&mut self, word: &str) -> bool {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/spellchecker.rs:42:41
[INFO] [stderr]    |
[INFO] [stderr] 42 |         let mut all_recs: Vec<String> = (1..word.len()+1)
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^ help: use: `(1..=word.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:16:16
[INFO] [stderr]    |
[INFO] [stderr] 16 |             if recs.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!recs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:16:16
[INFO] [stderr]    |
[INFO] [stderr] 16 |             if recs.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!recs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.03s
[INFO] running `"docker" "inspect" "a81b03d47bc59b83cfcf78289721ed8042fe7c1440886fb3c25fd1d0cc90aa5c"`
[INFO] running `"docker" "rm" "-f" "a81b03d47bc59b83cfcf78289721ed8042fe7c1440886fb3c25fd1d0cc90aa5c"`
[INFO] [stdout] a81b03d47bc59b83cfcf78289721ed8042fe7c1440886fb3c25fd1d0cc90aa5c