[INFO] updating cached repository brettcannon/flatten_filenames [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brettcannon/flatten_filenames [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brettcannon/flatten_filenames" "work/ex/clippy-test-run/sources/stable/gh/brettcannon/flatten_filenames"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brettcannon/flatten_filenames'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brettcannon/flatten_filenames" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettcannon/flatten_filenames"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettcannon/flatten_filenames'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 97f728ea37f21c5005a04e02f46a292a46459445 [INFO] sha for GitHub repo brettcannon/flatten_filenames: 97f728ea37f21c5005a04e02f46a292a46459445 [INFO] validating manifest of brettcannon/flatten_filenames on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brettcannon/flatten_filenames on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brettcannon/flatten_filenames [INFO] finished frobbing brettcannon/flatten_filenames [INFO] frobbed toml for brettcannon/flatten_filenames written to work/ex/clippy-test-run/sources/stable/gh/brettcannon/flatten_filenames/Cargo.toml [INFO] started frobbing brettcannon/flatten_filenames [INFO] finished frobbing brettcannon/flatten_filenames [INFO] frobbed toml for brettcannon/flatten_filenames written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettcannon/flatten_filenames/Cargo.toml [INFO] crate brettcannon/flatten_filenames has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brettcannon/flatten_filenames against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettcannon/flatten_filenames:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e6335843f8d4fab855abd80e59bd6ce47cf506c274fb13bb0dc907172ad21fa [INFO] running `"docker" "start" "-a" "6e6335843f8d4fab855abd80e59bd6ce47cf506c274fb13bb0dc907172ad21fa"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `flatten-filenames`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking flatten_filenames v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / if leading_char != '.' && leading_char != '_' { [INFO] [stderr] 37 | | true [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | false [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `leading_char != '.' && leading_char != '_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / let mut postfix = tail; [INFO] [stderr] 71 | | if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { [INFO] [stderr] 72 | | postfix = &tail[1..]; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let postfix = if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { &tail[1..] } else { tail };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"+"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:71:55 [INFO] [stderr] | [INFO] [stderr] 71 | if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / if leading_char != '.' && leading_char != '_' { [INFO] [stderr] 37 | | true [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | false [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `leading_char != '.' && leading_char != '_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / let mut postfix = tail; [INFO] [stderr] 71 | | if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { [INFO] [stderr] 72 | | postfix = &tail[1..]; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let postfix = if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { &tail[1..] } else { tail };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"+"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:71:55 [INFO] [stderr] | [INFO] [stderr] 71 | if tail[0..1] == "+".to_string() || tail[0..1] == "-".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "6e6335843f8d4fab855abd80e59bd6ce47cf506c274fb13bb0dc907172ad21fa"` [INFO] running `"docker" "rm" "-f" "6e6335843f8d4fab855abd80e59bd6ce47cf506c274fb13bb0dc907172ad21fa"` [INFO] [stdout] 6e6335843f8d4fab855abd80e59bd6ce47cf506c274fb13bb0dc907172ad21fa