[INFO] updating cached repository bradurani/rust-iterator-to-hash-map [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bradurani/rust-iterator-to-hash-map [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bradurani/rust-iterator-to-hash-map" "work/ex/clippy-test-run/sources/stable/gh/bradurani/rust-iterator-to-hash-map"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bradurani/rust-iterator-to-hash-map'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bradurani/rust-iterator-to-hash-map" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bradurani/rust-iterator-to-hash-map"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bradurani/rust-iterator-to-hash-map'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8f4e102e0aad3fa07b4ed8a1247d1a39983fbab2 [INFO] sha for GitHub repo bradurani/rust-iterator-to-hash-map: 8f4e102e0aad3fa07b4ed8a1247d1a39983fbab2 [INFO] validating manifest of bradurani/rust-iterator-to-hash-map on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bradurani/rust-iterator-to-hash-map on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bradurani/rust-iterator-to-hash-map [INFO] finished frobbing bradurani/rust-iterator-to-hash-map [INFO] frobbed toml for bradurani/rust-iterator-to-hash-map written to work/ex/clippy-test-run/sources/stable/gh/bradurani/rust-iterator-to-hash-map/Cargo.toml [INFO] started frobbing bradurani/rust-iterator-to-hash-map [INFO] finished frobbing bradurani/rust-iterator-to-hash-map [INFO] frobbed toml for bradurani/rust-iterator-to-hash-map written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bradurani/rust-iterator-to-hash-map/Cargo.toml [INFO] crate bradurani/rust-iterator-to-hash-map has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bradurani/rust-iterator-to-hash-map against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bradurani/rust-iterator-to-hash-map:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34b94d1b45d1c624fec153d4dd48952dbf0e3b6db4cac23aa2fbaf9c7901c728 [INFO] running `"docker" "start" "-a" "34b94d1b45d1c624fec153d4dd48952dbf0e3b6db4cac23aa2fbaf9c7901c728"` [INFO] [stderr] Checking iterator_to_hash_map v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/lib.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | i.first_name.to_string() + &" " + &i.last_name.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `" "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/lib.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(map.get(&1).unwrap(), hm.get(&1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/lib.rs:38:38 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(map.get(&1).unwrap(), hm.get(&1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `&hm[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/lib.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | assert_eq!(map.get(&2).unwrap(), hm.get(&2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/lib.rs:39:38 [INFO] [stderr] | [INFO] [stderr] 39 | assert_eq!(map.get(&2).unwrap(), hm.get(&2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `&hm[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "34b94d1b45d1c624fec153d4dd48952dbf0e3b6db4cac23aa2fbaf9c7901c728"` [INFO] running `"docker" "rm" "-f" "34b94d1b45d1c624fec153d4dd48952dbf0e3b6db4cac23aa2fbaf9c7901c728"` [INFO] [stdout] 34b94d1b45d1c624fec153d4dd48952dbf0e3b6db4cac23aa2fbaf9c7901c728