[INFO] updating cached repository bouncenow/rlox
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bouncenow/rlox
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bouncenow/rlox" "work/ex/clippy-test-run/sources/stable/gh/bouncenow/rlox"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bouncenow/rlox'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bouncenow/rlox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bouncenow/rlox"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bouncenow/rlox'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 263e1b2bbc960ec8014a508d7acd6b73f883a44c
[INFO] sha for GitHub repo bouncenow/rlox: 263e1b2bbc960ec8014a508d7acd6b73f883a44c
[INFO] validating manifest of bouncenow/rlox on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bouncenow/rlox on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bouncenow/rlox
[INFO] finished frobbing bouncenow/rlox
[INFO] frobbed toml for bouncenow/rlox written to work/ex/clippy-test-run/sources/stable/gh/bouncenow/rlox/Cargo.toml
[INFO] started frobbing bouncenow/rlox
[INFO] finished frobbing bouncenow/rlox
[INFO] frobbed toml for bouncenow/rlox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bouncenow/rlox/Cargo.toml
[INFO] crate bouncenow/rlox has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bouncenow/rlox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bouncenow/rlox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 549304c37ff6f974b799dffc33c3bbbd93b21d52d0347b2afab2728186e7dfbe
[INFO] running `"docker" "start" "-a" "549304c37ff6f974b799dffc33c3bbbd93b21d52d0347b2afab2728186e7dfbe"`
[INFO] [stderr]     Checking rlox v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scan.rs:289:9
[INFO] [stderr]     |
[INFO] [stderr] 289 |         return true
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse.rs:313:9
[INFO] [stderr]     |
[INFO] [stderr] 313 |         return Ok(expr);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(expr)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/interpreter.rs:190:24
[INFO] [stderr]     |
[INFO] [stderr] 190 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 191 | |                     if let Some(e) = else_branch {
[INFO] [stderr] 192 | |                         self.execute_single(&e)?;
[INFO] [stderr] 193 | |                     }
[INFO] [stderr] 194 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 } else if let Some(e) = else_branch {
[INFO] [stderr] 191 |     self.execute_single(&e)?;
[INFO] [stderr] 192 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/interpreter.rs:249:28
[INFO] [stderr]     |
[INFO] [stderr] 249 |             Stmt::Return { keyword: _, value } => {
[INFO] [stderr]     |                            ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Return { value, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/interpreter.rs:398:24
[INFO] [stderr]     |
[INFO] [stderr] 398 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 399 | |                     if !is_truthy(&left) {
[INFO] [stderr] 400 | |                         return Ok(left);
[INFO] [stderr] 401 | |                     }
[INFO] [stderr] 402 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 398 |                 } else if !is_truthy(&left) {
[INFO] [stderr] 399 |     return Ok(left);
[INFO] [stderr] 400 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/interpreter.rs:412:34
[INFO] [stderr]     |
[INFO] [stderr] 412 |             Expr::Call { callee, paren: _, arguments } => {
[INFO] [stderr]     |                                  ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `Call { callee, arguments, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/functions.rs:54:16
[INFO] [stderr]    |
[INFO] [stderr] 54 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 55 | |             if let Err(_) = result {
[INFO] [stderr] 56 | |                 result
[INFO] [stderr] 57 | |             } else {
[INFO] [stderr] 58 | |                 Ok(self.closure.borrow().get_at(0, "this").unwrap().unwrap())
[INFO] [stderr] 59 | |             }
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 54 |         } else if let Err(_) = result {
[INFO] [stderr] 55 |     result
[INFO] [stderr] 56 | } else {
[INFO] [stderr] 57 |     Ok(self.closure.borrow().get_at(0, "this").unwrap().unwrap())
[INFO] [stderr] 58 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scan.rs:289:9
[INFO] [stderr]     |
[INFO] [stderr] 289 |         return true
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse.rs:313:9
[INFO] [stderr]     |
[INFO] [stderr] 313 |         return Ok(expr);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(expr)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/interpreter.rs:190:24
[INFO] [stderr]     |
[INFO] [stderr] 190 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 191 | |                     if let Some(e) = else_branch {
[INFO] [stderr] 192 | |                         self.execute_single(&e)?;
[INFO] [stderr] 193 | |                     }
[INFO] [stderr] 194 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 } else if let Some(e) = else_branch {
[INFO] [stderr] 191 |     self.execute_single(&e)?;
[INFO] [stderr] 192 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/interpreter.rs:249:28
[INFO] [stderr]     |
[INFO] [stderr] 249 |             Stmt::Return { keyword: _, value } => {
[INFO] [stderr]     |                            ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Return { value, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/interpreter.rs:398:24
[INFO] [stderr]     |
[INFO] [stderr] 398 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 399 | |                     if !is_truthy(&left) {
[INFO] [stderr] 400 | |                         return Ok(left);
[INFO] [stderr] 401 | |                     }
[INFO] [stderr] 402 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 398 |                 } else if !is_truthy(&left) {
[INFO] [stderr] 399 |     return Ok(left);
[INFO] [stderr] 400 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/interpreter.rs:412:34
[INFO] [stderr]     |
[INFO] [stderr] 412 |             Expr::Call { callee, paren: _, arguments } => {
[INFO] [stderr]     |                                  ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `Call { callee, arguments, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/functions.rs:54:16
[INFO] [stderr]    |
[INFO] [stderr] 54 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 55 | |             if let Err(_) = result {
[INFO] [stderr] 56 | |                 result
[INFO] [stderr] 57 | |             } else {
[INFO] [stderr] 58 | |                 Ok(self.closure.borrow().get_at(0, "this").unwrap().unwrap())
[INFO] [stderr] 59 | |             }
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 54 |         } else if let Err(_) = result {
[INFO] [stderr] 55 |     result
[INFO] [stderr] 56 | } else {
[INFO] [stderr] 57 |     Ok(self.closure.borrow().get_at(0, "this").unwrap().unwrap())
[INFO] [stderr] 58 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parse.rs:13:37
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn parse_for_expression(tokens: &Vec<Token>) -> Result<Expr, RloxError> {
[INFO] [stderr]    |                                     ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parse.rs:18:22
[INFO] [stderr]    |
[INFO] [stderr] 18 | pub fn parse(tokens: &Vec<Token>) -> Result<Vec<Stmt>, RloxError> {
[INFO] [stderr]    |                      ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parse.rs:28:20
[INFO] [stderr]    |
[INFO] [stderr] 28 |     fn new(tokens: &'a Vec<Token>) -> ParserState {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/parse.rs:60:16
[INFO] [stderr]    |
[INFO] [stderr] 60 |           if let Err(_) = &result {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 61 | |             self.synchronize();
[INFO] [stderr] 62 | |         }
[INFO] [stderr]    | |_________- help: try this: `if &result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::Interpreter`
[INFO] [stderr]    --> src/interpreter.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     pub fn new() -> Interpreter {
[INFO] [stderr] 129 | |         let mut global = Environment::new_global();
[INFO] [stderr] 130 | |         global.define("clock".to_string(), Some(ExprVal::Callable(Rc::new(Clock {}))));
[INFO] [stderr] 131 | |         let globals = Rc::new(RefCell::new(global));
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |         }
[INFO] [stderr] 137 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 127 | impl Default for interpreter::Interpreter {
[INFO] [stderr] 128 |     fn default() -> Self {
[INFO] [stderr] 129 |         Self::new()
[INFO] [stderr] 130 |     }
[INFO] [stderr] 131 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/interpreter.rs:262:21
[INFO] [stderr]     |
[INFO] [stderr] 262 |         statements: &Vec<Stmt>,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: change this to: `&[Stmt]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/interpreter.rs:270:20
[INFO] [stderr]     |
[INFO] [stderr] 270 |               if let Err(_) = &exec_res {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 271 | |                 self.current_env = previous_env;
[INFO] [stderr] 272 | |                 return exec_res;
[INFO] [stderr] 273 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if &exec_res.is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/interpreter.rs:517:5
[INFO] [stderr]     |
[INFO] [stderr] 517 | /     match val {
[INFO] [stderr] 518 | |         &ExprVal::Nil => false,
[INFO] [stderr] 519 | |         &ExprVal::Boolean(b) => b,
[INFO] [stderr] 520 | |         _ => true
[INFO] [stderr] 521 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 517 |     match *val {
[INFO] [stderr] 518 |         ExprVal::Nil => false,
[INFO] [stderr] 519 |         ExprVal::Boolean(b) => b,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/stmt.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     Var { name: Token, initializer: Option<Expr> },
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]   --> src/stmt.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     Var { name: Token, initializer: Option<Expr> },
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parse.rs:13:37
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn parse_for_expression(tokens: &Vec<Token>) -> Result<Expr, RloxError> {
[INFO] [stderr]    |                                     ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parse.rs:18:22
[INFO] [stderr]    |
[INFO] [stderr] 18 | pub fn parse(tokens: &Vec<Token>) -> Result<Vec<Stmt>, RloxError> {
[INFO] [stderr]    |                      ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parse.rs:28:20
[INFO] [stderr]    |
[INFO] [stderr] 28 |     fn new(tokens: &'a Vec<Token>) -> ParserState {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/functions.rs:55:20
[INFO] [stderr]    |
[INFO] [stderr] 55 |               if let Err(_) = result {
[INFO] [stderr]    |  _____________-      ^^^^^^
[INFO] [stderr] 56 | |                 result
[INFO] [stderr] 57 | |             } else {
[INFO] [stderr] 58 | |                 Ok(self.closure.borrow().get_at(0, "this").unwrap().unwrap())
[INFO] [stderr] 59 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/parse.rs:60:16
[INFO] [stderr]    |
[INFO] [stderr] 60 |           if let Err(_) = &result {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 61 | |             self.synchronize();
[INFO] [stderr] 62 | |         }
[INFO] [stderr]    | |_________- help: try this: `if &result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `resolver::Resolver`
[INFO] [stderr]   --> src/resolver.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     pub fn new() -> Resolver {
[INFO] [stderr] 31 | |         Resolver { scopes: Vec::new(), current_function_type: None, current_class_type: None }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/resolver.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |                 for ref mut method in methods {
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^    ------- help: try: `let method = &mut methods;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/resolver.rs:122:24
[INFO] [stderr]     |
[INFO] [stderr] 122 |                   if let None = self.current_function_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 123 | |                     return Err("Cannot return from top-level code".to_string());
[INFO] [stderr] 124 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.current_function_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/resolver.rs:181:24
[INFO] [stderr]     |
[INFO] [stderr] 181 |                   if let None = self.current_class_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 182 | |                     return Err("Cannot use this outside of the class".to_string());
[INFO] [stderr] 183 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.current_class_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/resolver.rs:235:24
[INFO] [stderr]     |
[INFO] [stderr] 235 |                   if let None = self.current_class_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 236 | |                     return Err("Cannot use outside of a class".to_string());
[INFO] [stderr] 237 | |                 } else if let Some(ClassType::Class) = self.current_class_type {
[INFO] [stderr] 238 | |                     return Err("Cannot use outside of a subclass".to_string());
[INFO] [stderr] 239 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.current_class_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/resolver.rs:286:9
[INFO] [stderr]     |
[INFO] [stderr] 286 | /         match self.scopes.last_mut() {
[INFO] [stderr] 287 | |             Some(scope) => {
[INFO] [stderr] 288 | |                 scope.insert(name.lexeme.clone(), true);
[INFO] [stderr] 289 | |             },
[INFO] [stderr] 290 | |             None => {}
[INFO] [stderr] 291 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 286 |         if let Some(scope) = self.scopes.last_mut() {
[INFO] [stderr] 287 |     scope.insert(name.lexeme.clone(), true);
[INFO] [stderr] 288 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::Interpreter`
[INFO] [stderr]    --> src/interpreter.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     pub fn new() -> Interpreter {
[INFO] [stderr] 129 | |         let mut global = Environment::new_global();
[INFO] [stderr] 130 | |         global.define("clock".to_string(), Some(ExprVal::Callable(Rc::new(Clock {}))));
[INFO] [stderr] 131 | |         let globals = Rc::new(RefCell::new(global));
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |         }
[INFO] [stderr] 137 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 127 | impl Default for interpreter::Interpreter {
[INFO] [stderr] 128 |     fn default() -> Self {
[INFO] [stderr] 129 |         Self::new()
[INFO] [stderr] 130 |     }
[INFO] [stderr] 131 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/interpreter.rs:262:21
[INFO] [stderr]     |
[INFO] [stderr] 262 |         statements: &Vec<Stmt>,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: change this to: `&[Stmt]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/interpreter.rs:270:20
[INFO] [stderr]     |
[INFO] [stderr] 270 |               if let Err(_) = &exec_res {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 271 | |                 self.current_env = previous_env;
[INFO] [stderr] 272 | |                 return exec_res;
[INFO] [stderr] 273 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if &exec_res.is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/interpreter.rs:517:5
[INFO] [stderr]     |
[INFO] [stderr] 517 | /     match val {
[INFO] [stderr] 518 | |         &ExprVal::Nil => false,
[INFO] [stderr] 519 | |         &ExprVal::Boolean(b) => b,
[INFO] [stderr] 520 | |         _ => true
[INFO] [stderr] 521 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 517 |     match *val {
[INFO] [stderr] 518 |         ExprVal::Nil => false,
[INFO] [stderr] 519 |         ExprVal::Boolean(b) => b,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/stmt.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     Var { name: Token, initializer: Option<Expr> },
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]   --> src/stmt.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     Var { name: Token, initializer: Option<Expr> },
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/functions.rs:55:20
[INFO] [stderr]    |
[INFO] [stderr] 55 |               if let Err(_) = result {
[INFO] [stderr]    |  _____________-      ^^^^^^
[INFO] [stderr] 56 | |                 result
[INFO] [stderr] 57 | |             } else {
[INFO] [stderr] 58 | |                 Ok(self.closure.borrow().get_at(0, "this").unwrap().unwrap())
[INFO] [stderr] 59 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `resolver::Resolver`
[INFO] [stderr]   --> src/resolver.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     pub fn new() -> Resolver {
[INFO] [stderr] 31 | |         Resolver { scopes: Vec::new(), current_function_type: None, current_class_type: None }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/resolver.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |                 for ref mut method in methods {
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^    ------- help: try: `let method = &mut methods;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/resolver.rs:122:24
[INFO] [stderr]     |
[INFO] [stderr] 122 |                   if let None = self.current_function_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 123 | |                     return Err("Cannot return from top-level code".to_string());
[INFO] [stderr] 124 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.current_function_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/resolver.rs:181:24
[INFO] [stderr]     |
[INFO] [stderr] 181 |                   if let None = self.current_class_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 182 | |                     return Err("Cannot use this outside of the class".to_string());
[INFO] [stderr] 183 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.current_class_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/resolver.rs:235:24
[INFO] [stderr]     |
[INFO] [stderr] 235 |                   if let None = self.current_class_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 236 | |                     return Err("Cannot use outside of a class".to_string());
[INFO] [stderr] 237 | |                 } else if let Some(ClassType::Class) = self.current_class_type {
[INFO] [stderr] 238 | |                     return Err("Cannot use outside of a subclass".to_string());
[INFO] [stderr] 239 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.current_class_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/resolver.rs:286:9
[INFO] [stderr]     |
[INFO] [stderr] 286 | /         match self.scopes.last_mut() {
[INFO] [stderr] 287 | |             Some(scope) => {
[INFO] [stderr] 288 | |                 scope.insert(name.lexeme.clone(), true);
[INFO] [stderr] 289 | |             },
[INFO] [stderr] 290 | |             None => {}
[INFO] [stderr] 291 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 286 |         if let Some(scope) = self.scopes.last_mut() {
[INFO] [stderr] 287 |     scope.insert(name.lexeme.clone(), true);
[INFO] [stderr] 288 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:35:38
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn parse_args_for_running_mode(args: &Vec<String>) -> Result<RunningMode, &'static str> {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:35:38
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn parse_args_for_running_mode(args: &Vec<String>) -> Result<RunningMode, &'static str> {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.16s
[INFO] running `"docker" "inspect" "549304c37ff6f974b799dffc33c3bbbd93b21d52d0347b2afab2728186e7dfbe"`
[INFO] running `"docker" "rm" "-f" "549304c37ff6f974b799dffc33c3bbbd93b21d52d0347b2afab2728186e7dfbe"`
[INFO] [stdout] 549304c37ff6f974b799dffc33c3bbbd93b21d52d0347b2afab2728186e7dfbe