[INFO] updating cached repository bombless/quote [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bombless/quote [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bombless/quote" "work/ex/clippy-test-run/sources/stable/gh/bombless/quote"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bombless/quote'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bombless/quote" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bombless/quote"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bombless/quote'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa5dead6da4c3cd2c4772e42f675b722c0edcf37 [INFO] sha for GitHub repo bombless/quote: fa5dead6da4c3cd2c4772e42f675b722c0edcf37 [INFO] validating manifest of bombless/quote on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bombless/quote on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bombless/quote [INFO] finished frobbing bombless/quote [INFO] frobbed toml for bombless/quote written to work/ex/clippy-test-run/sources/stable/gh/bombless/quote/Cargo.toml [INFO] started frobbing bombless/quote [INFO] finished frobbing bombless/quote [INFO] frobbed toml for bombless/quote written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bombless/quote/Cargo.toml [INFO] crate bombless/quote has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bombless/quote against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bombless/quote:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bacc69bf5adf89ef96ce8f198b415c91b65f2b5913b4fde241d7586b9479e702 [INFO] running `"docker" "start" "-a" "bacc69bf5adf89ef96ce8f198b415c91b65f2b5913b4fde241d7586b9479e702"` [INFO] [stderr] Checking quote v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 15 | | if ident == "quote" { [INFO] [stderr] 16 | | ret.push(Token::Quote) [INFO] [stderr] 17 | | } else { [INFO] [stderr] 18 | | ret.push(Token::Ident(::std::mem::replace(&mut ident, String::new()))) [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | } else if ident == "quote" { [INFO] [stderr] 15 | ret.push(Token::Quote) [INFO] [stderr] 16 | } else { [INFO] [stderr] 17 | ret.push(Token::Ident(::std::mem::replace(&mut ident, String::new()))) [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lexing` [INFO] [stderr] --> src/main.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn lexing>(src: T) -> Result, String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Token` [INFO] [stderr] --> src/main.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | enum Token { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / if let &Token::Ident(ref s) = self { [INFO] [stderr] 46 | | return s == rhs [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | if let Token::Ident(ref s) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 15 | | if ident == "quote" { [INFO] [stderr] 16 | | ret.push(Token::Quote) [INFO] [stderr] 17 | | } else { [INFO] [stderr] 18 | | ret.push(Token::Ident(::std::mem::replace(&mut ident, String::new()))) [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | } else if ident == "quote" { [INFO] [stderr] 15 | ret.push(Token::Quote) [INFO] [stderr] 16 | } else { [INFO] [stderr] 17 | ret.push(Token::Ident(::std::mem::replace(&mut ident, String::new()))) [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / if let &Token::Ident(ref s) = self { [INFO] [stderr] 46 | | return s == rhs [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | if let Token::Ident(ref s) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "bacc69bf5adf89ef96ce8f198b415c91b65f2b5913b4fde241d7586b9479e702"` [INFO] running `"docker" "rm" "-f" "bacc69bf5adf89ef96ce8f198b415c91b65f2b5913b4fde241d7586b9479e702"` [INFO] [stdout] bacc69bf5adf89ef96ce8f198b415c91b65f2b5913b4fde241d7586b9479e702