[INFO] updating cached repository bokuweb/rust-wasm-game-of-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bokuweb/rust-wasm-game-of-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bokuweb/rust-wasm-game-of-life" "work/ex/clippy-test-run/sources/stable/gh/bokuweb/rust-wasm-game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bokuweb/rust-wasm-game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bokuweb/rust-wasm-game-of-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bokuweb/rust-wasm-game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bokuweb/rust-wasm-game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25680132b0204f11a7a229e2eadea2adcb66ac8a [INFO] sha for GitHub repo bokuweb/rust-wasm-game-of-life: 25680132b0204f11a7a229e2eadea2adcb66ac8a [INFO] validating manifest of bokuweb/rust-wasm-game-of-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bokuweb/rust-wasm-game-of-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bokuweb/rust-wasm-game-of-life [INFO] finished frobbing bokuweb/rust-wasm-game-of-life [INFO] frobbed toml for bokuweb/rust-wasm-game-of-life written to work/ex/clippy-test-run/sources/stable/gh/bokuweb/rust-wasm-game-of-life/Cargo.toml [INFO] started frobbing bokuweb/rust-wasm-game-of-life [INFO] finished frobbing bokuweb/rust-wasm-game-of-life [INFO] frobbed toml for bokuweb/rust-wasm-game-of-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bokuweb/rust-wasm-game-of-life/Cargo.toml [INFO] crate bokuweb/rust-wasm-game-of-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bokuweb/rust-wasm-game-of-life against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bokuweb/rust-wasm-game-of-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c0bde9213f7e12ff67ccec8dd87dea25e4e7cc842e5d87e283916c2d5ef1cbd2 [INFO] running `"docker" "start" "-a" "c0bde9213f7e12ff67ccec8dd87dea25e4e7cc842e5d87e283916c2d5ef1cbd2"` [INFO] [stderr] Checking rust-wasm-start v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | fn next_row(&self, row: &Vec, y: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/game.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / .collect::>() [INFO] [stderr] 44 | | .len(); [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/game.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / (0..row_size) [INFO] [stderr] 58 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..row_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/game.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | match self.field.iter().nth(row as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/game.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | match r.iter().nth(column as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | fn next_row(&self, row: &Vec, y: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:10:68 [INFO] [stderr] | [INFO] [stderr] 10 | let buf: &mut [bool] = unsafe { std::slice::from_raw_parts_mut(ptr, len) }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] --> src/game.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / .collect::>() [INFO] [stderr] 44 | | .len(); [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/game.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / (0..row_size) [INFO] [stderr] 58 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..row_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/game.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | match self.field.iter().nth(row as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/game.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | match r.iter().nth(column as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:10:68 [INFO] [stderr] | [INFO] [stderr] 10 | let buf: &mut [bool] = unsafe { std::slice::from_raw_parts_mut(ptr, len) }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-wasm-start`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-wasm-start`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c0bde9213f7e12ff67ccec8dd87dea25e4e7cc842e5d87e283916c2d5ef1cbd2"` [INFO] running `"docker" "rm" "-f" "c0bde9213f7e12ff67ccec8dd87dea25e4e7cc842e5d87e283916c2d5ef1cbd2"` [INFO] [stdout] c0bde9213f7e12ff67ccec8dd87dea25e4e7cc842e5d87e283916c2d5ef1cbd2