[INFO] updating cached repository bmpotter13/random_password [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bmpotter13/random_password [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bmpotter13/random_password" "work/ex/clippy-test-run/sources/stable/gh/bmpotter13/random_password"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bmpotter13/random_password'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bmpotter13/random_password" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bmpotter13/random_password"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bmpotter13/random_password'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2cc355729793310317251dc1bb507dd925f95790 [INFO] sha for GitHub repo bmpotter13/random_password: 2cc355729793310317251dc1bb507dd925f95790 [INFO] validating manifest of bmpotter13/random_password on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bmpotter13/random_password on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bmpotter13/random_password [INFO] finished frobbing bmpotter13/random_password [INFO] frobbed toml for bmpotter13/random_password written to work/ex/clippy-test-run/sources/stable/gh/bmpotter13/random_password/Cargo.toml [INFO] started frobbing bmpotter13/random_password [INFO] finished frobbing bmpotter13/random_password [INFO] frobbed toml for bmpotter13/random_password written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bmpotter13/random_password/Cargo.toml [INFO] crate bmpotter13/random_password has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bmpotter13/random_password against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bmpotter13/random_password:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51e39da3583e0107fa2c5d8fb2649a53a4800e791d3528d7f676a7d66106acae [INFO] running `"docker" "start" "-a" "51e39da3583e0107fa2c5d8fb2649a53a4800e791d3528d7f676a7d66106acae"` [INFO] [stderr] Checking random_password v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | const DICTIONARY: &'static str = include_str!("../dictionary.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | fn make_password(conf: Config) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | const DICTIONARY: &'static str = include_str!("../dictionary.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | fn make_password(conf: Config) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.45s [INFO] running `"docker" "inspect" "51e39da3583e0107fa2c5d8fb2649a53a4800e791d3528d7f676a7d66106acae"` [INFO] running `"docker" "rm" "-f" "51e39da3583e0107fa2c5d8fb2649a53a4800e791d3528d7f676a7d66106acae"` [INFO] [stdout] 51e39da3583e0107fa2c5d8fb2649a53a4800e791d3528d7f676a7d66106acae