[INFO] updating cached repository blombern/brojure [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/blombern/brojure [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/blombern/brojure" "work/ex/clippy-test-run/sources/stable/gh/blombern/brojure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blombern/brojure'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/blombern/brojure" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blombern/brojure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blombern/brojure'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e3e2637e8d584068d87fcef9c68b7c490c660fa [INFO] sha for GitHub repo blombern/brojure: 8e3e2637e8d584068d87fcef9c68b7c490c660fa [INFO] validating manifest of blombern/brojure on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blombern/brojure on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blombern/brojure [INFO] finished frobbing blombern/brojure [INFO] frobbed toml for blombern/brojure written to work/ex/clippy-test-run/sources/stable/gh/blombern/brojure/Cargo.toml [INFO] started frobbing blombern/brojure [INFO] finished frobbing blombern/brojure [INFO] frobbed toml for blombern/brojure written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blombern/brojure/Cargo.toml [INFO] crate blombern/brojure has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blombern/brojure against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blombern/brojure:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be3e8974b18738b1e4e90aad3453c760ccbd0bbb306d855fcdc60511feb9b50c [INFO] running `"docker" "start" "-a" "be3e8974b18738b1e4e90aad3453c760ccbd0bbb306d855fcdc60511feb9b50c"` [INFO] [stderr] Checking brojure v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/node.rs:39:49 [INFO] [stderr] | [INFO] [stderr] 39 | &Nil => write!(f, "{}", "nil"), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/eval.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | println!("{}", "Bye!"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/node.rs:39:49 [INFO] [stderr] | [INFO] [stderr] 39 | &Nil => write!(f, "{}", "nil"), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/eval.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | println!("{}", "Bye!"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | return Error("Couldn't parse") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Couldn't parse")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | _ => return Error("Couldn't invoke"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Couldn't invoke")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:53:41 [INFO] [stderr] | [INFO] [stderr] 53 | None => return Error("Couldn't resolve symbol"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Couldn't resolve symbol")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:357:14 [INFO] [stderr] | [INFO] [stderr] 357 | _ => return Error("Expected numbers as arguments to range"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Expected numbers as arguments to range")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | return Error("Couldn't parse") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Couldn't parse")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | _ => return Error("Couldn't invoke"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Couldn't invoke")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:53:41 [INFO] [stderr] | [INFO] [stderr] 53 | None => return Error("Couldn't resolve symbol"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Couldn't resolve symbol")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:357:14 [INFO] [stderr] | [INFO] [stderr] 357 | _ => return Error("Expected numbers as arguments to range"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error("Expected numbers as arguments to range")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/node.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &Int(n) => write!(f, "{}", n), [INFO] [stderr] 23 | | &Float(n) => write!(f, "{}", n), [INFO] [stderr] 24 | | &Str(ref s) => write!(f, "\"{}\"", s), [INFO] [stderr] ... | [INFO] [stderr] 42 | | &Error(ref s) => write!(f, "Error: {}", s), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | Int(n) => write!(f, "{}", n), [INFO] [stderr] 23 | Float(n) => write!(f, "{}", n), [INFO] [stderr] 24 | Str(ref s) => write!(f, "\"{}\"", s), [INFO] [stderr] 25 | Symbol(ref s) => write!(f, "{}", s), [INFO] [stderr] 26 | Bool(b) => write!(f, "{}", b), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:16:8 [INFO] [stderr] | [INFO] [stderr] 16 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:49:32 [INFO] [stderr] | [INFO] [stderr] 49 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:104:39 [INFO] [stderr] | [INFO] [stderr] 104 | let txt = token.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 104 | let txt = &(*token).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 104 | let txt = &str::clone(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:112:37 [INFO] [stderr] | [INFO] [stderr] 112 | Str(String::from(txt)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `txt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match node { [INFO] [stderr] 9 | | &mut List(ref mut args) => { [INFO] [stderr] 10 | | let operator = args.remove(0); [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 87 | | _ => node.to_owned(), [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *node { [INFO] [stderr] 9 | List(ref mut args) => { [INFO] [stderr] 10 | let operator = args.remove(0); [INFO] [stderr] 11 | [INFO] [stderr] 12 | match operator { [INFO] [stderr] 13 | Symbol(s) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/eval.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | (Int(n1), Int(n2)) => Bool(n1 > n2 || n1 == n2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `n1 >= n2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/eval.rs:166:36 [INFO] [stderr] | [INFO] [stderr] 166 | (Int(n1), Int(n2)) => Bool(n1 < n2 || n1 == n2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `n1 <= n2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eval.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | let mut expr2 = if args.len() > 0 { args.remove(0) } else { Nil }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eval.rs:185:8 [INFO] [stderr] | [INFO] [stderr] 185 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eval.rs:201:8 [INFO] [stderr] | [INFO] [stderr] 201 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | / match n { [INFO] [stderr] 231 | | &Symbol(ref s) => s.to_owned(), [INFO] [stderr] 232 | | _ => panic!("Expected symbols as function parameters"), [INFO] [stderr] 233 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 230 | match *n { [INFO] [stderr] 231 | Symbol(ref s) => s.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | v.get(i as usize).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v[i as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:286:26 [INFO] [stderr] | [INFO] [stderr] 286 | let symbol_str = match bindings.get(i).unwrap() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 287 | | &Symbol(ref s) => s.to_owned(), [INFO] [stderr] 288 | | _ => return Error("Expected odd items in binding vector to be symbols"), [INFO] [stderr] 289 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 286 | let symbol_str = match *bindings.get(i).unwrap() { [INFO] [stderr] 287 | Symbol(ref s) => s.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:286:32 [INFO] [stderr] | [INFO] [stderr] 286 | let symbol_str = match bindings.get(i).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bindings[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:290:24 [INFO] [stderr] | [INFO] [stderr] 290 | let val_node = bindings.get(i + 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bindings[i + 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:318:22 [INFO] [stderr] | [INFO] [stderr] 318 | let symbol_str = match binding.get(0).unwrap() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 319 | | &Symbol(ref s) => s.to_owned(), [INFO] [stderr] 320 | | _ => return Error("Expected first item in binding vector to be a symbol"), [INFO] [stderr] 321 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 318 | let symbol_str = match *binding.get(0).unwrap() { [INFO] [stderr] 319 | Symbol(ref s) => s.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:318:28 [INFO] [stderr] | [INFO] [stderr] 318 | let symbol_str = match binding.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&binding[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:323:39 [INFO] [stderr] | [INFO] [stderr] 323 | let binding_vec = match eval(&mut binding.get(1).unwrap().clone(), env) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&binding[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/eval.rs:354:38 [INFO] [stderr] | [INFO] [stderr] 354 | let nodes = (n1..n2).map(|n| Int(n)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Int` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `brojure`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/node.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &Int(n) => write!(f, "{}", n), [INFO] [stderr] 23 | | &Float(n) => write!(f, "{}", n), [INFO] [stderr] 24 | | &Str(ref s) => write!(f, "\"{}\"", s), [INFO] [stderr] ... | [INFO] [stderr] 42 | | &Error(ref s) => write!(f, "Error: {}", s), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | Int(n) => write!(f, "{}", n), [INFO] [stderr] 23 | Float(n) => write!(f, "{}", n), [INFO] [stderr] 24 | Str(ref s) => write!(f, "\"{}\"", s), [INFO] [stderr] 25 | Symbol(ref s) => write!(f, "{}", s), [INFO] [stderr] 26 | Bool(b) => write!(f, "{}", b), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:16:8 [INFO] [stderr] | [INFO] [stderr] 16 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:49:32 [INFO] [stderr] | [INFO] [stderr] 49 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:104:39 [INFO] [stderr] | [INFO] [stderr] 104 | let txt = token.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 104 | let txt = &(*token).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 104 | let txt = &str::clone(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:112:37 [INFO] [stderr] | [INFO] [stderr] 112 | Str(String::from(txt)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `txt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match node { [INFO] [stderr] 9 | | &mut List(ref mut args) => { [INFO] [stderr] 10 | | let operator = args.remove(0); [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 87 | | _ => node.to_owned(), [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *node { [INFO] [stderr] 9 | List(ref mut args) => { [INFO] [stderr] 10 | let operator = args.remove(0); [INFO] [stderr] 11 | [INFO] [stderr] 12 | match operator { [INFO] [stderr] 13 | Symbol(s) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/eval.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | (Int(n1), Int(n2)) => Bool(n1 > n2 || n1 == n2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `n1 >= n2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/eval.rs:166:36 [INFO] [stderr] | [INFO] [stderr] 166 | (Int(n1), Int(n2)) => Bool(n1 < n2 || n1 == n2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `n1 <= n2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eval.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | let mut expr2 = if args.len() > 0 { args.remove(0) } else { Nil }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eval.rs:185:8 [INFO] [stderr] | [INFO] [stderr] 185 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eval.rs:201:8 [INFO] [stderr] | [INFO] [stderr] 201 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | / match n { [INFO] [stderr] 231 | | &Symbol(ref s) => s.to_owned(), [INFO] [stderr] 232 | | _ => panic!("Expected symbols as function parameters"), [INFO] [stderr] 233 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 230 | match *n { [INFO] [stderr] 231 | Symbol(ref s) => s.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | v.get(i as usize).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v[i as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:286:26 [INFO] [stderr] | [INFO] [stderr] 286 | let symbol_str = match bindings.get(i).unwrap() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 287 | | &Symbol(ref s) => s.to_owned(), [INFO] [stderr] 288 | | _ => return Error("Expected odd items in binding vector to be symbols"), [INFO] [stderr] 289 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 286 | let symbol_str = match *bindings.get(i).unwrap() { [INFO] [stderr] 287 | Symbol(ref s) => s.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:286:32 [INFO] [stderr] | [INFO] [stderr] 286 | let symbol_str = match bindings.get(i).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bindings[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:290:24 [INFO] [stderr] | [INFO] [stderr] 290 | let val_node = bindings.get(i + 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bindings[i + 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:318:22 [INFO] [stderr] | [INFO] [stderr] 318 | let symbol_str = match binding.get(0).unwrap() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 319 | | &Symbol(ref s) => s.to_owned(), [INFO] [stderr] 320 | | _ => return Error("Expected first item in binding vector to be a symbol"), [INFO] [stderr] 321 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 318 | let symbol_str = match *binding.get(0).unwrap() { [INFO] [stderr] 319 | Symbol(ref s) => s.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:318:28 [INFO] [stderr] | [INFO] [stderr] 318 | let symbol_str = match binding.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&binding[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:323:39 [INFO] [stderr] | [INFO] [stderr] 323 | let binding_vec = match eval(&mut binding.get(1).unwrap().clone(), env) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&binding[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/eval.rs:354:38 [INFO] [stderr] | [INFO] [stderr] 354 | let nodes = (n1..n2).map(|n| Int(n)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Int` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `brojure`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "be3e8974b18738b1e4e90aad3453c760ccbd0bbb306d855fcdc60511feb9b50c"` [INFO] running `"docker" "rm" "-f" "be3e8974b18738b1e4e90aad3453c760ccbd0bbb306d855fcdc60511feb9b50c"` [INFO] [stdout] be3e8974b18738b1e4e90aad3453c760ccbd0bbb306d855fcdc60511feb9b50c