[INFO] updating cached repository blogscot/the-darkest-dungeon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/blogscot/the-darkest-dungeon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/blogscot/the-darkest-dungeon" "work/ex/clippy-test-run/sources/stable/gh/blogscot/the-darkest-dungeon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blogscot/the-darkest-dungeon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/blogscot/the-darkest-dungeon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blogscot/the-darkest-dungeon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blogscot/the-darkest-dungeon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37dc681c16022d4dc11f471c8ba36d2e8842671a [INFO] sha for GitHub repo blogscot/the-darkest-dungeon: 37dc681c16022d4dc11f471c8ba36d2e8842671a [INFO] validating manifest of blogscot/the-darkest-dungeon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blogscot/the-darkest-dungeon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blogscot/the-darkest-dungeon [INFO] finished frobbing blogscot/the-darkest-dungeon [INFO] frobbed toml for blogscot/the-darkest-dungeon written to work/ex/clippy-test-run/sources/stable/gh/blogscot/the-darkest-dungeon/Cargo.toml [INFO] started frobbing blogscot/the-darkest-dungeon [INFO] finished frobbing blogscot/the-darkest-dungeon [INFO] frobbed toml for blogscot/the-darkest-dungeon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blogscot/the-darkest-dungeon/Cargo.toml [INFO] crate blogscot/the-darkest-dungeon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blogscot/the-darkest-dungeon against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blogscot/the-darkest-dungeon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6291626c128b2c01e0cd0eed9a066d81816edab0af4f4f7fc360689c9fc7465a [INFO] running `"docker" "start" "-a" "6291626c128b2c01e0cd0eed9a066d81816edab0af4f4f7fc360689c9fc7465a"` [INFO] [stderr] Checking hw05 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:67:42 [INFO] [stderr] | [INFO] [stderr] 67 | Curio::Chest(_) => write!(f, "{}", "a chest"), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:68:46 [INFO] [stderr] | [INFO] [stderr] 68 | Curio::SpikeTrap(_) => write!(f, "{}", "a spiketrap"), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | Curio::Food(_) => write!(f, "{}", "some food"), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:70:50 [INFO] [stderr] | [INFO] [stderr] 70 | Curio::IronMaiden(_, _) => write!(f, "{}", "an iron maiden"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:71:53 [INFO] [stderr] | [INFO] [stderr] 71 | Curio::FallenAdventurer(_) => write!(f, "{}", "a fallen adventurer"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/game/player.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | write!(f, "You have {} HP and {} gold.\n", self.hp, self.gold) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:67:42 [INFO] [stderr] | [INFO] [stderr] 67 | Curio::Chest(_) => write!(f, "{}", "a chest"), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:68:46 [INFO] [stderr] | [INFO] [stderr] 68 | Curio::SpikeTrap(_) => write!(f, "{}", "a spiketrap"), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | Curio::Food(_) => write!(f, "{}", "some food"), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:70:50 [INFO] [stderr] | [INFO] [stderr] 70 | Curio::IronMaiden(_, _) => write!(f, "{}", "an iron maiden"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/curio.rs:71:53 [INFO] [stderr] | [INFO] [stderr] 71 | Curio::FallenAdventurer(_) => write!(f, "{}", "a fallen adventurer"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/game/player.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | write!(f, "You have {} HP and {} gold.\n", self.hp, self.gold) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/game/player.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/game/room.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | File::open(&filename).expect(&format!("Unable to open file {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open file {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/game/player.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/game/room.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | File::open(&filename).expect(&format!("Unable to open file {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open file {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "6291626c128b2c01e0cd0eed9a066d81816edab0af4f4f7fc360689c9fc7465a"` [INFO] running `"docker" "rm" "-f" "6291626c128b2c01e0cd0eed9a066d81816edab0af4f4f7fc360689c9fc7465a"` [INFO] [stdout] 6291626c128b2c01e0cd0eed9a066d81816edab0af4f4f7fc360689c9fc7465a