[INFO] updating cached repository blabaere/rust-closure-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/blabaere/rust-closure-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/blabaere/rust-closure-playground" "work/ex/clippy-test-run/sources/stable/gh/blabaere/rust-closure-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blabaere/rust-closure-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/blabaere/rust-closure-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blabaere/rust-closure-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blabaere/rust-closure-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d2c2dd52aad5a8cb531fa15744d21e873225370e [INFO] sha for GitHub repo blabaere/rust-closure-playground: d2c2dd52aad5a8cb531fa15744d21e873225370e [INFO] validating manifest of blabaere/rust-closure-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blabaere/rust-closure-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blabaere/rust-closure-playground [INFO] finished frobbing blabaere/rust-closure-playground [INFO] frobbed toml for blabaere/rust-closure-playground written to work/ex/clippy-test-run/sources/stable/gh/blabaere/rust-closure-playground/Cargo.toml [INFO] started frobbing blabaere/rust-closure-playground [INFO] finished frobbing blabaere/rust-closure-playground [INFO] frobbed toml for blabaere/rust-closure-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blabaere/rust-closure-playground/Cargo.toml [INFO] crate blabaere/rust-closure-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blabaere/rust-closure-playground against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blabaere/rust-closure-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4cc1e86cb7b79e480bba03426db7876514ddbac8e6d301ac67d5341a4000e31c [INFO] running `"docker" "start" "-a" "4cc1e86cb7b79e480bba03426db7876514ddbac8e6d301ac67d5341a4000e31c"` [INFO] [stderr] Checking math-ce2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping elements of `values` manually [INFO] [stderr] --> src/main.rs:25:2 [INFO] [stderr] | [INFO] [stderr] 25 | let temp = values[i]; [INFO] [stderr] | _____^ [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | values[i] = values[j]; [INFO] [stderr] 28 | | values[j] = temp; [INFO] [stderr] | |____________________^ help: try: `values.swap(i, j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `values` manually [INFO] [stderr] --> src/main.rs:25:2 [INFO] [stderr] | [INFO] [stderr] 25 | let temp = values[i]; [INFO] [stderr] | _____^ [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | values[i] = values[j]; [INFO] [stderr] 28 | | values[j] = temp; [INFO] [stderr] | |____________________^ help: try: `values.swap(i, j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:104:45 [INFO] [stderr] | [INFO] [stderr] 104 | permute_and_check(&mut int_values, &|xs| { evaluate(xs, &FLOAT_CONSTANTS) == 66f64 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(evaluate(xs, &FLOAT_CONSTANTS) - 66f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:104:45 [INFO] [stderr] | [INFO] [stderr] 104 | permute_and_check(&mut int_values, &|xs| { evaluate(xs, &FLOAT_CONSTANTS) == 66f64 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:104:45 [INFO] [stderr] | [INFO] [stderr] 104 | permute_and_check(&mut int_values, &|xs| { evaluate(xs, &FLOAT_CONSTANTS) == 66f64 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(evaluate(xs, &FLOAT_CONSTANTS) - 66f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:104:45 [INFO] [stderr] | [INFO] [stderr] 104 | permute_and_check(&mut int_values, &|xs| { evaluate(xs, &FLOAT_CONSTANTS) == 66f64 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `math-ce2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `math-ce2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4cc1e86cb7b79e480bba03426db7876514ddbac8e6d301ac67d5341a4000e31c"` [INFO] running `"docker" "rm" "-f" "4cc1e86cb7b79e480bba03426db7876514ddbac8e6d301ac67d5341a4000e31c"` [INFO] [stdout] 4cc1e86cb7b79e480bba03426db7876514ddbac8e6d301ac67d5341a4000e31c