[INFO] updating cached repository bjrnt/fractals [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bjrnt/fractals [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bjrnt/fractals" "work/ex/clippy-test-run/sources/stable/gh/bjrnt/fractals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bjrnt/fractals'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bjrnt/fractals" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjrnt/fractals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjrnt/fractals'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f1752cd122c5ecdbc385d6920442e8331098071 [INFO] sha for GitHub repo bjrnt/fractals: 2f1752cd122c5ecdbc385d6920442e8331098071 [INFO] validating manifest of bjrnt/fractals on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bjrnt/fractals on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bjrnt/fractals [INFO] finished frobbing bjrnt/fractals [INFO] frobbed toml for bjrnt/fractals written to work/ex/clippy-test-run/sources/stable/gh/bjrnt/fractals/Cargo.toml [INFO] started frobbing bjrnt/fractals [INFO] finished frobbing bjrnt/fractals [INFO] frobbed toml for bjrnt/fractals written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjrnt/fractals/Cargo.toml [INFO] crate bjrnt/fractals has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bjrnt/fractals against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjrnt/fractals:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4fd7606c22f4489a1d6479768bd3148bfeccdafd7e7dae798e15a75c45e658fe [INFO] running `"docker" "start" "-a" "4fd7606c22f4489a1d6479768bd3148bfeccdafd7e7dae798e15a75c45e658fe"` [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking image v0.12.2 [INFO] [stderr] Checking fractals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | side_length: side_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `side_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | zoom: zoom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zoom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | translation: translation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `translation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | easing: easing [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `easing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | side_length: side_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `side_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | zoom: zoom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zoom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | translation: translation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `translation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | easing: easing [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `easing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mandelbrot.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return i as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `i as u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | const OUTPUT_DIRECTORY: &'static str = "./output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Linear` [INFO] [stderr] --> src/animation.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Linear, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `easing` [INFO] [stderr] --> src/animation.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | easing: Easing [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/animation.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | let frames: Vec<_> = (1..self.num_images + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=self.num_images)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mandelbrot.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return i as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `i as u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | const OUTPUT_DIRECTORY: &'static str = "./output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Linear` [INFO] [stderr] --> src/animation.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Linear, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `easing` [INFO] [stderr] --> src/animation.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | easing: Easing [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/animation.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | let frames: Vec<_> = (1..self.num_images + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=self.num_images)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.43s [INFO] running `"docker" "inspect" "4fd7606c22f4489a1d6479768bd3148bfeccdafd7e7dae798e15a75c45e658fe"` [INFO] running `"docker" "rm" "-f" "4fd7606c22f4489a1d6479768bd3148bfeccdafd7e7dae798e15a75c45e658fe"` [INFO] [stdout] 4fd7606c22f4489a1d6479768bd3148bfeccdafd7e7dae798e15a75c45e658fe