[INFO] updating cached repository bjorm/gameoflife [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bjorm/gameoflife [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bjorm/gameoflife" "work/ex/clippy-test-run/sources/stable/gh/bjorm/gameoflife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bjorm/gameoflife'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bjorm/gameoflife" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjorm/gameoflife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjorm/gameoflife'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 13a2e033f590b4fdc285bae4dc1d464973b5931c [INFO] sha for GitHub repo bjorm/gameoflife: 13a2e033f590b4fdc285bae4dc1d464973b5931c [INFO] validating manifest of bjorm/gameoflife on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bjorm/gameoflife on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bjorm/gameoflife [INFO] finished frobbing bjorm/gameoflife [INFO] frobbed toml for bjorm/gameoflife written to work/ex/clippy-test-run/sources/stable/gh/bjorm/gameoflife/Cargo.toml [INFO] started frobbing bjorm/gameoflife [INFO] finished frobbing bjorm/gameoflife [INFO] frobbed toml for bjorm/gameoflife written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjorm/gameoflife/Cargo.toml [INFO] crate bjorm/gameoflife has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bjorm/gameoflife against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bjorm/gameoflife:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f4afc32023e0e40596e3fb8e7cdcb8663acc0e208d7c548e798c99b341671d3 [INFO] running `"docker" "start" "-a" "6f4afc32023e0e40596e3fb8e7cdcb8663acc0e208d7c548e798c99b341671d3"` [INFO] [stderr] Checking gameoflife v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | let mut new_game = GameState { cycle: 0, cells: cells }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | let mut new_game = GameState { cycle: 0, cells: cells }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `blinker` [INFO] [stderr] --> src/main.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | let blinker = vec![(0,1), (1,1), (2,1)]; [INFO] [stderr] | ^^^^^^^ help: consider using `_blinker` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:72:72 [INFO] [stderr] | [INFO] [stderr] 72 | fn count_neighbours_alive(origin_row: usize, origin_col: usize, cells: &CellMap) -> usize { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:111:29 [INFO] [stderr] | [INFO] [stderr] 111 | let mut printable = String::from(format!("cycle: {}\n", self.cycle)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("cycle: {}\n", self.cycle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused variable: `blinker` [INFO] [stderr] --> src/main.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | let blinker = vec![(0,1), (1,1), (2,1)]; [INFO] [stderr] | ^^^^^^^ help: consider using `_blinker` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:72:72 [INFO] [stderr] | [INFO] [stderr] 72 | fn count_neighbours_alive(origin_row: usize, origin_col: usize, cells: &CellMap) -> usize { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:111:29 [INFO] [stderr] | [INFO] [stderr] 111 | let mut printable = String::from(format!("cycle: {}\n", self.cycle)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("cycle: {}\n", self.cycle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `"docker" "inspect" "6f4afc32023e0e40596e3fb8e7cdcb8663acc0e208d7c548e798c99b341671d3"` [INFO] running `"docker" "rm" "-f" "6f4afc32023e0e40596e3fb8e7cdcb8663acc0e208d7c548e798c99b341671d3"` [INFO] [stdout] 6f4afc32023e0e40596e3fb8e7cdcb8663acc0e208d7c548e798c99b341671d3