[INFO] updating cached repository birkenfeld/kenken-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/birkenfeld/kenken-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/birkenfeld/kenken-rs" "work/ex/clippy-test-run/sources/stable/gh/birkenfeld/kenken-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/birkenfeld/kenken-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/birkenfeld/kenken-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/kenken-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/kenken-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c8dc0d83bfba928d088170c452a8483fa8b8295 [INFO] sha for GitHub repo birkenfeld/kenken-rs: 3c8dc0d83bfba928d088170c452a8483fa8b8295 [INFO] validating manifest of birkenfeld/kenken-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of birkenfeld/kenken-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing birkenfeld/kenken-rs [INFO] finished frobbing birkenfeld/kenken-rs [INFO] frobbed toml for birkenfeld/kenken-rs written to work/ex/clippy-test-run/sources/stable/gh/birkenfeld/kenken-rs/Cargo.toml [INFO] started frobbing birkenfeld/kenken-rs [INFO] finished frobbing birkenfeld/kenken-rs [INFO] frobbed toml for birkenfeld/kenken-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/kenken-rs/Cargo.toml [INFO] crate birkenfeld/kenken-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting birkenfeld/kenken-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/kenken-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3647ac60a05ac8dc82ec11bb9363aed8a102b4b8fd6fb14bed7f74dfd1b97d7e [INFO] running `"docker" "start" "-a" "3647ac60a05ac8dc82ec11bb9363aed8a102b4b8fd6fb14bed7f74dfd1b97d7e"` [INFO] [stderr] Checking kenken v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/constraints.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ken: ken, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ken` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | let mut ken = KenKen { size: size, cages: Vec::new(), cell2cage: cell2cage }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:63 [INFO] [stderr] | [INFO] [stderr] 62 | let mut ken = KenKen { size: size, cages: Vec::new(), cell2cage: cell2cage }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell2cage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/constraints.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ken: ken, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ken` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | let mut ken = KenKen { size: size, cages: Vec::new(), cell2cage: cell2cage }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:63 [INFO] [stderr] | [INFO] [stderr] 62 | let mut ken = KenKen { size: size, cages: Vec::new(), cell2cage: cell2cage }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell2cage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:134:30 [INFO] [stderr] | [INFO] [stderr] 134 | SmallVec((1 << 60) | (n as u64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:138:30 [INFO] [stderr] | [INFO] [stderr] 138 | SmallVec((2 << 60) | (n1 as u64) | (n2 as u64) << 4) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(n1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:138:44 [INFO] [stderr] | [INFO] [stderr] 138 | SmallVec((2 << 60) | (n1 as u64) | (n2 as u64) << 4) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:148:50 [INFO] [stderr] | [INFO] [stderr] 148 | self.0 = (self.0 & ((1 << shift) - 1)) | (n as u64) << shift | (len + 1) << 60; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/helpers.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | / pub fn format_square(ken: &KenKen, cellsize: usize, contents: &[T]) -> String { [INFO] [stderr] 173 | | let mut res = String::with_capacity((cellsize + 1) * (ken.size + 2)); [INFO] [stderr] 174 | | let max = ken.size - 1; [INFO] [stderr] 175 | | let cn = |i, j| if i <= max && j <= max { ken.cell2cage.get(i, j).0 } else { !0 }; [INFO] [stderr] ... | [INFO] [stderr] 233 | | res [INFO] [stderr] 234 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/constraints.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | (1..max-goal+1).flat_map(|i| vec![SmallVec::new_with_two(i, i + goal), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(1..=max-goal)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/constraints.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | (1..max/goal+1).flat_map(|i| vec![SmallVec::new_with_two(i, i * goal), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(1..=max/goal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:99:49 [INFO] [stderr] | [INFO] [stderr] 99 | let cage = try!(cells.get_mut(&key).ok_or(format!("reference to undefined cell {}", key))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("reference to undefined cell {}", key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:224:51 [INFO] [stderr] | [INFO] [stderr] 224 | let took = took.as_secs() as f64 + 1e-9 * took.subsec_nanos() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(took.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:134:30 [INFO] [stderr] | [INFO] [stderr] 134 | SmallVec((1 << 60) | (n as u64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:138:30 [INFO] [stderr] | [INFO] [stderr] 138 | SmallVec((2 << 60) | (n1 as u64) | (n2 as u64) << 4) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(n1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:138:44 [INFO] [stderr] | [INFO] [stderr] 138 | SmallVec((2 << 60) | (n1 as u64) | (n2 as u64) << 4) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:148:50 [INFO] [stderr] | [INFO] [stderr] 148 | self.0 = (self.0 & ((1 << shift) - 1)) | (n as u64) << shift | (len + 1) << 60; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/helpers.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | / pub fn format_square(ken: &KenKen, cellsize: usize, contents: &[T]) -> String { [INFO] [stderr] 173 | | let mut res = String::with_capacity((cellsize + 1) * (ken.size + 2)); [INFO] [stderr] 174 | | let max = ken.size - 1; [INFO] [stderr] 175 | | let cn = |i, j| if i <= max && j <= max { ken.cell2cage.get(i, j).0 } else { !0 }; [INFO] [stderr] ... | [INFO] [stderr] 233 | | res [INFO] [stderr] 234 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/constraints.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | (1..max-goal+1).flat_map(|i| vec![SmallVec::new_with_two(i, i + goal), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(1..=max-goal)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/constraints.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | (1..max/goal+1).flat_map(|i| vec![SmallVec::new_with_two(i, i * goal), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(1..=max/goal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:99:49 [INFO] [stderr] | [INFO] [stderr] 99 | let cage = try!(cells.get_mut(&key).ok_or(format!("reference to undefined cell {}", key))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("reference to undefined cell {}", key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:224:51 [INFO] [stderr] | [INFO] [stderr] 224 | let took = took.as_secs() as f64 + 1e-9 * took.subsec_nanos() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(took.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `"docker" "inspect" "3647ac60a05ac8dc82ec11bb9363aed8a102b4b8fd6fb14bed7f74dfd1b97d7e"` [INFO] running `"docker" "rm" "-f" "3647ac60a05ac8dc82ec11bb9363aed8a102b4b8fd6fb14bed7f74dfd1b97d7e"` [INFO] [stdout] 3647ac60a05ac8dc82ec11bb9363aed8a102b4b8fd6fb14bed7f74dfd1b97d7e