[INFO] updating cached repository binarycleric/ls-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/binarycleric/ls-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/binarycleric/ls-rs" "work/ex/clippy-test-run/sources/stable/gh/binarycleric/ls-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/binarycleric/ls-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/binarycleric/ls-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/binarycleric/ls-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/binarycleric/ls-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d14a4aa4ae85569477f148ad3b0942d43f6cf6cc
[INFO] sha for GitHub repo binarycleric/ls-rs: d14a4aa4ae85569477f148ad3b0942d43f6cf6cc
[INFO] validating manifest of binarycleric/ls-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of binarycleric/ls-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing binarycleric/ls-rs
[INFO] finished frobbing binarycleric/ls-rs
[INFO] frobbed toml for binarycleric/ls-rs written to work/ex/clippy-test-run/sources/stable/gh/binarycleric/ls-rs/Cargo.toml
[INFO] started frobbing binarycleric/ls-rs
[INFO] finished frobbing binarycleric/ls-rs
[INFO] frobbed toml for binarycleric/ls-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/binarycleric/ls-rs/Cargo.toml
[INFO] crate binarycleric/ls-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting binarycleric/ls-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/binarycleric/ls-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 94cc6716dd2c0a2859df6bc3d35670cb1156e61f557eff0b0926a1add8a918ee
[INFO] running `"docker" "start" "-a" "94cc6716dd2c0a2859df6bc3d35670cb1156e61f557eff0b0926a1add8a918ee"`
[INFO] [stderr]     Checking ls v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return self.name.to_str().unwrap().starts_with("./.");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.name.to_str().unwrap().starts_with("./.")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return self.metadata.permissions()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.metadata.permissions()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:55:16
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return format!("{:>}", name);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return self.name.to_str().unwrap().starts_with("./.");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.name.to_str().unwrap().starts_with("./.")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return self.metadata.permissions()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.metadata.permissions()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:55:16
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return format!("{:>}", name);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.75s
[INFO] running `"docker" "inspect" "94cc6716dd2c0a2859df6bc3d35670cb1156e61f557eff0b0926a1add8a918ee"`
[INFO] running `"docker" "rm" "-f" "94cc6716dd2c0a2859df6bc3d35670cb1156e61f557eff0b0926a1add8a918ee"`
[INFO] [stdout] 94cc6716dd2c0a2859df6bc3d35670cb1156e61f557eff0b0926a1add8a918ee