[INFO] updating cached repository bill-bishop/rust-webserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bill-bishop/rust-webserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bill-bishop/rust-webserver" "work/ex/clippy-test-run/sources/stable/gh/bill-bishop/rust-webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bill-bishop/rust-webserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bill-bishop/rust-webserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bill-bishop/rust-webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bill-bishop/rust-webserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 38e3cec3795927b2f39126f3fee615fe1889047f [INFO] sha for GitHub repo bill-bishop/rust-webserver: 38e3cec3795927b2f39126f3fee615fe1889047f [INFO] validating manifest of bill-bishop/rust-webserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bill-bishop/rust-webserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bill-bishop/rust-webserver [INFO] finished frobbing bill-bishop/rust-webserver [INFO] frobbed toml for bill-bishop/rust-webserver written to work/ex/clippy-test-run/sources/stable/gh/bill-bishop/rust-webserver/Cargo.toml [INFO] started frobbing bill-bishop/rust-webserver [INFO] finished frobbing bill-bishop/rust-webserver [INFO] frobbed toml for bill-bishop/rust-webserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bill-bishop/rust-webserver/Cargo.toml [INFO] crate bill-bishop/rust-webserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bill-bishop/rust-webserver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bill-bishop/rust-webserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbf23372850a60c74f4bef4ebecda70527157d260a11bd1bd41679098b64e791 [INFO] running `"docker" "start" "-a" "fbf23372850a60c74f4bef4ebecda70527157d260a11bd1bd41679098b64e791"` [INFO] [stderr] Checking rustserver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if let Err(_) = self.sender.send(Message::Terminate) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 84 | | println!("Failed to send Termination message"); [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________- help: try this: `if self.sender.send(Message::Terminate).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | if let Err(_) = join_result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 92 | | println!("Failed to join thread, #{}", worker.id); [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________- help: try this: `if join_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if let Err(_) = self.sender.send(Message::Terminate) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 84 | | println!("Failed to send Termination message"); [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________- help: try this: `if self.sender.send(Message::Terminate).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | if let Err(_) = join_result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 92 | | println!("Failed to join thread, #{}", worker.id); [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________- help: try this: `if join_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | if let Err(_) = stream.read(&mut buf) { println!("Failed to read stream."); } [INFO] [stderr] | -------^^^^^^---------------------------------------------------------------- help: try this: `if stream.read(&mut buf).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/bin/rustserver.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let foo = b"GET /foo HTTP/1.1"; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | if let Err(_) = sender.send(ServerMessage::ShutDown) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 33 | | println!("Failed to send shutdown message."); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________- help: try this: `if sender.send(ServerMessage::ShutDown).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | if let Err(_) = file.read_to_string(&mut contents) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 42 | | println!("Failed to read file"); [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________- help: try this: `if file.read_to_string(&mut contents).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if let Err(_) = stream.write(response.as_bytes()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 49 | | println!("Failed to write response to stream: {}", response); [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____- help: try this: `if stream.write(response.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | if let Err(_) = stream.flush() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 52 | | println!("Failed to flush stream."); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____- help: try this: `if stream.flush().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | if let Err(_) = stream.read(&mut buf) { println!("Failed to read stream."); } [INFO] [stderr] | -------^^^^^^---------------------------------------------------------------- help: try this: `if stream.read(&mut buf).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/bin/rustserver.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let foo = b"GET /foo HTTP/1.1"; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | if let Err(_) = sender.send(ServerMessage::ShutDown) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 33 | | println!("Failed to send shutdown message."); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________- help: try this: `if sender.send(ServerMessage::ShutDown).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | if let Err(_) = file.read_to_string(&mut contents) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 42 | | println!("Failed to read file"); [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________- help: try this: `if file.read_to_string(&mut contents).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if let Err(_) = stream.write(response.as_bytes()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 49 | | println!("Failed to write response to stream: {}", response); [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____- help: try this: `if stream.write(response.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/bin/rustserver.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | if let Err(_) = stream.flush() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 52 | | println!("Failed to flush stream."); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____- help: try this: `if stream.flush().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.33s [INFO] running `"docker" "inspect" "fbf23372850a60c74f4bef4ebecda70527157d260a11bd1bd41679098b64e791"` [INFO] running `"docker" "rm" "-f" "fbf23372850a60c74f4bef4ebecda70527157d260a11bd1bd41679098b64e791"` [INFO] [stdout] fbf23372850a60c74f4bef4ebecda70527157d260a11bd1bd41679098b64e791