[INFO] updating cached repository bikefrivolously/chip8
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bikefrivolously/chip8
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bikefrivolously/chip8" "work/ex/clippy-test-run/sources/stable/gh/bikefrivolously/chip8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bikefrivolously/chip8'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bikefrivolously/chip8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bikefrivolously/chip8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bikefrivolously/chip8'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1ac2ee9cd476eb32e7260b4c3c74e3f9bdfaf4cd
[INFO] sha for GitHub repo bikefrivolously/chip8: 1ac2ee9cd476eb32e7260b4c3c74e3f9bdfaf4cd
[INFO] validating manifest of bikefrivolously/chip8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bikefrivolously/chip8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bikefrivolously/chip8
[INFO] finished frobbing bikefrivolously/chip8
[INFO] frobbed toml for bikefrivolously/chip8 written to work/ex/clippy-test-run/sources/stable/gh/bikefrivolously/chip8/Cargo.toml
[INFO] started frobbing bikefrivolously/chip8
[INFO] finished frobbing bikefrivolously/chip8
[INFO] frobbed toml for bikefrivolously/chip8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bikefrivolously/chip8/Cargo.toml
[INFO] crate bikefrivolously/chip8 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bikefrivolously/chip8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bikefrivolously/chip8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8b6ffac668c717c293eaab75f3653dc4e0dd77c30062ce6e73a6e8e8b901b2f4
[INFO] running `"docker" "start" "-a" "8b6ffac668c717c293eaab75f3653dc4e0dd77c30062ce6e73a6e8e8b901b2f4"`
[INFO] [stderr]     Checking chip8 v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cpu.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..100000 {
[INFO] [stderr]    |                     ^^^^^^ help: consider: `100_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cpu.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..100000 {
[INFO] [stderr]    |                     ^^^^^^ help: consider: `100_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/cpu.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..100000 {
[INFO] [stderr]    |             ^ help: consider using `_i` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/cpu.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..100000 {
[INFO] [stderr]    |             ^ help: consider using `_i` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `FONTS`
[INFO] [stderr]   --> src/cpu.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for (i, <item>) in FONTS.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/cpu.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^ help: try replacing the loop by: `cpu.memory[..80].clone_from_slice(&FONTS[..80])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `b` is only used to index `data`.
[INFO] [stderr]   --> src/cpu.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for b in 0..data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for <item> in &data {
[INFO] [stderr]    |             ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu.rs:64:23
[INFO] [stderr]    |
[INFO] [stderr] 64 |         self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc + 1] as u16);
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu.rs:64:60
[INFO] [stderr]    |
[INFO] [stderr] 64 |         self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc + 1] as u16);
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:156:20
[INFO] [stderr]     |
[INFO] [stderr] 156 |             0x1 => self.v[x] = self.v[x] | self.v[y],
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] |= self.v[y]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:157:20
[INFO] [stderr]     |
[INFO] [stderr] 157 |             0x2 => self.v[x] = self.v[x] & self.v[y],
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] &= self.v[y]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:158:20
[INFO] [stderr]     |
[INFO] [stderr] 158 |             0x3 => self.v[x] = self.v[x] ^ self.v[y],
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] ^= self.v[y]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused bitwise operation that must be used
[INFO] [stderr]    --> src/cpu.rs:176:17
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 self.v[x] >> 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]    --> src/cpu.rs:176:17
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 self.v[x] >> 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: unused bitwise operation that must be used
[INFO] [stderr]    --> src/cpu.rs:190:17
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 self.v[x] << 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]    --> src/cpu.rs:190:17
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 self.v[x] << 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `FONTS`
[INFO] [stderr]   --> src/cpu.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for (i, <item>) in FONTS.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/cpu.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^ help: try replacing the loop by: `cpu.memory[..80].clone_from_slice(&FONTS[..80])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:245:21
[INFO] [stderr]     |
[INFO] [stderr] 245 |             0x1E => self.i = self.i + self.v[x] as u16,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i += self.v[x] as u16`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:245:39
[INFO] [stderr]     |
[INFO] [stderr] 245 |             0x1E => self.i = self.i + self.v[x] as u16,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:246:30
[INFO] [stderr]     |
[INFO] [stderr] 246 |             0x29 => self.i = self.v[x] as u16 * 5,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu.rs:249:27
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 for vx in 0..x+1 {
[INFO] [stderr]     |                           ^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu.rs:255:27
[INFO] [stderr]     |
[INFO] [stderr] 255 |                 for vx in 0..x+1 {
[INFO] [stderr]     |                           ^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Err(_) => panic!("Problem reading from program file.")
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `b` is only used to index `data`.
[INFO] [stderr]   --> src/cpu.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for b in 0..data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for <item> in &data {
[INFO] [stderr]    |             ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu.rs:64:23
[INFO] [stderr]    |
[INFO] [stderr] 64 |         self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc + 1] as u16);
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu.rs:64:60
[INFO] [stderr]    |
[INFO] [stderr] 64 |         self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc + 1] as u16);
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:156:20
[INFO] [stderr]     |
[INFO] [stderr] 156 |             0x1 => self.v[x] = self.v[x] | self.v[y],
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] |= self.v[y]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:157:20
[INFO] [stderr]     |
[INFO] [stderr] 157 |             0x2 => self.v[x] = self.v[x] & self.v[y],
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] &= self.v[y]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:158:20
[INFO] [stderr]     |
[INFO] [stderr] 158 |             0x3 => self.v[x] = self.v[x] ^ self.v[y],
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] ^= self.v[y]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused bitwise operation that must be used
[INFO] [stderr]    --> src/cpu.rs:176:17
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 self.v[x] >> 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]    --> src/cpu.rs:176:17
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 self.v[x] >> 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: unused bitwise operation that must be used
[INFO] [stderr]    --> src/cpu.rs:190:17
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 self.v[x] << 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]    --> src/cpu.rs:190:17
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 self.v[x] << 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu.rs:245:21
[INFO] [stderr]     |
[INFO] [stderr] 245 |             0x1E => self.i = self.i + self.v[x] as u16,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i += self.v[x] as u16`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:245:39
[INFO] [stderr]     |
[INFO] [stderr] 245 |             0x1E => self.i = self.i + self.v[x] as u16,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:246:30
[INFO] [stderr]     |
[INFO] [stderr] 246 |             0x29 => self.i = self.v[x] as u16 * 5,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu.rs:249:27
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 for vx in 0..x+1 {
[INFO] [stderr]     |                           ^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu.rs:255:27
[INFO] [stderr]     |
[INFO] [stderr] 255 |                 for vx in 0..x+1 {
[INFO] [stderr]     |                           ^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Err(_) => panic!("Problem reading from program file.")
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.57s
[INFO] running `"docker" "inspect" "8b6ffac668c717c293eaab75f3653dc4e0dd77c30062ce6e73a6e8e8b901b2f4"`
[INFO] running `"docker" "rm" "-f" "8b6ffac668c717c293eaab75f3653dc4e0dd77c30062ce6e73a6e8e8b901b2f4"`
[INFO] [stdout] 8b6ffac668c717c293eaab75f3653dc4e0dd77c30062ce6e73a6e8e8b901b2f4