[INFO] updating cached repository bigfeats/crypto [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bigfeats/crypto [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bigfeats/crypto" "work/ex/clippy-test-run/sources/stable/gh/bigfeats/crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bigfeats/crypto'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bigfeats/crypto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bigfeats/crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bigfeats/crypto'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 79bcbac8fc5f3b0d5aa5f67e04c49fc0c88b6e49 [INFO] sha for GitHub repo bigfeats/crypto: 79bcbac8fc5f3b0d5aa5f67e04c49fc0c88b6e49 [INFO] validating manifest of bigfeats/crypto on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bigfeats/crypto on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bigfeats/crypto [INFO] finished frobbing bigfeats/crypto [INFO] frobbed toml for bigfeats/crypto written to work/ex/clippy-test-run/sources/stable/gh/bigfeats/crypto/Cargo.toml [INFO] started frobbing bigfeats/crypto [INFO] finished frobbing bigfeats/crypto [INFO] frobbed toml for bigfeats/crypto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bigfeats/crypto/Cargo.toml [INFO] crate bigfeats/crypto has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bigfeats/crypto against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bigfeats/crypto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 140951a8a5de1d2e47fa2b1b719351e726ae1ff7496e8bf40956a40afd3935c9 [INFO] running `"docker" "start" "-a" "140951a8a5de1d2e47fa2b1b719351e726ae1ff7496e8bf40956a40afd3935c9"` [INFO] [stderr] Checking crypto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/utils/math.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(t as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(t as u16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/utils/mod.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_message) => return Err(format!("Invalid key, expected integer: {}", key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Invalid key, expected integer: {}", key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/utils/math.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(t as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(t as u16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/utils/mod.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_message) => return Err(format!("Invalid key, expected integer: {}", key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Invalid key, expected integer: {}", key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/algorithms/affine.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | let keys: Vec<&str> = key.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/multiply.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let offset_index = letter_index as u16 * mult; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(letter_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/multiply.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | utils::get_letter(offset_index as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(offset_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/shift.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | let offset_index = letter_index as i32 + offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(letter_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/utils/math.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | let modulus = modulus as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(modulus)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/utils/math.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | let value = value as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/utils/math.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | let modulus = modulus as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(modulus)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithms/utils/math.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | t = t + modulus [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `t += modulus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/algorithms/utils/mod.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | letter as u8 - 'a' as u8 + 1u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/algorithms/utils/mod.rs:13:6 [INFO] [stderr] | [INFO] [stderr] 13 | ('a' as u8 + mod_offset) as char [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:7:37 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &str, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `requested_algorithm.as_str()` to [INFO] [stderr] | [INFO] [stderr] 8 | match requested_algorithm { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:7:55 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:7:69 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &str, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `requested_algorithm.as_str()` to [INFO] [stderr] | [INFO] [stderr] 18 | match requested_algorithm { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:17:55 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:17:69 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / let result; [INFO] [stderr] 6 | | if config.encrypt { [INFO] [stderr] 7 | | result = algorithms::encrypt(&config.algorithm, &config.message, &config.key); [INFO] [stderr] 8 | | } else { [INFO] [stderr] 9 | | result = algorithms::decrypt(&config.algorithm, &config.message, &config.key); [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if config.encrypt { algorithms::encrypt(&config.algorithm, &config.message, &config.key) } else { algorithms::decrypt(&config.algorithm, &config.message, &config.key) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/algorithms/affine.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | let keys: Vec<&str> = key.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/multiply.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let offset_index = letter_index as u16 * mult; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(letter_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/multiply.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | utils::get_letter(offset_index as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(offset_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/shift.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | let offset_index = letter_index as i32 + offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(letter_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/utils/math.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | let modulus = modulus as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(modulus)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/utils/math.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | let value = value as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/algorithms/utils/math.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | let modulus = modulus as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(modulus)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithms/utils/math.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | t = t + modulus [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `t += modulus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/algorithms/utils/mod.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | letter as u8 - 'a' as u8 + 1u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/algorithms/utils/mod.rs:13:6 [INFO] [stderr] | [INFO] [stderr] 13 | ('a' as u8 + mod_offset) as char [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:7:37 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &str, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `requested_algorithm.as_str()` to [INFO] [stderr] | [INFO] [stderr] 8 | match requested_algorithm { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:7:55 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:7:69 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn encrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &str, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `requested_algorithm.as_str()` to [INFO] [stderr] | [INFO] [stderr] 18 | match requested_algorithm { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:17:55 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/algorithms/mod.rs:17:69 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(requested_algorithm: &String, message: &String, key: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / let result; [INFO] [stderr] 6 | | if config.encrypt { [INFO] [stderr] 7 | | result = algorithms::encrypt(&config.algorithm, &config.message, &config.key); [INFO] [stderr] 8 | | } else { [INFO] [stderr] 9 | | result = algorithms::decrypt(&config.algorithm, &config.message, &config.key); [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if config.encrypt { algorithms::encrypt(&config.algorithm, &config.message, &config.key) } else { algorithms::decrypt(&config.algorithm, &config.message, &config.key) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.73s [INFO] running `"docker" "inspect" "140951a8a5de1d2e47fa2b1b719351e726ae1ff7496e8bf40956a40afd3935c9"` [INFO] running `"docker" "rm" "-f" "140951a8a5de1d2e47fa2b1b719351e726ae1ff7496e8bf40956a40afd3935c9"` [INFO] [stdout] 140951a8a5de1d2e47fa2b1b719351e726ae1ff7496e8bf40956a40afd3935c9