[INFO] updating cached repository benjomeshi/procon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benjomeshi/procon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benjomeshi/procon" "work/ex/clippy-test-run/sources/stable/gh/benjomeshi/procon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benjomeshi/procon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benjomeshi/procon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjomeshi/procon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjomeshi/procon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 84ad6df56cf24e8f47e1e444a41e06d0524fa573 [INFO] sha for GitHub repo benjomeshi/procon: 84ad6df56cf24e8f47e1e444a41e06d0524fa573 [INFO] validating manifest of benjomeshi/procon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benjomeshi/procon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benjomeshi/procon [INFO] finished frobbing benjomeshi/procon [INFO] frobbed toml for benjomeshi/procon written to work/ex/clippy-test-run/sources/stable/gh/benjomeshi/procon/Cargo.toml [INFO] started frobbing benjomeshi/procon [INFO] finished frobbing benjomeshi/procon [INFO] frobbed toml for benjomeshi/procon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjomeshi/procon/Cargo.toml [INFO] crate benjomeshi/procon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benjomeshi/procon against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjomeshi/procon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb64dfbe3147f51d80ea0c8839764f2631810f0ae61f91474cc734a013249499 [INFO] running `"docker" "start" "-a" "fb64dfbe3147f51d80ea0c8839764f2631810f0ae61f91474cc734a013249499"` [INFO] [stderr] Checking procon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | }else{ [INFO] [stderr] | __________^ [INFO] [stderr] 21 | | if am_pm == "PM" {hour + 12} else {hour} [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____^ help: try: `if am_pm == "PM" {hour + 12} else {hour}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | io::stdin().read_line(&mut time_str).ok().expect("read error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | }else{ [INFO] [stderr] | __________^ [INFO] [stderr] 21 | | if am_pm == "PM" {hour + 12} else {hour} [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____^ help: try: `if am_pm == "PM" {hour + 12} else {hour}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | io::stdin().read_line(&mut time_str).ok().expect("read error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.55s [INFO] running `"docker" "inspect" "fb64dfbe3147f51d80ea0c8839764f2631810f0ae61f91474cc734a013249499"` [INFO] running `"docker" "rm" "-f" "fb64dfbe3147f51d80ea0c8839764f2631810f0ae61f91474cc734a013249499"` [INFO] [stdout] fb64dfbe3147f51d80ea0c8839764f2631810f0ae61f91474cc734a013249499