[INFO] updating cached repository benjaminhadfield/mmu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benjaminhadfield/mmu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benjaminhadfield/mmu" "work/ex/clippy-test-run/sources/stable/gh/benjaminhadfield/mmu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benjaminhadfield/mmu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benjaminhadfield/mmu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjaminhadfield/mmu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjaminhadfield/mmu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2608b8855ef509e896b9f46f439ef0d42417022 [INFO] sha for GitHub repo benjaminhadfield/mmu: c2608b8855ef509e896b9f46f439ef0d42417022 [INFO] validating manifest of benjaminhadfield/mmu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benjaminhadfield/mmu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benjaminhadfield/mmu [INFO] finished frobbing benjaminhadfield/mmu [INFO] frobbed toml for benjaminhadfield/mmu written to work/ex/clippy-test-run/sources/stable/gh/benjaminhadfield/mmu/Cargo.toml [INFO] started frobbing benjaminhadfield/mmu [INFO] finished frobbing benjaminhadfield/mmu [INFO] frobbed toml for benjaminhadfield/mmu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjaminhadfield/mmu/Cargo.toml [INFO] crate benjaminhadfield/mmu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benjaminhadfield/mmu against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjaminhadfield/mmu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d31e3c6d93ac4c389d93cd2bc9acbe4e2217c216e4aaace06720a57b2a7b6cea [INFO] running `"docker" "start" "-a" "d31e3c6d93ac4c389d93cd2bc9acbe4e2217c216e4aaace06720a57b2a7b6cea"` [INFO] [stderr] Checking mmu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | m: m, [INFO] [stderr] | ^^^^ help: replace it with: `m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | e: e, [INFO] [stderr] | ^^^^ help: replace it with: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | s: s, [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | m: m, [INFO] [stderr] | ^^^^ help: replace it with: `m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | e: e, [INFO] [stderr] | ^^^^ help: replace it with: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | s: s, [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/address.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | *va & 2u64.pow(mem.p as u32) - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `*va & (2u64.pow(mem.p as u32) - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/address.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | *va & 2u64.pow(mem.p as u32) - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `*va & (2u64.pow(mem.p as u32) - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: field is never used: `e` [INFO] [stderr] --> src/hardware.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | e: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `s` [INFO] [stderr] --> src/hardware.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | s: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `e` [INFO] [stderr] --> src/hardware.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | e: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `s` [INFO] [stderr] --> src/hardware.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | s: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn po(mem: &Memory, va: &u64) -> u64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/address.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | *va & 2u64.pow(mem.p as u32) - 1 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(mem.p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn pn(mem: &Memory, va: &u64) -> u64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn po(mem: &Memory, va: &u64) -> u64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/address.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | *va & 2u64.pow(mem.p as u32) - 1 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(mem.p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn pn(mem: &Memory, va: &u64) -> u64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tlb` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let tlb = hardware::TLB::new(4, 4); [INFO] [stderr] | ^^^ help: consider using `_tlb` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tlb` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let tlb = hardware::TLB::new(4, 4); [INFO] [stderr] | ^^^ help: consider using `_tlb` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "d31e3c6d93ac4c389d93cd2bc9acbe4e2217c216e4aaace06720a57b2a7b6cea"` [INFO] running `"docker" "rm" "-f" "d31e3c6d93ac4c389d93cd2bc9acbe4e2217c216e4aaace06720a57b2a7b6cea"` [INFO] [stdout] d31e3c6d93ac4c389d93cd2bc9acbe4e2217c216e4aaace06720a57b2a7b6cea