[INFO] updating cached repository bengoodwyn/aoc-2016-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bengoodwyn/aoc-2016-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bengoodwyn/aoc-2016-rust" "work/ex/clippy-test-run/sources/stable/gh/bengoodwyn/aoc-2016-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bengoodwyn/aoc-2016-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bengoodwyn/aoc-2016-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bengoodwyn/aoc-2016-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bengoodwyn/aoc-2016-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ab86c05bae872b31820a019f0377638f8ec07cef [INFO] sha for GitHub repo bengoodwyn/aoc-2016-rust: ab86c05bae872b31820a019f0377638f8ec07cef [INFO] validating manifest of bengoodwyn/aoc-2016-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bengoodwyn/aoc-2016-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bengoodwyn/aoc-2016-rust [INFO] finished frobbing bengoodwyn/aoc-2016-rust [INFO] frobbed toml for bengoodwyn/aoc-2016-rust written to work/ex/clippy-test-run/sources/stable/gh/bengoodwyn/aoc-2016-rust/Cargo.toml [INFO] started frobbing bengoodwyn/aoc-2016-rust [INFO] finished frobbing bengoodwyn/aoc-2016-rust [INFO] frobbed toml for bengoodwyn/aoc-2016-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bengoodwyn/aoc-2016-rust/Cargo.toml [INFO] crate bengoodwyn/aoc-2016-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bengoodwyn/aoc-2016-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bengoodwyn/aoc-2016-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd208d2bdaf6ae56be2f2b740cca5e837328f4a99fec3cb6850083d3315e1a19 [INFO] running `"docker" "start" "-a" "bd208d2bdaf6ae56be2f2b740cca5e837328f4a99fec3cb6850083d3315e1a19"` [INFO] [stderr] Checking rusty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aoc/day2.rs:159:32 [INFO] [stderr] | [INFO] [stderr] 159 | .fold(Position{x:x, y:y}, |position, direction| { [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aoc/day2.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | .fold(Position{x:x, y:y}, |position, direction| { [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aoc/day2.rs:159:32 [INFO] [stderr] | [INFO] [stderr] 159 | .fold(Position{x:x, y:y}, |position, direction| { [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aoc/day2.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | .fold(Position{x:x, y:y}, |position, direction| { [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/aoc/day1.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | fn travel(&self, distance_to_travel: i32, direction_to_travel: Direction) -> Position { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/aoc/day1.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | fn travel(&self, distance_to_travel: i32, direction_to_travel: Direction) -> Position { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "bd208d2bdaf6ae56be2f2b740cca5e837328f4a99fec3cb6850083d3315e1a19"` [INFO] running `"docker" "rm" "-f" "bd208d2bdaf6ae56be2f2b740cca5e837328f4a99fec3cb6850083d3315e1a19"` [INFO] [stdout] bd208d2bdaf6ae56be2f2b740cca5e837328f4a99fec3cb6850083d3315e1a19