[INFO] updating cached repository bendmorris/soupdb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bendmorris/soupdb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bendmorris/soupdb" "work/ex/clippy-test-run/sources/stable/gh/bendmorris/soupdb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bendmorris/soupdb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bendmorris/soupdb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bendmorris/soupdb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bendmorris/soupdb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d2e2e702a4f7164ad06bf07212e9d54ea2e9b45 [INFO] sha for GitHub repo bendmorris/soupdb: 1d2e2e702a4f7164ad06bf07212e9d54ea2e9b45 [INFO] validating manifest of bendmorris/soupdb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bendmorris/soupdb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bendmorris/soupdb [INFO] finished frobbing bendmorris/soupdb [INFO] frobbed toml for bendmorris/soupdb written to work/ex/clippy-test-run/sources/stable/gh/bendmorris/soupdb/Cargo.toml [INFO] started frobbing bendmorris/soupdb [INFO] finished frobbing bendmorris/soupdb [INFO] frobbed toml for bendmorris/soupdb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bendmorris/soupdb/Cargo.toml [INFO] crate bendmorris/soupdb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bendmorris/soupdb against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bendmorris/soupdb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9953f7981a170b23e84f85f8d58a5fbe109e51a9ba7889e05d5b502e87f9cd8a [INFO] running `"docker" "start" "-a" "9953f7981a170b23e84f85f8d58a5fbe109e51a9ba7889e05d5b502e87f9cd8a"` [INFO] [stderr] Checking soupdb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/binop.rs:23:85 [INFO] [stderr] | [INFO] [stderr] 23 | expr_stack.push(Expr::BinOp {left: Box::new(lhs), right: Box::new(rhs), op: op}); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/binop.rs:27:63 [INFO] [stderr] | [INFO] [stderr] 27 | expr_stack.push(Expr::UnOp {expr: Box::new(expr), op: op}); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | data_dir: data_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | schemas: schemas, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `schemas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | page_lru: page_lru, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `page_lru` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | available_slots: available_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | page_data: page_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | page_table: page_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | Model {name: name, schema: schema} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | Model {name: name, schema: schema} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/binop.rs:23:85 [INFO] [stderr] | [INFO] [stderr] 23 | expr_stack.push(Expr::BinOp {left: Box::new(lhs), right: Box::new(rhs), op: op}); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/binop.rs:27:63 [INFO] [stderr] | [INFO] [stderr] 27 | expr_stack.push(Expr::UnOp {expr: Box::new(expr), op: op}); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | data_dir: data_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | schemas: schemas, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `schemas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | page_lru: page_lru, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `page_lru` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | available_slots: available_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | page_data: page_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/cache.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | page_table: page_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | Model {name: name, schema: schema} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | Model {name: name, schema: schema} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/dbfile.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return meta; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/dbfile.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return meta; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/io/value.rs:65:44 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(Some(Value {uint_value: 18446744073709551615}), Value::from_bytes(&[0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff], &ValueType::Uint)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/binop.rs:66:11 [INFO] [stderr] | [INFO] [stderr] 66 | while op_stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/binop.rs:66:11 [INFO] [stderr] | [INFO] [stderr] 66 | while op_stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/tuple.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &TupleDef(ref v) => { [INFO] [stderr] 23 | | let mut size = 0; [INFO] [stderr] 24 | | for entry in v { [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | TupleDef(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/tuple.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &TupleDef(ref v) => { [INFO] [stderr] 35 | | let s: Vec = v.into_iter().map(|e: &TupleEntry| e.to_ddl()).collect(); [INFO] [stderr] 36 | | format!("({})", s.join(", ")) [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | TupleDef(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ast/tuple.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | let s: Vec = v.into_iter().map(|e: &TupleEntry| e.to_ddl()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/tuple.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &TupleDef(ref v) => { [INFO] [stderr] 47 | | &v[index] [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | TupleDef(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/value_type.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 28 | | &ValueType::Bool => 1, [INFO] [stderr] 29 | | // 64-bit numeric types [INFO] [stderr] ... | [INFO] [stderr] 38 | | &ValueType::Vector(n, ref v) => n * (*v).size_of(), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 28 | ValueType::Bool => 1, [INFO] [stderr] 29 | // 64-bit numeric types [INFO] [stderr] 30 | ValueType::Uint => 8, [INFO] [stderr] 31 | ValueType::Int => 8, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/value_type.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 45 | | &ValueType::AutoId => "autoid".to_string(), [INFO] [stderr] 46 | | &ValueType::Bool => "bool".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 52 | | &ValueType::Vector(n, ref v) => format!("vector({}) {}", n, (*v).to_ddl()), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 45 | ValueType::AutoId => "autoid".to_string(), [INFO] [stderr] 46 | ValueType::Bool => "bool".to_string(), [INFO] [stderr] 47 | ValueType::Uint => "unsigned int".to_string(), [INFO] [stderr] 48 | ValueType::Int => "int".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Config { [INFO] [stderr] 10 | | let new_config = Config {data_dir: ["/var", "soupdb"].iter().collect()}; [INFO] [stderr] 11 | | new_config.create_directories(); [INFO] [stderr] 12 | | new_config [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: for loop over `glob(data_dir.join("*.schema").to_str().unwrap())`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_result)] on by default [INFO] [stderr] = help: consider replacing `for entry in glob(data_dir.join("*.schema").to_str().unwrap())` with `if let Ok(entry) = glob(data_dir.join("*.schema").to_str().unwrap())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/cache.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | let mut ref_count = match lock_type { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 161 | | &LockType::Read => &mut self.reader_count, [INFO] [stderr] 162 | | &LockType::Write => &mut self.writer_count, [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | let mut ref_count = match *lock_type { [INFO] [stderr] 161 | LockType::Read => &mut self.reader_count, [INFO] [stderr] 162 | LockType::Write => &mut self.writer_count, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/cache.rs:173:33 [INFO] [stderr] | [INFO] [stderr] 173 | let mut ref_count = match lock_type { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 174 | | &LockType::Read => &mut self.reader_count, [INFO] [stderr] 175 | | &LockType::Write => &mut self.writer_count, [INFO] [stderr] 176 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | let mut ref_count = match *lock_type { [INFO] [stderr] 174 | LockType::Read => &mut self.reader_count, [INFO] [stderr] 175 | LockType::Write => &mut self.writer_count, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/io/cache.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | entry.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:182:64 [INFO] [stderr] | [INFO] [stderr] 182 | if self.pending_requests.contains_key(&page_id) && self.pending_requests.get(&page_id).unwrap().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.pending_requests.get(&page_id).unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/io/cache.rs:182:64 [INFO] [stderr] | [INFO] [stderr] 182 | if self.pending_requests.contains_key(&page_id) && self.pending_requests.get(&page_id).unwrap().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.pending_requests[&page_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/io/cache.rs:186:55 [INFO] [stderr] | [INFO] [stderr] 186 | self.page_lru.insert(page_id.clone(), self.page_map.get(page_id).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.page_map[page_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:227:19 [INFO] [stderr] | [INFO] [stderr] 227 | while pending.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/cache.rs:241:68 [INFO] [stderr] | [INFO] [stderr] 241 | (self._contains_page(&page_id) || self.can_load_page()) && match lock_type { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 242 | | &LockType::Read => match self.writer_count.get(&page_id) { [INFO] [stderr] 243 | | Some(n) if *n > 0 => false, [INFO] [stderr] 244 | | _ => match self.pending_requests.get(&page_id) { [INFO] [stderr] ... | [INFO] [stderr] 259 | | }, [INFO] [stderr] 260 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 241 | (self._contains_page(&page_id) || self.can_load_page()) && match *lock_type { [INFO] [stderr] 242 | LockType::Read => match self.writer_count.get(&page_id) { [INFO] [stderr] 243 | Some(n) if *n > 0 => false, [INFO] [stderr] 244 | _ => match self.pending_requests.get(&page_id) { [INFO] [stderr] 245 | Some(v) => { [INFO] [stderr] 246 | // if the next request is a write request, don't accept any [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | v.len() == 0 || v[0].lock_type == LockType::Write [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/io/cache.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | Some(self.page_map.get(&page_id).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.page_map.get(&page_id).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/io/cache.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | Some(self.page_map.get(&page_id).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.page_map[&page_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | !(self.available_slots.is_empty() && self.page_lru.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.page_lru.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/io/cache.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | / loop { [INFO] [stderr] 295 | | match self.reader_count.receiver.try_recv() { [INFO] [stderr] 296 | | Ok(page_id) => { [INFO] [stderr] 297 | | self.decr_ref_count(&page_id, &LockType::Read); [INFO] [stderr] ... | [INFO] [stderr] 302 | | } [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(page_id) = self.reader_count.receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/io/cache.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | / loop { [INFO] [stderr] 305 | | match self.writer_count.receiver.try_recv() { [INFO] [stderr] 306 | | Ok(page_id) => { [INFO] [stderr] 307 | | self.decr_ref_count(&page_id, &LockType::Write); [INFO] [stderr] ... | [INFO] [stderr] 312 | | } [INFO] [stderr] 313 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(page_id) = self.writer_count.receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/io/cache.rs:348:33 [INFO] [stderr] | [INFO] [stderr] 348 | let mut index = match &lock { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 349 | | &PageLock {index, ..} => { [INFO] [stderr] 350 | | let buf = &mut self.page_data[(index*PAGE_SIZE) as usize .. ((index+1)*PAGE_SIZE) as usize]; [INFO] [stderr] 351 | | if load { [INFO] [stderr] ... | [INFO] [stderr] 356 | | } [INFO] [stderr] 357 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 348 | let mut index = match lock { [INFO] [stderr] 349 | PageLock {index, ..} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/io/dbfile.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / fn to_bytes<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 16 | | unsafe { [INFO] [stderr] 17 | | ::std::slice::from_raw_parts( [INFO] [stderr] 18 | | (self as *const Self) as *const u8, [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const io::dbfile::PageMetadata`) [INFO] [stderr] --> src/io/dbfile.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | ::std::ptr::read(page_data.as_ptr() as *const _) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/value.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match value_type { [INFO] [stderr] 15 | | &ValueType::Bool => Some(Value {uint_value: if bytes[0] != 0 {1} else {0}}), [INFO] [stderr] 16 | | &ValueType::Uint => Some(Value {uint_value: LittleEndian::read_u64(&bytes)}), [INFO] [stderr] 17 | | &ValueType::Int => Some(Value {int_value: LittleEndian::read_i64(&bytes)}), [INFO] [stderr] 18 | | &ValueType::Float => Some(Value {float_value: LittleEndian::read_f64(&bytes)}), [INFO] [stderr] 19 | | _ => None [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *value_type { [INFO] [stderr] 15 | ValueType::Bool => Some(Value {uint_value: if bytes[0] != 0 {1} else {0}}), [INFO] [stderr] 16 | ValueType::Uint => Some(Value {uint_value: LittleEndian::read_u64(&bytes)}), [INFO] [stderr] 17 | ValueType::Int => Some(Value {int_value: LittleEndian::read_i64(&bytes)}), [INFO] [stderr] 18 | ValueType::Float => Some(Value {float_value: LittleEndian::read_f64(&bytes)}), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/value.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match value_type { [INFO] [stderr] 26 | | &ValueType::Bool => bytes[0] = if self.bool_value {1} else {0}, [INFO] [stderr] 27 | | &ValueType::Uint => LittleEndian::write_u64(&mut bytes, self.uint_value), [INFO] [stderr] 28 | | &ValueType::Int => LittleEndian::write_i64(&mut bytes, self.int_value), [INFO] [stderr] 29 | | &ValueType::Float => LittleEndian::write_f64(&mut bytes, self.float_value), [INFO] [stderr] 30 | | _ => () [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *value_type { [INFO] [stderr] 26 | ValueType::Bool => bytes[0] = if self.bool_value {1} else {0}, [INFO] [stderr] 27 | ValueType::Uint => LittleEndian::write_u64(&mut bytes, self.uint_value), [INFO] [stderr] 28 | ValueType::Int => LittleEndian::write_i64(&mut bytes, self.int_value), [INFO] [stderr] 29 | ValueType::Float => LittleEndian::write_f64(&mut bytes, self.float_value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/model/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | to.write(self.to_ddl().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `soupdb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/tuple.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &TupleDef(ref v) => { [INFO] [stderr] 23 | | let mut size = 0; [INFO] [stderr] 24 | | for entry in v { [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | TupleDef(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/tuple.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &TupleDef(ref v) => { [INFO] [stderr] 35 | | let s: Vec = v.into_iter().map(|e: &TupleEntry| e.to_ddl()).collect(); [INFO] [stderr] 36 | | format!("({})", s.join(", ")) [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | TupleDef(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ast/tuple.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | let s: Vec = v.into_iter().map(|e: &TupleEntry| e.to_ddl()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/tuple.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &TupleDef(ref v) => { [INFO] [stderr] 47 | | &v[index] [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | TupleDef(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/value_type.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 28 | | &ValueType::Bool => 1, [INFO] [stderr] 29 | | // 64-bit numeric types [INFO] [stderr] ... | [INFO] [stderr] 38 | | &ValueType::Vector(n, ref v) => n * (*v).size_of(), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 28 | ValueType::Bool => 1, [INFO] [stderr] 29 | // 64-bit numeric types [INFO] [stderr] 30 | ValueType::Uint => 8, [INFO] [stderr] 31 | ValueType::Int => 8, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast/value_type.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 45 | | &ValueType::AutoId => "autoid".to_string(), [INFO] [stderr] 46 | | &ValueType::Bool => "bool".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 52 | | &ValueType::Vector(n, ref v) => format!("vector({}) {}", n, (*v).to_ddl()), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | ValueType::Unknown => panic!("invalid schema with unknown field type"), [INFO] [stderr] 45 | ValueType::AutoId => "autoid".to_string(), [INFO] [stderr] 46 | ValueType::Bool => "bool".to_string(), [INFO] [stderr] 47 | ValueType::Uint => "unsigned int".to_string(), [INFO] [stderr] 48 | ValueType::Int => "int".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Config { [INFO] [stderr] 10 | | let new_config = Config {data_dir: ["/var", "soupdb"].iter().collect()}; [INFO] [stderr] 11 | | new_config.create_directories(); [INFO] [stderr] 12 | | new_config [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | assert!(config.data_dir.to_str().unwrap().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.data_dir.to_str().unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: for loop over `glob(data_dir.join("*.schema").to_str().unwrap())`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_result)] on by default [INFO] [stderr] = help: consider replacing `for entry in glob(data_dir.join("*.schema").to_str().unwrap())` with `if let Ok(entry) = glob(data_dir.join("*.schema").to_str().unwrap())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/cache.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | let mut ref_count = match lock_type { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 161 | | &LockType::Read => &mut self.reader_count, [INFO] [stderr] 162 | | &LockType::Write => &mut self.writer_count, [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | let mut ref_count = match *lock_type { [INFO] [stderr] 161 | LockType::Read => &mut self.reader_count, [INFO] [stderr] 162 | LockType::Write => &mut self.writer_count, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/cache.rs:173:33 [INFO] [stderr] | [INFO] [stderr] 173 | let mut ref_count = match lock_type { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 174 | | &LockType::Read => &mut self.reader_count, [INFO] [stderr] 175 | | &LockType::Write => &mut self.writer_count, [INFO] [stderr] 176 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | let mut ref_count = match *lock_type { [INFO] [stderr] 174 | LockType::Read => &mut self.reader_count, [INFO] [stderr] 175 | LockType::Write => &mut self.writer_count, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/io/cache.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | entry.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:182:64 [INFO] [stderr] | [INFO] [stderr] 182 | if self.pending_requests.contains_key(&page_id) && self.pending_requests.get(&page_id).unwrap().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.pending_requests.get(&page_id).unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/io/cache.rs:182:64 [INFO] [stderr] | [INFO] [stderr] 182 | if self.pending_requests.contains_key(&page_id) && self.pending_requests.get(&page_id).unwrap().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.pending_requests[&page_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/io/cache.rs:186:55 [INFO] [stderr] | [INFO] [stderr] 186 | self.page_lru.insert(page_id.clone(), self.page_map.get(page_id).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.page_map[page_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:227:19 [INFO] [stderr] | [INFO] [stderr] 227 | while pending.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/cache.rs:241:68 [INFO] [stderr] | [INFO] [stderr] 241 | (self._contains_page(&page_id) || self.can_load_page()) && match lock_type { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 242 | | &LockType::Read => match self.writer_count.get(&page_id) { [INFO] [stderr] 243 | | Some(n) if *n > 0 => false, [INFO] [stderr] 244 | | _ => match self.pending_requests.get(&page_id) { [INFO] [stderr] ... | [INFO] [stderr] 259 | | }, [INFO] [stderr] 260 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 241 | (self._contains_page(&page_id) || self.can_load_page()) && match *lock_type { [INFO] [stderr] 242 | LockType::Read => match self.writer_count.get(&page_id) { [INFO] [stderr] 243 | Some(n) if *n > 0 => false, [INFO] [stderr] 244 | _ => match self.pending_requests.get(&page_id) { [INFO] [stderr] 245 | Some(v) => { [INFO] [stderr] 246 | // if the next request is a write request, don't accept any [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | v.len() == 0 || v[0].lock_type == LockType::Write [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/io/cache.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | Some(self.page_map.get(&page_id).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.page_map.get(&page_id).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/io/cache.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | Some(self.page_map.get(&page_id).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.page_map[&page_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/cache.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | !(self.available_slots.is_empty() && self.page_lru.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.page_lru.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/io/cache.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | / loop { [INFO] [stderr] 295 | | match self.reader_count.receiver.try_recv() { [INFO] [stderr] 296 | | Ok(page_id) => { [INFO] [stderr] 297 | | self.decr_ref_count(&page_id, &LockType::Read); [INFO] [stderr] ... | [INFO] [stderr] 302 | | } [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(page_id) = self.reader_count.receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/io/cache.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | / loop { [INFO] [stderr] 305 | | match self.writer_count.receiver.try_recv() { [INFO] [stderr] 306 | | Ok(page_id) => { [INFO] [stderr] 307 | | self.decr_ref_count(&page_id, &LockType::Write); [INFO] [stderr] ... | [INFO] [stderr] 312 | | } [INFO] [stderr] 313 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(page_id) = self.writer_count.receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/io/cache.rs:348:33 [INFO] [stderr] | [INFO] [stderr] 348 | let mut index = match &lock { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 349 | | &PageLock {index, ..} => { [INFO] [stderr] 350 | | let buf = &mut self.page_data[(index*PAGE_SIZE) as usize .. ((index+1)*PAGE_SIZE) as usize]; [INFO] [stderr] 351 | | if load { [INFO] [stderr] ... | [INFO] [stderr] 356 | | } [INFO] [stderr] 357 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 348 | let mut index = match lock { [INFO] [stderr] 349 | PageLock {index, ..} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/io/dbfile.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / fn to_bytes<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 16 | | unsafe { [INFO] [stderr] 17 | | ::std::slice::from_raw_parts( [INFO] [stderr] 18 | | (self as *const Self) as *const u8, [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const io::dbfile::PageMetadata`) [INFO] [stderr] --> src/io/dbfile.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | ::std::ptr::read(page_data.as_ptr() as *const _) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/value.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match value_type { [INFO] [stderr] 15 | | &ValueType::Bool => Some(Value {uint_value: if bytes[0] != 0 {1} else {0}}), [INFO] [stderr] 16 | | &ValueType::Uint => Some(Value {uint_value: LittleEndian::read_u64(&bytes)}), [INFO] [stderr] 17 | | &ValueType::Int => Some(Value {int_value: LittleEndian::read_i64(&bytes)}), [INFO] [stderr] 18 | | &ValueType::Float => Some(Value {float_value: LittleEndian::read_f64(&bytes)}), [INFO] [stderr] 19 | | _ => None [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *value_type { [INFO] [stderr] 15 | ValueType::Bool => Some(Value {uint_value: if bytes[0] != 0 {1} else {0}}), [INFO] [stderr] 16 | ValueType::Uint => Some(Value {uint_value: LittleEndian::read_u64(&bytes)}), [INFO] [stderr] 17 | ValueType::Int => Some(Value {int_value: LittleEndian::read_i64(&bytes)}), [INFO] [stderr] 18 | ValueType::Float => Some(Value {float_value: LittleEndian::read_f64(&bytes)}), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/io/value.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match value_type { [INFO] [stderr] 26 | | &ValueType::Bool => bytes[0] = if self.bool_value {1} else {0}, [INFO] [stderr] 27 | | &ValueType::Uint => LittleEndian::write_u64(&mut bytes, self.uint_value), [INFO] [stderr] 28 | | &ValueType::Int => LittleEndian::write_i64(&mut bytes, self.int_value), [INFO] [stderr] 29 | | &ValueType::Float => LittleEndian::write_f64(&mut bytes, self.float_value), [INFO] [stderr] 30 | | _ => () [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *value_type { [INFO] [stderr] 26 | ValueType::Bool => bytes[0] = if self.bool_value {1} else {0}, [INFO] [stderr] 27 | ValueType::Uint => LittleEndian::write_u64(&mut bytes, self.uint_value), [INFO] [stderr] 28 | ValueType::Int => LittleEndian::write_i64(&mut bytes, self.int_value), [INFO] [stderr] 29 | ValueType::Float => LittleEndian::write_f64(&mut bytes, self.float_value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/model/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | to.write(self.to_ddl().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `soupdb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9953f7981a170b23e84f85f8d58a5fbe109e51a9ba7889e05d5b502e87f9cd8a"` [INFO] running `"docker" "rm" "-f" "9953f7981a170b23e84f85f8d58a5fbe109e51a9ba7889e05d5b502e87f9cd8a"` [INFO] [stdout] 9953f7981a170b23e84f85f8d58a5fbe109e51a9ba7889e05d5b502e87f9cd8a