[INFO] updating cached repository benbrunton/rust_minesweeper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benbrunton/rust_minesweeper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benbrunton/rust_minesweeper" "work/ex/clippy-test-run/sources/stable/gh/benbrunton/rust_minesweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benbrunton/rust_minesweeper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benbrunton/rust_minesweeper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benbrunton/rust_minesweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benbrunton/rust_minesweeper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7bbc1df016dc749c4e6b7dd1875cc00bca45d9b0 [INFO] sha for GitHub repo benbrunton/rust_minesweeper: 7bbc1df016dc749c4e6b7dd1875cc00bca45d9b0 [INFO] validating manifest of benbrunton/rust_minesweeper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benbrunton/rust_minesweeper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benbrunton/rust_minesweeper [INFO] finished frobbing benbrunton/rust_minesweeper [INFO] frobbed toml for benbrunton/rust_minesweeper written to work/ex/clippy-test-run/sources/stable/gh/benbrunton/rust_minesweeper/Cargo.toml [INFO] started frobbing benbrunton/rust_minesweeper [INFO] finished frobbing benbrunton/rust_minesweeper [INFO] frobbed toml for benbrunton/rust_minesweeper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benbrunton/rust_minesweeper/Cargo.toml [INFO] crate benbrunton/rust_minesweeper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benbrunton/rust_minesweeper against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benbrunton/rust_minesweeper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9dd21d22edbba6df8bf786e21d25062c9c917e66d85ac4bf5d31e6de2fda5b79 [INFO] running `"docker" "start" "-a" "9dd21d22edbba6df8bf786e21d25062c9c917e66d85ac4bf5d31e6de2fda5b79"` [INFO] [stderr] Checking libc v0.2.9 [INFO] [stderr] Checking mempool v0.3.1 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking aho-corasick v0.5.1 [INFO] [stderr] Checking regex v0.1.65 [INFO] [stderr] Checking rust-mines v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/board.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | write!(f, "{} ", "█") [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:162:32 [INFO] [stderr] | [INFO] [stderr] 162 | FieldView{view: tiles, field: field, game_over:false, mines: mines} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:162:63 [INFO] [stderr] | [INFO] [stderr] 162 | FieldView{view: tiles, field: field, game_over:false, mines: mines} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/board.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | write!(f, "{} ", "█") [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:162:32 [INFO] [stderr] | [INFO] [stderr] 162 | FieldView{view: tiles, field: field, game_over:false, mines: mines} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:162:63 [INFO] [stderr] | [INFO] [stderr] 162 | FieldView{view: tiles, field: field, game_over:false, mines: mines} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/board.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | let _ = write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let icon = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 28 | | &TileState::Mine => "♦".to_string(), [INFO] [stderr] 29 | | &TileState::Number(0) => " ".to_string(), [INFO] [stderr] 30 | | &TileState::Number(n) => n.to_string() [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | let icon = match *self { [INFO] [stderr] 28 | TileState::Mine => "♦".to_string(), [INFO] [stderr] 29 | TileState::Number(0) => " ".to_string(), [INFO] [stderr] 30 | TileState::Number(n) => n.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/board.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | rng.choose(&width_range).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rng.choose(&width_range).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/board.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | rng.choose(&height_range).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rng.choose(&height_range).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | row_num = row_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_num += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/board.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | fn is_mine(positions: &Vec<(u32, u32)>, x: u32, y: u32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, u32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/board.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | fn count_mines(positions: &Vec<(u32, u32)>, x: u32, y: u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, u32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | mines = mines + v.iter().filter(|&tile| tile.clone() == TileState::Mine).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mines += v.iter().filter(|&tile| tile.clone() == TileState::Mine).count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/board.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | self.game_over == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.game_over` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | flags = flags + v.iter().filter(|&tile| tile.clone() == Tile::Flag).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags += v.iter().filter(|&tile| tile.clone() == Tile::Flag).count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:316:17 [INFO] [stderr] | [INFO] [stderr] 316 | col_num = col_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `col_num += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | row_num = row_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_num += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let icon = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 28 | | &TileState::Mine => "♦".to_string(), [INFO] [stderr] 29 | | &TileState::Number(0) => " ".to_string(), [INFO] [stderr] 30 | | &TileState::Number(n) => n.to_string() [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | let icon = match *self { [INFO] [stderr] 28 | TileState::Mine => "♦".to_string(), [INFO] [stderr] 29 | TileState::Number(0) => " ".to_string(), [INFO] [stderr] 30 | TileState::Number(n) => n.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/board.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | rng.choose(&width_range).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rng.choose(&width_range).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/board.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | rng.choose(&height_range).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rng.choose(&height_range).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | row_num = row_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_num += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/board.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | fn is_mine(positions: &Vec<(u32, u32)>, x: u32, y: u32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, u32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/board.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | fn count_mines(positions: &Vec<(u32, u32)>, x: u32, y: u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, u32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | mines = mines + v.iter().filter(|&tile| tile.clone() == TileState::Mine).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mines += v.iter().filter(|&tile| tile.clone() == TileState::Mine).count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/board.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | self.game_over == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.game_over` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | flags = flags + v.iter().filter(|&tile| tile.clone() == Tile::Flag).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags += v.iter().filter(|&tile| tile.clone() == Tile::Flag).count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:316:17 [INFO] [stderr] | [INFO] [stderr] 316 | col_num = col_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `col_num += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | row_num = row_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_num += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.09s [INFO] running `"docker" "inspect" "9dd21d22edbba6df8bf786e21d25062c9c917e66d85ac4bf5d31e6de2fda5b79"` [INFO] running `"docker" "rm" "-f" "9dd21d22edbba6df8bf786e21d25062c9c917e66d85ac4bf5d31e6de2fda5b79"` [INFO] [stdout] 9dd21d22edbba6df8bf786e21d25062c9c917e66d85ac4bf5d31e6de2fda5b79