[INFO] updating cached repository beatmadsen/chess [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/beatmadsen/chess [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/beatmadsen/chess" "work/ex/clippy-test-run/sources/stable/gh/beatmadsen/chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/beatmadsen/chess'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/beatmadsen/chess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beatmadsen/chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beatmadsen/chess'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e4bd1f56a7ea4da6b7ea9f773601463b3ad9e610 [INFO] sha for GitHub repo beatmadsen/chess: e4bd1f56a7ea4da6b7ea9f773601463b3ad9e610 [INFO] validating manifest of beatmadsen/chess on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of beatmadsen/chess on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing beatmadsen/chess [INFO] finished frobbing beatmadsen/chess [INFO] frobbed toml for beatmadsen/chess written to work/ex/clippy-test-run/sources/stable/gh/beatmadsen/chess/Cargo.toml [INFO] started frobbing beatmadsen/chess [INFO] finished frobbing beatmadsen/chess [INFO] frobbed toml for beatmadsen/chess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beatmadsen/chess/Cargo.toml [INFO] crate beatmadsen/chess has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting beatmadsen/chess against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beatmadsen/chess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4fca579d6712b693c7171e1eeeadc6c70cfe073529c11c02394204b3a6a878e0 [INFO] running `"docker" "start" "-a" "4fca579d6712b693c7171e1eeeadc6c70cfe073529c11c02394204b3a6a878e0"` [INFO] [stderr] Checking chess v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Pawn` [INFO] [stderr] --> src/piece.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub struct Pawn {} [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Queen` [INFO] [stderr] --> src/piece.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub struct Queen {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `King` [INFO] [stderr] --> src/piece.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub struct King {} [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Knight` [INFO] [stderr] --> src/piece.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub struct Knight {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Rook` [INFO] [stderr] --> src/piece.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub struct Rook {} [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Square` [INFO] [stderr] --> src/square.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Square { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `legal_moves` [INFO] [stderr] --> src/square.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn legal_moves(&self) -> Vec<(Name, Name)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Position` [INFO] [stderr] --> src/square.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub struct Position { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `legal_moves` [INFO] [stderr] --> src/square.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn legal_moves(&self) -> Vec<(Name, Name)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn neighbour(&self, d: Direction) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn collect_neighbours(&self, d: Direction) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Pawn` [INFO] [stderr] --> src/piece.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub struct Pawn {} [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Queen` [INFO] [stderr] --> src/piece.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub struct Queen {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `King` [INFO] [stderr] --> src/piece.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub struct King {} [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Knight` [INFO] [stderr] --> src/piece.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub struct Knight {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Rook` [INFO] [stderr] --> src/piece.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub struct Rook {} [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Square` [INFO] [stderr] --> src/square.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Square { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `legal_moves` [INFO] [stderr] --> src/square.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn legal_moves(&self) -> Vec<(Name, Name)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Position` [INFO] [stderr] --> src/square.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub struct Position { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `legal_moves` [INFO] [stderr] --> src/square.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn legal_moves(&self) -> Vec<(Name, Name)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn neighbour(&self, d: Direction) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn collect_neighbours(&self, d: Direction) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "4fca579d6712b693c7171e1eeeadc6c70cfe073529c11c02394204b3a6a878e0"` [INFO] running `"docker" "rm" "-f" "4fca579d6712b693c7171e1eeeadc6c70cfe073529c11c02394204b3a6a878e0"` [INFO] [stdout] 4fca579d6712b693c7171e1eeeadc6c70cfe073529c11c02394204b3a6a878e0